Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77386/?format=api
{ "id": 77386, "url": "http://patches.dpdk.org/api/patches/77386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911120906.45995-4-joyce.kong@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911120906.45995-4-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911120906.45995-4-joyce.kong@arm.com", "date": "2020-09-11T12:09:06", "name": "[RFC,3/3] net/virtio: add election for packed vector Rx NEON path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "669d14c4ba9e8c1f036b41a1cb8f883f1b91513d", "submitter": { "id": 970, "url": "http://patches.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911120906.45995-4-joyce.kong@arm.com/mbox/", "series": [ { "id": 12147, "url": "http://patches.dpdk.org/api/series/12147/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12147", "date": "2020-09-11T12:09:03", "name": "Vectorize packed ring RX path with NEON", "version": 1, "mbox": "http://patches.dpdk.org/series/12147/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77386/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/77386/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31F1FA04B5;\n\tFri, 11 Sep 2020 14:09:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5F23F1C115;\n\tFri, 11 Sep 2020 14:09:28 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 61AC91C115\n for <dev@dpdk.org>; Fri, 11 Sep 2020 14:09:26 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F10AA13A1;\n Fri, 11 Sep 2020 05:09:25 -0700 (PDT)", "from net-arm-thunderx2-03.shanghai.arm.com\n (net-arm-thunderx2-03.shanghai.arm.com [10.169.210.123])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7C6043F68F;\n Fri, 11 Sep 2020 05:09:23 -0700 (PDT)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "maxime.coquelin@redhat.com", "Cc": "jerinj@marvell.com, dev@dpdk.org, nd@arm.com,\n honnappa.nagarahalli@arm.com,\n ruifeng.wang@arm.com, phil.yang@arm.com", "Date": "Fri, 11 Sep 2020 20:09:06 +0800", "Message-Id": "<20200911120906.45995-4-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200911120906.45995-1-joyce.kong@arm.com>", "References": "<20200911120906.45995-1-joyce.kong@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 3/3] net/virtio: add election for packed vector Rx\n\tNEON path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add NEON vectorized path selection logic. Default setting comes from\nvectorized devarg, then checks each criteria.\n\nPacked ring vectorized neon path need:\n NEON is supported by compiler and host\n VERSION_1 and IN_ORDER features are negotiated\n mergeable feature is not negotiated\n LRO offloading is disabled\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\n---\n doc/guides/nics/virtio.rst | 4 ++--\n drivers/net/virtio/virtio_ethdev.c | 19 +++++++++++++++----\n drivers/net/virtio/virtio_user_ethdev.c | 2 ++\n 3 files changed, 19 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst\nindex 0daf25b22..fe9586699 100644\n--- a/doc/guides/nics/virtio.rst\n+++ b/doc/guides/nics/virtio.rst\n@@ -483,8 +483,8 @@ according to below configuration:\n #. Packed virtqueue in-order non-mergeable path: If in-order feature is negotiated and\n Rx mergeable is not negotiated, this path will be selected.\n #. Packed virtqueue vectorized Rx path: If building and running environment support\n- AVX512 && in-order feature is negotiated && Rx mergeable is not negotiated &&\n- TCP_LRO Rx offloading is disabled && vectorized option enabled,\n+ (AVX512 || ARCH_ARM || ARCH_ARM64) && in-order feature is negotiated && Rx mergeable\n+ is not negotiated && TCP_LRO Rx offloading is disabled && vectorized option enabled,\n this path will be selected.\n #. Packed virtqueue vectorized Tx path: If building and running environment support\n AVX512 && in-order feature is negotiated && vectorized option enabled,\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex dc0093bdf..b36ea98cf 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1958,12 +1958,14 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n \t\tif (!vtpci_packed_queue(hw)) {\n \t\t\thw->use_vec_rx = 1;\n \t\t} else {\n-#if !defined(CC_AVX512_SUPPORT)\n-\t\t\tPMD_DRV_LOG(INFO,\n-\t\t\t\t\"building environment do not support packed ring vectorized\");\n-#else\n+#if defined(CC_AVX512_SUPPORT)\n \t\t\thw->use_vec_rx = 1;\n \t\t\thw->use_vec_tx = 1;\n+#elif defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)\n+\t\t\thw->use_vec_rx = 1;\n+#else\n+\t\t\tPMD_DRV_LOG(INFO,\n+\t\t\t\t\"building environment do not support packed ring vectorized\");\n #endif\n \t\t}\n \t}\n@@ -2311,6 +2313,15 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \t\t\thw->use_vec_rx = 0;\n \t\t\thw->use_vec_tx = 0;\n \t\t}\n+#elif defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)\n+\t\tif (hw->use_vec_rx &&\n+\t\t (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON) ||\n+\t\t !vtpci_with_feature(hw, VIRTIO_F_IN_ORDER) ||\n+\t\t !vtpci_with_feature(hw, VIRTIO_F_VERSION_1))) {\n+\t\t\tPMD_DRV_LOG(INFO,\n+\t\t\t\t\"disabled packed ring vectorized path for requirements not met\");\n+\t\t\thw->use_vec_rx = 0;\n+\t\t}\n #else\n \t\thw->use_vec_rx = 0;\n \t\thw->use_vec_tx = 0;\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 6003f6d50..1cfeb388f 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -766,6 +766,8 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n #if defined(CC_AVX512_SUPPORT)\n \t\t\thw->use_vec_rx = 1;\n \t\t\thw->use_vec_tx = 1;\n+#elif defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)\n+\t\t\thw->use_vec_rx = 1;\n #else\n \t\t\tPMD_INIT_LOG(INFO,\n \t\t\t\t\"building environment do not support packed ring vectorized\");\n", "prefixes": [ "RFC", "3/3" ] }