Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77368/?format=api
{ "id": 77368, "url": "http://patches.dpdk.org/api/patches/77368/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911083520.24020-9-sachin.saxena@oss.nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911083520.24020-9-sachin.saxena@oss.nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911083520.24020-9-sachin.saxena@oss.nxp.com", "date": "2020-09-11T08:35:20", "name": "[v2,8/8] net/dpaa: send error packets to application", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0337a38cfd7edf6ba0178d60226d88dfef405a30", "submitter": { "id": 1782, "url": "http://patches.dpdk.org/api/people/1782/?format=api", "name": "Sachin Saxena (OSS)", "email": "sachin.saxena@oss.nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911083520.24020-9-sachin.saxena@oss.nxp.com/mbox/", "series": [ { "id": 12138, "url": "http://patches.dpdk.org/api/series/12138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12138", "date": "2020-09-11T08:35:12", "name": "enhancement and fixes for nxp dpaax platform", "version": 2, "mbox": "http://patches.dpdk.org/series/12138/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77368/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B94BFA04B5;\n\tFri, 11 Sep 2020 10:36:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 407D71C196;\n\tFri, 11 Sep 2020 10:35:51 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65])\n by dpdk.org (Postfix) with ESMTP id 6F0FE1C12B\n for <dev@dpdk.org>; Fri, 11 Sep 2020 10:35:49 +0200 (CEST)", "from VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28)\n by VI1PR04MB6973.eurprd04.prod.outlook.com (2603:10a6:803:13d::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Fri, 11 Sep\n 2020 08:35:48 +0000", "from VI1PR04MB5837.eurprd04.prod.outlook.com\n ([fe80::cc01:9fe2:2544:8a4b]) by VI1PR04MB5837.eurprd04.prod.outlook.com\n ([fe80::cc01:9fe2:2544:8a4b%7]) with mapi id 15.20.3348.019; Fri, 11 Sep 2020\n 08:35:48 +0000", "from lsv03161.swis.in-blr01.nxp.com (14.142.151.118) by\n SG2PR04CA0178.apcprd04.prod.outlook.com (2603:1096:4:14::16) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 08:35:47 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=OAbkFUWafiT/i9QKH2dx/eKCQnsXTegBou4F+bIH3i5VVLiejEOpbeylWN0/eqIm8ueW7l+Z51VFP/aBJL4HRufi8Vs2iSBToZq4pH3R5zSwti3uj8ZqQ8EF2P5KnVNIWa6ZYQp9ZmGCKX15EN2/Y4x+Xa+Xy1pMHcG7UZKn+rIyWjF5fmvErCW6G/PE0zNcq+MlHq2jJ711r4u4gey2KIwYDkM7Cv6Mc0/spaCp1Tl3i74404YePoxezXTT1Qdas3RckWfpruaNruBZclHuvuAvVChsoHe2vjPUDbpRsKnfTqw+IisIcuK/R9Jfo3rG8XU6qFN+LTQEm64ovhC15g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=nkfeY9cK0bWzQLL4/e19HkzV4FJ7ZJSCyAai9mVP6ig=;\n b=Lsi0ovTdFMt6Ev9Ykvj+j91TqXIhisU7Hfs9B8ZO1Jix5Y6wqE4wJ8UWWNBkTdPbT7Zu5XmvkjmsSylnVb3vxKpTGeeetRqZA9D0CKk7hPwrF6Iw+l0tyT+vFedDCjHav4qiU/3QJmSQxPvVA/agwBHznjmJ6FPx7ryh+s5FCVU29u+iTUUSqNYMiB9KhTe+S5SmW8y/I1tNnI6bzTQvlDS2s7YKdfDsv2syaCKO5PzYj4YkzPCMomkxTaV/83QhWH1IpDVkJDUP/4wC60mG7luXHdPp3x+sw0DNb3kEE4M2n/TXSfQk1D9RBxeyTimEB6vaZSIWoaRZEaWiNPLs+w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;\n dkim=pass header.d=oss.nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n s=selector2-NXP1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=nkfeY9cK0bWzQLL4/e19HkzV4FJ7ZJSCyAai9mVP6ig=;\n b=G8nbCCKZQovXsrw6zc0ygW+GdpFrYwSdHop6aCqQOJO0AEQfMYulhwp62yuAo/RuzN7kBZIMFAhrZa3fg+Pl3q2Dfgi/myzIvBc65WeFYEH9zGJjN26an5TVusif6twDQ5zXskEOCUQt1NRC/LctdXM9OW/tt4WtrDyPvZ8WWrc=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com;", "From": "\"Sachin Saxena (OSS)\" <sachin.saxena@oss.nxp.com>", "To": "dev@dpdk.org,\n\tferruh.yigit@intel.com", "Date": "Fri, 11 Sep 2020 14:05:20 +0530", "Message-Id": "<20200911083520.24020-9-sachin.saxena@oss.nxp.com>", "X-Mailer": [ "git-send-email 2.28.0", "git-send-email 2.28.0" ], "In-Reply-To": "<20200911083520.24020-1-sachin.saxena@oss.nxp.com>", "References": "<20200911083520.24020-1-sachin.saxena@oss.nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR04CA0178.apcprd04.prod.outlook.com\n (2603:1096:4:14::16) To VI1PR04MB5837.eurprd04.prod.outlook.com\n (2603:10a6:803:ec::28)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[14.142.151.118]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "41a4c570-3b44-49da-9f87-08d8562daee9", "X-MS-TrafficTypeDiagnostic": "VI1PR04MB6973:", "X-MS-Exchange-SharedMailbox-RoutingAgent-Processed": "True", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <VI1PR04MB697347A2146104E434CA4BE9A2240@VI1PR04MB6973.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:854;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ar3raJtexxhju0PDJ6eItYoc3V6tsY73A6KGTZkLuPRIXEF0eiwKAw14gvYKBs7CSA6BXzAMDcfmGxSDCeTzdRzWRFYLrrumSlgXXWq+j9NnCTYcKrFa+CT7ItfFc/1XPIA1Tl/N7mLunotmliLPsLY0EFREvi7vtqwW8S5njPwZCn2thixEZJvQAL2HcohCB/ztSvV+XZtWSiPjYrZp7Hp6XNEDdn5OsjvRJypWM3DZlrK4ogod8fOu6YZHMUJqUQUlcerIuCaZMh24+5CkKXtPGwpjvhCUdWXq26UAdD5z5l8QsyNFC8ea4BHYqriieVo6r6IIUIZvbIrPWzxTB8eH5fhVDxRRftvlFZzPmyrG4K10vTLdcQq69JUfpo+e", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:VI1PR04MB5837.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(52116002)(86362001)(1076003)(66556008)(66946007)(2906002)(66476007)(8936002)(5660300002)(83380400001)(316002)(8676002)(2616005)(956004)(6512007)(16526019)(186003)(6486002)(1006002)(6666004)(26005)(6506007)(478600001)(55236004)(110426005);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n FbSR21mC1BJwOLBU8CNJDfiE7y5Ns/+0ce2+HvFg6cObpX1VjzndihLBVunFSUR1YbeaoF0m58M2gCGJHa83YwSmwB/nBIMUbR/f65jav/V3tV6IQYzaSWzNk6y9Sqkqx8iILsypaSkZyHnBSs23XoxLf24NTYEDjxzyMaFeMD1789Brtv5xZM09nY0D58ZI4iprcgXaDl5BvlRe0yWhpwYa1CQmO4ss3HhWFYl4oNyv75TATDZonAxH+jwMzyamk3GzRgRJt8Kfp7XYxOZH+Gbmvv5gXkMlHXuQTcxGr8USncvAZNyJTYcj7NgOza4+8izj2fR45X+i7RKD9FJShHoz+G36dcxKRNMepztokNEJ2QqqhGNDXAXVpXryjY+m+wEdWNVxrgRC6/m4x7mcs9t/r3p3v04rKGq7+VxYoHwv/ykqFmlwsbyufjUBDJMQ7S/RhxAehMXmaeaQ162iFME2qVzPUtneEbBGc61Z3qyDGqv/46BHoT0GUDijgEW2ahDeloYPeDqyFjUPSj52osrNvL4jWgIkq/D7Ri5F/1DKngUNGqhKooMY5aE+8/XpVkbMczUqWK7bMi/fKVwfQuJ4cJ3YnMTbDx4upZ/NgapmHohkPJ3HY76chxRXz0Z6I0kjRB6Vc8Elm/zI3I4Ssg==", "X-OriginatorOrg": "oss.nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 41a4c570-3b44-49da-9f87-08d8562daee9", "X-MS-Exchange-CrossTenant-AuthSource": "VI1PR04MB5837.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Sep 2020 08:35:48.5326 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n pj7JptusmIIxnNPIBxLdtz6eNZGAVwnZxkQZ5XK1nwUdgtq76N1LOF5kYMKsAxxOH8e1b1pHdTjE4bVIJI62aQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB6973", "Subject": "[dpdk-dev] [PATCH v2 8/8] net/dpaa: send error packets to\n\tapplication", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nSend error packets to main queue (rx) to make application\nenable to receive error packets.\n\nSigned-off-by: Rohit Raj <rohit.raj@nxp.com>\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 10 ++++------\n drivers/net/dpaa/dpaa_rxtx.c | 17 +++++++++++++----\n drivers/net/dpaa/dpaa_rxtx.h | 21 +++++++++++++++++++--\n 3 files changed, 36 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 66bb6eb00..edd63b0d2 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -1068,7 +1068,8 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t\trxq->fqid, ret);\n \t\t}\n \t}\n-\n+\t/* Enable main queue to receive error packets also by default */\n+\tfman_if_set_err_fqid(fif, rxq->fqid);\n \treturn 0;\n }\n \n@@ -2030,13 +2031,10 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)\n \t\tfman_intf->mac_addr.addr_bytes[5]);\n \n \tif (!fman_intf->is_shared_mac) {\n-\t\t/* Disable RX mode */\n-#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER\n+\t\t/* Configure error packet handling */\n \t\tfman_if_receive_rx_errors(fman_intf,\n \t\t\tFM_FD_RX_STATUS_ERR_MASK);\n-#else\n-\t\tfman_if_discard_rx_errors(fman_intf);\n-#endif\n+\t\t/* Disable RX mode */\n \t\tfman_if_disable_rx(fman_intf);\n \t\t/* Disable promiscuous mode */\n \t\tfman_if_promiscuous_disable(fman_intf);\ndiff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c\nindex 6eadbfa14..e4f012c23 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.c\n+++ b/drivers/net/dpaa/dpaa_rxtx.c\n@@ -125,6 +125,9 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, void *fd_virt_addr)\n \n \tDPAA_DP_LOG(DEBUG, \" Parsing mbuf: %p with annotations: %p\", m, annot);\n \n+\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_IP_CKSUM_GOOD |\n+\t\tPKT_RX_L4_CKSUM_GOOD;\n+\n \tswitch (prs) {\n \tcase DPAA_PKT_TYPE_IPV4:\n \t\tm->packet_type = RTE_PTYPE_L2_ETHER |\n@@ -199,6 +202,16 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, void *fd_virt_addr)\n \t\tm->packet_type = RTE_PTYPE_L2_ETHER |\n \t\t\tRTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_SCTP;\n \t\tbreak;\n+\tcase DPAA_PKT_TYPE_IPV4_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV6_CSUM_ERR:\n+\t\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_IP_CKSUM_BAD;\n+\t\tbreak;\n+\tcase DPAA_PKT_TYPE_IPV4_TCP_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV6_TCP_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV4_UDP_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV6_UDP_CSUM_ERR:\n+\t\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_L4_CKSUM_BAD;\n+\t\tbreak;\n \tcase DPAA_PKT_TYPE_NONE:\n \t\tm->packet_type = 0;\n \t\tbreak;\n@@ -213,10 +226,6 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, void *fd_virt_addr)\n \n \t/* Set the hash values */\n \tm->hash.rss = (uint32_t)(annot->hash);\n-\t/* All packets with Bad checksum are dropped by interface (and\n-\t * corresponding notification issued to RX error queues).\n-\t */\n-\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_IP_CKSUM_GOOD;\n \n \t/* Check if Vlan is present */\n \tif (prs & DPAA_PARSE_VLAN_MASK)\ndiff --git a/drivers/net/dpaa/dpaa_rxtx.h b/drivers/net/dpaa/dpaa_rxtx.h\nindex fe8eb6dc7..d9d7e04f5 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.h\n+++ b/drivers/net/dpaa/dpaa_rxtx.h\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2017 NXP\n+ * Copyright 2017,2020 NXP\n *\n */\n \n@@ -61,7 +61,7 @@\n *\t\t0x8000 - Ethernet type\n *\tShimR & Logical Port ID 0x0000\n */\n-#define DPAA_PARSE_MASK\t\t\t0x00E044ED00800000\n+#define DPAA_PARSE_MASK\t\t\t0x00F044EF00800000\n #define DPAA_PARSE_VLAN_MASK\t\t0x0000000000700000\n \n /* Parsed values (Little Endian) */\n@@ -137,6 +137,23 @@\n \t\t\t(0x0020000000000000 | DPAA_PKT_TYPE_TUNNEL_4_6)\n #define DPAA_PKT_TYPE_TUNNEL_6_4_TCP \\\n \t\t\t(0x0020000000000000 | DPAA_PKT_TYPE_TUNNEL_6_4)\n+\n+/* Checksum Errors */\n+#define DPAA_PKT_IP_CSUM_ERR\t\t0x0000400200000000\n+#define DPAA_PKT_L4_CSUM_ERR\t\t0x0010000000000000\n+#define DPAA_PKT_TYPE_IPV4_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_IP_CSUM_ERR | DPAA_PKT_TYPE_IPV4)\n+#define DPAA_PKT_TYPE_IPV6_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_IP_CSUM_ERR | DPAA_PKT_TYPE_IPV6)\n+#define DPAA_PKT_TYPE_IPV4_TCP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV4_TCP)\n+#define DPAA_PKT_TYPE_IPV6_TCP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV6_TCP)\n+#define DPAA_PKT_TYPE_IPV4_UDP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV4_UDP)\n+#define DPAA_PKT_TYPE_IPV6_UDP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV6_UDP)\n+\n #define DPAA_PKT_L3_LEN_SHIFT\t7\n \n /**\n", "prefixes": [ "v2", "8/8" ] }