Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77352/?format=api
{ "id": 77352, "url": "http://patches.dpdk.org/api/patches/77352/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911075911.3214-9-sachin.saxena@oss.nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911075911.3214-9-sachin.saxena@oss.nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911075911.3214-9-sachin.saxena@oss.nxp.com", "date": "2020-09-11T07:59:11", "name": "[v1,8/8] net/dpaa: send error packets to application", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0337a38cfd7edf6ba0178d60226d88dfef405a30", "submitter": { "id": 1782, "url": "http://patches.dpdk.org/api/people/1782/?format=api", "name": "Sachin Saxena (OSS)", "email": "sachin.saxena@oss.nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911075911.3214-9-sachin.saxena@oss.nxp.com/mbox/", "series": [ { "id": 12135, "url": "http://patches.dpdk.org/api/series/12135/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12135", "date": "2020-09-11T07:59:03", "name": "enhancements and fixes for nxp dpaax platform", "version": 1, "mbox": "http://patches.dpdk.org/series/12135/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77352/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77352/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 80D30A04B5;\n\tFri, 11 Sep 2020 10:00:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1F3331C190;\n\tFri, 11 Sep 2020 09:59:44 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr10051.outbound.protection.outlook.com [40.107.1.51])\n by dpdk.org (Postfix) with ESMTP id 039281C129\n for <dev@dpdk.org>; Fri, 11 Sep 2020 09:59:41 +0200 (CEST)", "from VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28)\n by VI1PR04MB6094.eurprd04.prod.outlook.com (2603:10a6:803:f4::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.17; Fri, 11 Sep\n 2020 07:59:40 +0000", "from VI1PR04MB5837.eurprd04.prod.outlook.com\n ([fe80::cc01:9fe2:2544:8a4b]) by VI1PR04MB5837.eurprd04.prod.outlook.com\n ([fe80::cc01:9fe2:2544:8a4b%7]) with mapi id 15.20.3348.019; Fri, 11 Sep 2020\n 07:59:40 +0000", "from lsv03161.swis.in-blr01.nxp.com (14.142.151.118) by\n SG2PR06CA0136.apcprd06.prod.outlook.com (2603:1096:1:1f::14) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 07:59:38 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cQF6M6IjQ4p+jCgTeUdsuIMcsE6P8f+E8DebXEuycbDwaLGYCtKmbGJmLTB+ek8J0X4iBPU/Gw9ECcnQfCw7A99REHwrd5tOpGKBlRu5kUbr6uN6AJivokVnTyAXw7h2Go0OEplwT5WHSDPaZsduHWCDscFIULENhDUbhdeiM4CE/5edxITeS+xK0Y6nWZtY1tM3xolnte/FsZcp+bM+sv46o7Wk9+3KTdq0TZXiWLuBB92ZSoUwQtF46N3jhgcIIrUSDkzhw/+oVzg85X9+MdURpFLzuWmJkj99QDyxU4xdQxl8iRccnX/FnqBoTXCFwiq3JptpV3ObNql1dRZQyw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LqHS0cxWOzJMvJUvOb7L8cJGVtJiXSTqqrihVyy6BIk=;\n b=e7aIHxuUoUl3eUUIqhf8DsUwIK37UlrH7Ddeh+DoPIfetKwBoQvIVjQ2Ai0OMBoPaOqkLOqmIlduHV3WNbRpVSou5rtjQCdVNizLpzt0ZnGluFPT5T6MCCPxIVZlEwWXo/StSEfyuXmdPGWImALbR7W/6RR4CZScO12uwd43uzAOtBpKrytuIPirLNF/BQu4gW6MBK9y23KO9E0BvmUcJJzqhQCWChfKzGg0CtVuvRZSYFAJHhH45IK41QBIKBHuU68PDQJE+bRx4Zt1WvKA2dYImqVgWC1hyAs7CsDpiHCWrX/StgtSGDz1IxdYcNu2hjqx24tqcFckfDCZVovwrw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;\n dkim=pass header.d=oss.nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n s=selector2-NXP1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LqHS0cxWOzJMvJUvOb7L8cJGVtJiXSTqqrihVyy6BIk=;\n b=OYI/Y31K+2Q9Ln7wqClvZQjtjI4rrz10wqpFeEShsIuYgst4ABy6YF+jTWrdQiXwYdnfx02W1Tmq/vLgpvwibI9VD6sXEHTdmIBdaKBhCoyqLfeflvH7MaF8vrkss5blOHIjqaPrvEHuGrP5fi65/QcV9C6yjpHRBd76ZA1V75U=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com;", "From": "\"Sachin Saxena (OSS)\" <sachin.saxena@oss.nxp.com>", "To": "dev@dpdk.org,\n\tferruh.yigit@intel.com", "Date": "Fri, 11 Sep 2020 13:29:11 +0530", "Message-Id": "<20200911075911.3214-9-sachin.saxena@oss.nxp.com>", "X-Mailer": [ "git-send-email 2.28.0", "git-send-email 2.28.0" ], "In-Reply-To": "<20200911075911.3214-1-sachin.saxena@oss.nxp.com>", "References": "<20200911075911.3214-1-sachin.saxena@oss.nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR06CA0136.apcprd06.prod.outlook.com\n (2603:1096:1:1f::14) To VI1PR04MB5837.eurprd04.prod.outlook.com\n (2603:10a6:803:ec::28)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[14.142.151.118]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "05f2bd8d-b5b7-44ff-acf4-08d85628a261", "X-MS-TrafficTypeDiagnostic": "VI1PR04MB6094:", "X-MS-Exchange-SharedMailbox-RoutingAgent-Processed": "True", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <VI1PR04MB6094068533BF13E9A6001649A2240@VI1PR04MB6094.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:854;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n H8lHvAq+hHwoUi2wyRE7xCOCohb+L8hBodWD0F+dk5TZ2i9PVfrJTuZoG9atQUkmK1TzjO16msDszN3uUwAZ+LdINYFrpVwXNR+qJReneSVcOiCDiOhlVRzqcROZZWXpnMYkVLztMP8TmRaGAXyx2P4dzO0iYS/RKY1I1lqq5O02djZlh+0QOUQ8KQh1GwQbFFRYgmRJUXeB/hYaw7zYDqKjJYPNtOWnngyseqm1ILbgMRMhjgEjNyJ2lelnS8U89Iz8j6WETsdNPk/YDAjHvbanYsBmElWHu5WiGolBBP+x5yJ0il8Lap+Uq4DomypIchv776p9Sqyk6pVJ2Pnq5gflMz/nM2QXLLELmQmYqEimQZohyT0sAubDC8LdS4bx", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:VI1PR04MB5837.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(366004)(478600001)(52116002)(2616005)(55236004)(86362001)(6486002)(6506007)(8676002)(316002)(16526019)(8936002)(26005)(186003)(6512007)(2906002)(956004)(5660300002)(66556008)(66476007)(1076003)(66946007)(83380400001)(6666004)(1006002)(110426005);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n ZJwr7/m+XZ9kPPZA7zHfdBXAxHnkTK7MsDvR9MJI7/DO6cj0SwH9gTAyR40sSDPJDm6mclXTL+eFRSxVFdB7NC+5watLQHSiEv4bSgcT1V77VCvqlBP33GFiLmPlDB63UD0R5pG5m2LnKoOAEYN5lGcjgJg0K8Yfc2EehPzR563GR8FJsUgWjkq7PatWpKX9XD7Xss0LQMH2UjCfeipgBVzu6nqrD9LQqqtymdSVgZHpCSzAqEJheHlc83G0JfRIPChFUQlDQ9+2KUzmapLVf8H1IDhTUy/TsyWix8C48tVQJI9f1kfPvM6AJeYdqh5lEGLcR48Fv2wBw6DL4dMt7aLVjfVZdJieaIXziY6F7AkPOkOt9rktm3LqBKYuum4miysX4V2rmgEoVivlOHfWePrOmEsUygmt13gp3HtEbTPX+p9uwWXxzhsZluUjhk+H2XFPhxcw6w71pRGbW3d7hSisHELGhSlDV1Wjhqy23nMqxQvDCq/i7pvnfrStN5rwlE5z1rHbcd8Zloqj7EoUMVbjb67TGAy8SVvc6W1vLKEvG7wrxcblcwkkUmL2y0AHJ0KgJNlNELrsd8ZkELfU+rZzs0f/bfwuG5Hm2RB6dCqheAQ8/h/zKx20mpmt0lvWmv1Z2QHFj47e8m9hgtQYeg==", "X-OriginatorOrg": "oss.nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 05f2bd8d-b5b7-44ff-acf4-08d85628a261", "X-MS-Exchange-CrossTenant-AuthSource": "VI1PR04MB5837.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Sep 2020 07:59:40.0303 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n VwDfvJDeZpEHYNIhvyeTmOYmvLwLVzkMlptST73D6Qw+v593OOdri+Imq14957Wx3iwKpQ4xYGBCcjkKK4xL1g==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB6094", "Subject": "[dpdk-dev] [PATCH v1 8/8] net/dpaa: send error packets to\n\tapplication", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nSend error packets to main queue (rx) to make application\nenable to receive error packets.\n\nSigned-off-by: Rohit Raj <rohit.raj@nxp.com>\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 10 ++++------\n drivers/net/dpaa/dpaa_rxtx.c | 17 +++++++++++++----\n drivers/net/dpaa/dpaa_rxtx.h | 21 +++++++++++++++++++--\n 3 files changed, 36 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 0c76fa610..d0ac2f987 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -1068,7 +1068,8 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t\trxq->fqid, ret);\n \t\t}\n \t}\n-\n+\t/* Enable main queue to receive error packets also by default */\n+\tfman_if_set_err_fqid(fif, rxq->fqid);\n \treturn 0;\n }\n \n@@ -2030,13 +2031,10 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)\n \t\tfman_intf->mac_addr.addr_bytes[5]);\n \n \tif (!fman_intf->is_shared_mac) {\n-\t\t/* Disable RX mode */\n-#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER\n+\t\t/* Configure error packet handling */\n \t\tfman_if_receive_rx_errors(fman_intf,\n \t\t\tFM_FD_RX_STATUS_ERR_MASK);\n-#else\n-\t\tfman_if_discard_rx_errors(fman_intf);\n-#endif\n+\t\t/* Disable RX mode */\n \t\tfman_if_disable_rx(fman_intf);\n \t\t/* Disable promiscuous mode */\n \t\tfman_if_promiscuous_disable(fman_intf);\ndiff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c\nindex 9715f3ce8..7aadf8b08 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.c\n+++ b/drivers/net/dpaa/dpaa_rxtx.c\n@@ -125,6 +125,9 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, void *fd_virt_addr)\n \n \tDPAA_DP_LOG(DEBUG, \" Parsing mbuf: %p with annotations: %p\", m, annot);\n \n+\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_IP_CKSUM_GOOD |\n+\t\tPKT_RX_L4_CKSUM_GOOD;\n+\n \tswitch (prs) {\n \tcase DPAA_PKT_TYPE_IPV4:\n \t\tm->packet_type = RTE_PTYPE_L2_ETHER |\n@@ -199,6 +202,16 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, void *fd_virt_addr)\n \t\tm->packet_type = RTE_PTYPE_L2_ETHER |\n \t\t\tRTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_SCTP;\n \t\tbreak;\n+\tcase DPAA_PKT_TYPE_IPV4_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV6_CSUM_ERR:\n+\t\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_IP_CKSUM_BAD;\n+\t\tbreak;\n+\tcase DPAA_PKT_TYPE_IPV4_TCP_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV6_TCP_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV4_UDP_CSUM_ERR:\n+\tcase DPAA_PKT_TYPE_IPV6_UDP_CSUM_ERR:\n+\t\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_L4_CKSUM_BAD;\n+\t\tbreak;\n \tcase DPAA_PKT_TYPE_NONE:\n \t\tm->packet_type = 0;\n \t\tbreak;\n@@ -213,10 +226,6 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, void *fd_virt_addr)\n \n \t/* Set the hash values */\n \tm->hash.rss = (uint32_t)(annot->hash);\n-\t/* All packets with Bad checksum are dropped by interface (and\n-\t * corresponding notification issued to RX error queues).\n-\t */\n-\tm->ol_flags = PKT_RX_RSS_HASH | PKT_RX_IP_CKSUM_GOOD;\n \n \t/* Check if Vlan is present */\n \tif (prs & DPAA_PARSE_VLAN_MASK)\ndiff --git a/drivers/net/dpaa/dpaa_rxtx.h b/drivers/net/dpaa/dpaa_rxtx.h\nindex fe8eb6dc7..d9d7e04f5 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.h\n+++ b/drivers/net/dpaa/dpaa_rxtx.h\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2017 NXP\n+ * Copyright 2017,2020 NXP\n *\n */\n \n@@ -61,7 +61,7 @@\n *\t\t0x8000 - Ethernet type\n *\tShimR & Logical Port ID 0x0000\n */\n-#define DPAA_PARSE_MASK\t\t\t0x00E044ED00800000\n+#define DPAA_PARSE_MASK\t\t\t0x00F044EF00800000\n #define DPAA_PARSE_VLAN_MASK\t\t0x0000000000700000\n \n /* Parsed values (Little Endian) */\n@@ -137,6 +137,23 @@\n \t\t\t(0x0020000000000000 | DPAA_PKT_TYPE_TUNNEL_4_6)\n #define DPAA_PKT_TYPE_TUNNEL_6_4_TCP \\\n \t\t\t(0x0020000000000000 | DPAA_PKT_TYPE_TUNNEL_6_4)\n+\n+/* Checksum Errors */\n+#define DPAA_PKT_IP_CSUM_ERR\t\t0x0000400200000000\n+#define DPAA_PKT_L4_CSUM_ERR\t\t0x0010000000000000\n+#define DPAA_PKT_TYPE_IPV4_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_IP_CSUM_ERR | DPAA_PKT_TYPE_IPV4)\n+#define DPAA_PKT_TYPE_IPV6_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_IP_CSUM_ERR | DPAA_PKT_TYPE_IPV6)\n+#define DPAA_PKT_TYPE_IPV4_TCP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV4_TCP)\n+#define DPAA_PKT_TYPE_IPV6_TCP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV6_TCP)\n+#define DPAA_PKT_TYPE_IPV4_UDP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV4_UDP)\n+#define DPAA_PKT_TYPE_IPV6_UDP_CSUM_ERR \\\n+\t\t\t(DPAA_PKT_L4_CSUM_ERR | DPAA_PKT_TYPE_IPV6_UDP)\n+\n #define DPAA_PKT_L3_LEN_SHIFT\t7\n \n /**\n", "prefixes": [ "v1", "8/8" ] }