Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77316/?format=api
{ "id": 77316, "url": "http://patches.dpdk.org/api/patches/77316/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599794967-17500-5-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599794967-17500-5-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599794967-17500-5-git-send-email-phil.yang@arm.com", "date": "2020-09-11T03:29:27", "name": "[4/4] ethdev: use C11 atomic builtins for link status update", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7365de70a5bdf881952260904e5fc3d1b275c295", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599794967-17500-5-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 12125, "url": "http://patches.dpdk.org/api/series/12125/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12125", "date": "2020-09-11T03:29:23", "name": "use C11 atomic builtins for libs", "version": 1, "mbox": "http://patches.dpdk.org/series/12125/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77316/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/77316/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6DDC7A04B5;\n\tFri, 11 Sep 2020 05:30:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F6681C113;\n\tFri, 11 Sep 2020 05:29:41 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id EFC1E1C113\n for <dev@dpdk.org>; Fri, 11 Sep 2020 05:29:39 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72DBE113E;\n Thu, 10 Sep 2020 20:29:39 -0700 (PDT)", "from phil-VirtualBox.shanghai.arm.com\n (phil-VirtualBox.shanghai.arm.com [10.169.182.49])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1FEFD3F73C;\n Thu, 10 Sep 2020 20:29:36 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, nd@arm.com,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>", "Date": "Fri, 11 Sep 2020 11:29:27 +0800", "Message-Id": "<1599794967-17500-5-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1599794967-17500-1-git-send-email-phil.yang@arm.com>", "References": "<1599794967-17500-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 4/4] ethdev: use C11 atomic builtins for link\n\tstatus update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since rte_atomicXX APIs are not allowed to be used, use C11 atomic\nbuiltins for link status update.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n lib/librte_ethdev/rte_ethdev_driver.h | 19 +++++--------------\n 1 file changed, 5 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h\nindex 13fd049..78590dd 100644\n--- a/lib/librte_ethdev/rte_ethdev_driver.h\n+++ b/lib/librte_ethdev/rte_ethdev_driver.h\n@@ -216,8 +216,7 @@ static inline int\n rte_eth_linkstatus_set(struct rte_eth_dev *dev,\n \t\t const struct rte_eth_link *new_link)\n {\n-\tvolatile uint64_t *dev_link\n-\t\t = (volatile uint64_t *)&(dev->data->dev_link);\n+\tuint64_t *dev_link = (uint64_t *)&(dev->data->dev_link);\n \tunion {\n \t\tuint64_t val64;\n \t\tstruct rte_eth_link link;\n@@ -225,8 +224,8 @@ rte_eth_linkstatus_set(struct rte_eth_dev *dev,\n \n \tRTE_BUILD_BUG_ON(sizeof(*new_link) != sizeof(uint64_t));\n \n-\torig.val64 = rte_atomic64_exchange(dev_link,\n-\t\t\t\t\t *(const uint64_t *)new_link);\n+\torig.val64 = __atomic_exchange_n(dev_link, (const uint64_t *)new_link,\n+\t\t\t\t\t__ATOMIC_SEQ_CST);\n \n \treturn (orig.link.link_status == new_link->link_status) ? -1 : 0;\n }\n@@ -244,20 +243,12 @@ static inline void\n rte_eth_linkstatus_get(const struct rte_eth_dev *dev,\n \t\t struct rte_eth_link *link)\n {\n-\tvolatile uint64_t *src = (uint64_t *)&(dev->data->dev_link);\n+\tuint64_t *src = (uint64_t *)&(dev->data->dev_link);\n \tuint64_t *dst = (uint64_t *)link;\n \n \tRTE_BUILD_BUG_ON(sizeof(*link) != sizeof(uint64_t));\n \n-#ifdef __LP64__\n-\t/* if cpu arch has 64 bit unsigned lon then implicitly atomic */\n-\t*dst = *src;\n-#else\n-\t/* can't use rte_atomic64_read because it returns signed int */\n-\tdo {\n-\t\t*dst = *src;\n-\t} while (!rte_atomic64_cmpset(src, *dst, *dst));\n-#endif\n+\t*dst = __atomic_load_n(src, __ATOMIC_SEQ_CST);\n }\n \n /**\n", "prefixes": [ "4/4" ] }