Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77286/?format=api
{ "id": 77286, "url": "http://patches.dpdk.org/api/patches/77286/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-25-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911015603.88359-25-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911015603.88359-25-ajit.khaparde@broadcom.com", "date": "2020-09-11T01:56:02", "name": "[24/25] net/bnxt: fix to check for vnic ptr in bnxt shutdown path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "216335852806bccc38c999de9a97b862d9cf8566", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-25-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 12116, "url": "http://patches.dpdk.org/api/series/12116/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12116", "date": "2020-09-11T01:55:38", "name": "patchset for bnxt", "version": 1, "mbox": "http://patches.dpdk.org/series/12116/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77286/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77286/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6E85A04B5;\n\tFri, 11 Sep 2020 04:00:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2B6AC1C1DB;\n\tFri, 11 Sep 2020 03:57:47 +0200 (CEST)", "from mail-pj1-f97.google.com (mail-pj1-f97.google.com\n [209.85.216.97]) by dpdk.org (Postfix) with ESMTP id 290141C1DB\n for <dev@dpdk.org>; Fri, 11 Sep 2020 03:57:45 +0200 (CEST)", "by mail-pj1-f97.google.com with SMTP id a9so946290pjg.1\n for <dev@dpdk.org>; Thu, 10 Sep 2020 18:57:45 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.57.42\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 10 Sep 2020 18:57:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=y7uarUNOUdnptQWat3WfCqgprombfm7QEzp6AytS+24=;\n b=BoPW/cbZsWxHespevKitZjsQv0o3C5Dr4RUpbcLTa9j918JO+illY8PI9WGFRQgp45\n ceRqkce4FDl+QvFvo979g93mP4656JpAe1OHxNo3Ikxm7xHChenURM44ZTtP/hdUi8e/\n my4tlqrNA5ZwMCqVvc+Btw2CuyVu9nphCx/YU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=y7uarUNOUdnptQWat3WfCqgprombfm7QEzp6AytS+24=;\n b=CRkx1Rm8j+t96RuUWqGQd4ue5vCqQN0VhVtOVJjLvEz792rvuWoFTg8fofF2D1Dice\n OBWtL8TyeJnjRCyGA9nq/fBAc29z7xRmDRLaIlr7NurK4JPn0DzQD06QgjN4D9IWCLvT\n v44NrtMdwbFUSspDQC38JBIixBa8imfYYUBzOvlJ6kekstPkIsCjtd1c/20/JZZZIquM\n nfuPFS1uq/Mp5UsOX+pq7vp48vLxegO192YoVkkg7PyuXcBeFWGTvUEC2W2yh6iCZvOx\n xFsLuCf5yn/oZdh+czZDbEytAcZQBxUxaH0Hs+Hrdd+fIO9uh0W1oy+nXpGbKuNY57gj\n Mm6A==", "X-Gm-Message-State": "AOAM531v8c2tqKuyNQuoTITBOxIf88lB8QcHWg7HgH5e0iWHmwoKpWoD\n RY7lPnAFrelmvRh+a1KNECJQ2jIA1HRQYPldcVd2/ZnoZ0bSJDkf7BZYTE7TiEBjeOcgOdji+Bx\n r8EBfvIc/QSyZEV1xA3OZn/mMln/eSDSDNxUr8EPqdfVlIZaHF9olcPpRBPSztGH1Bt1qrSYBYQ\n xRHQ==", "X-Google-Smtp-Source": "\n ABdhPJxlsnnbrIwLW2I0DxsvHbpR6ctQ406/hg71UIeBkkVOdClO8qQ/BUj7FMwabWzwa0B89MFkMufWqByc", "X-Received": "by 2002:a17:90b:104f:: with SMTP id\n gq15mr25075pjb.215.1599789464261;\n Thu, 10 Sep 2020 18:57:44 -0700 (PDT)", "X-Relaying-Domain": "broadcom.com", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>,\n\tstable@dpdk.org", "Date": "Thu, 10 Sep 2020 18:56:02 -0700", "Message-Id": "<20200911015603.88359-25-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>", "References": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 24/25] net/bnxt: fix to check for vnic ptr in\n\tbnxt shutdown path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nAdd a couple of NULL ptr checks in bnxt_free_all_filters()\nand bnxt_free_vnics() respectively to guard against certain error\ninjection/recovery scenarios where it was found that the application\nwas crashing with the bp->vnic_info ptr being NULL.\n\nFixes: 51fafb89a9a0 (\"net/bnxt: get rid of ff pools and use VNIC info array\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_filter.c | 14 +++++++++-----\n drivers/net/bnxt/bnxt_vnic.c | 3 +++\n 2 files changed, 12 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c\nindex d822ff607..6d8598324 100644\n--- a/drivers/net/bnxt/bnxt_filter.c\n+++ b/drivers/net/bnxt/bnxt_filter.c\n@@ -81,6 +81,15 @@ void bnxt_free_all_filters(struct bnxt *bp)\n \tstruct bnxt_filter_info *filter, *temp_filter;\n \tunsigned int i;\n \n+\tfor (i = 0; i < bp->pf->max_vfs; i++) {\n+\t\tSTAILQ_FOREACH(filter, &bp->pf->vf_info[i].filter, next) {\n+\t\t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n+\t\t}\n+\t}\n+\n+\tif (bp->vnic_info == NULL)\n+\t\treturn;\n+\n \tfor (i = 0; i < bp->nr_vnics; i++) {\n \t\tvnic = &bp->vnic_info[i];\n \t\tfilter = STAILQ_FIRST(&vnic->filter);\n@@ -95,11 +104,6 @@ void bnxt_free_all_filters(struct bnxt *bp)\n \t\tSTAILQ_INIT(&vnic->filter);\n \t}\n \n-\tfor (i = 0; i < bp->pf->max_vfs; i++) {\n-\t\tSTAILQ_FOREACH(filter, &bp->pf->vf_info[i].filter, next) {\n-\t\t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n-\t\t}\n-\t}\n }\n \n void bnxt_free_filter_mem(struct bnxt *bp)\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 326c0d1b6..9a135ae88 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -78,6 +78,9 @@ void bnxt_free_all_vnics(struct bnxt *bp)\n \tstruct bnxt_vnic_info *vnic;\n \tunsigned int i;\n \n+\tif (bp->vnic_info == NULL)\n+\t\treturn;\n+\n \tfor (i = 0; i < bp->max_vnics; i++) {\n \t\tvnic = &bp->vnic_info[i];\n \t\tSTAILQ_INSERT_TAIL(&bp->free_vnic_list, vnic, next);\n", "prefixes": [ "24/25" ] }