Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77273/?format=api
{ "id": 77273, "url": "http://patches.dpdk.org/api/patches/77273/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-12-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911015603.88359-12-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911015603.88359-12-ajit.khaparde@broadcom.com", "date": "2020-09-11T01:55:49", "name": "[11/25] net/bnxt: fix crash in VF rep queue selection", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aed43d0727d3a82f984f25a6293b9aad837c4e81", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-12-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 12116, "url": "http://patches.dpdk.org/api/series/12116/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12116", "date": "2020-09-11T01:55:38", "name": "patchset for bnxt", "version": 1, "mbox": "http://patches.dpdk.org/series/12116/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77273/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/77273/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15060A04B5;\n\tFri, 11 Sep 2020 03:58:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B12951C11D;\n\tFri, 11 Sep 2020 03:56:59 +0200 (CEST)", "from mail-pg1-f226.google.com (mail-pg1-f226.google.com\n [209.85.215.226]) by dpdk.org (Postfix) with ESMTP id 364441C116\n for <dev@dpdk.org>; Fri, 11 Sep 2020 03:56:58 +0200 (CEST)", "by mail-pg1-f226.google.com with SMTP id 34so5429530pgo.13\n for <dev@dpdk.org>; Thu, 10 Sep 2020 18:56:58 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.56.54\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 10 Sep 2020 18:56:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=MI/JHiC96O4c/wpe25GoQoUhMeU7wrr2yTdttTOusdw=;\n b=QU/dmZSFlYZKgadBaYc3Gcb4CM9bPlg4+ju+gd1wQhaiwKqWARULm56Eqfj8/5VoBu\n lphofd24AEPzMEJCCVc/zeP8AwaPtXcInYw3OnbhslT+cHpDZRYcznUJRtVke3S0n7ks\n jw/JhH0yQ280KieHlCbyuIcvcNh3+o4V4gUiM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=MI/JHiC96O4c/wpe25GoQoUhMeU7wrr2yTdttTOusdw=;\n b=Djkevwwpx5gXkDq7ijiK7Dc5R7Oxb10yUAoZH7RsCnIXl0uG7LJl5QnjBWm2TP/TZE\n tX0NK5H/lOcw+nd/4RVP1Mt4V9PsK1mudtyYmINC35lwtECsH4IHnjo2qtM1m69zVTj6\n 1TjQZSWPX6mVTlVdWQGHzTuVfQGebTeRLwY/XH5rC9+TkQpoV8c1j8MtoOAAiIXPsJQ2\n /yLn5LDijpx/0/hsb2mgCkCf9wprpDIy0KFIUg0TwsbI6kaBjY5uQXerJjSZvh9z8nIc\n GOmJ7FvCWtlBceIkK6N/FFKo2azjfwz1uQV8pgiADckp3DLBJQBsAk6ZmbLVT/MCHTj2\n wEmw==", "X-Gm-Message-State": "AOAM531cCbwrxAqQKkUPQtgA3wrewJi5jllGvXFbA5YAsLjh49ngz8FD\n KW8AMkKoy98t/gjNKuTZ6z9tkn+Kb83xY7QpEITa9ovg71jIe3M0B4HJOiMA/uS2eiXkATMhUko\n xLP8gc/ih/ZRpajMUjjBcS8yb21NlcXqTUHKagiP/sXzf1/dMUCSQv6ssps8uequD7qxuUEFwRH\n OGcA==", "X-Google-Smtp-Source": "\n ABdhPJzDLKWsz24SKwBSMKIHhi0dYDbE2H4SpnkS4STl3PBDh0rsNNbup3sZu8VLdhPDj5gmy3eLb3Sd+oz+", "X-Received": "by 2002:a17:902:9a88:: with SMTP id\n w8mr8381754plp.67.1599789417017;\n Thu, 10 Sep 2020 18:56:57 -0700 (PDT)", "X-Relaying-Domain": "broadcom.com", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Thu, 10 Sep 2020 18:55:49 -0700", "Message-Id": "<20200911015603.88359-12-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>", "References": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 11/25] net/bnxt: fix crash in VF rep queue\n\tselection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nInstead of bounds checking against max possible rings while selecting\nqueue index for the VF rep, do it against the configured number of rings.\n\nFixes: 6dc83230b43b (\"net/bnxt: support port representor data path\")\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/bnxt_reps.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex 9f535c0ce..6fa867a8a 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -45,9 +45,12 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf)\n \n \tvfr_eth_dev = &rte_eth_devices[port_id];\n \tvfr_bp = vfr_eth_dev->data->dev_private;\n-\t/* If rxq_id happens to be > max rep_queue, use rxq0 */\n-\tque = queue_id < BNXT_MAX_VF_REP_RINGS ? queue_id : 0;\n+\t/* If rxq_id happens to be > nr_rings, use ring 0 */\n+\tque = queue_id < vfr_bp->rx_nr_rings ? queue_id : 0;\n \trep_rxq = vfr_bp->rx_queues[que];\n+\t/* Ideally should not happen now, paranoid check */\n+\tif (!rep_rxq)\n+\t\treturn 1;\n \trep_rxr = rep_rxq->rx_ring;\n \tmask = rep_rxr->rx_ring_struct->ring_mask;\n \n", "prefixes": [ "11/25" ] }