Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77258/?format=api
{ "id": 77258, "url": "http://patches.dpdk.org/api/patches/77258/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911013038.19744-3-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911013038.19744-3-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911013038.19744-3-qi.z.zhang@intel.com", "date": "2020-09-11T01:30:35", "name": "[2/5] common/iavf: minor code clean on virtchnl", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f1e6e97a0efb75ef6cef9f0bd34ef3c318677be2", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911013038.19744-3-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 12115, "url": "http://patches.dpdk.org/api/series/12115/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12115", "date": "2020-09-11T01:30:33", "name": "iavf base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/12115/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77258/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 055D4A04B7;\n\tFri, 11 Sep 2020 03:27:02 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0DD9E1C0D4;\n\tFri, 11 Sep 2020 03:26:49 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id B41951BF90\n for <dev@dpdk.org>; Fri, 11 Sep 2020 03:26:45 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 18:26:45 -0700", "from dpdk51.sh.intel.com ([10.67.111.82])\n by orsmga008.jf.intel.com with ESMTP; 10 Sep 2020 18:26:44 -0700" ], "IronPort-SDR": [ "\n v/uhJdCjNj6j2yqlOKhEH64XFgeLpIA/M0Qpor6Mbfsju39YSXgie4AOU/Zmk05RGhmytGyDiD\n GrAgNvUhUWZw==", "\n ZwOUD5Hr9XK1/+qzAD/N5+mtt1PFAnjvQ5jGK2mysIVokD6QVsRsJ6DUD2o+tVElK5itoDl1/A\n xL6+f+Y6Waxw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9740\"; a=\"159614180\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"159614180\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"334362166\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "beilei.xing@intel.com", "Cc": "dev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Fri, 11 Sep 2020 09:30:35 +0800", "Message-Id": "<20200911013038.19744-3-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200911013038.19744-1-qi.z.zhang@intel.com>", "References": "<20200911013038.19744-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/5] common/iavf: minor code clean on virtchnl", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1. use BIT to replace <<\n2. move VIRTCHNL_VF_CAP_DCF to keep order\n3. align the vc msg validate\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/common/iavf/virtchnl.h | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h\nindex d93ef31ec..ebce68d60 100644\n--- a/drivers/common/iavf/virtchnl.h\n+++ b/drivers/common/iavf/virtchnl.h\n@@ -254,10 +254,11 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);\n #define VIRTCHNL_VF_OFFLOAD_ADQ\t\t\t0X00800000\n #define VIRTCHNL_VF_OFFLOAD_ADQ_V2\t\t0X01000000\n #define VIRTCHNL_VF_OFFLOAD_USO\t\t\t0X02000000\n-#define VIRTCHNL_VF_CAP_DCF\t\t\t0X40000000\n #define VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC\t0X04000000\n #define VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF\t\t0X08000000\n #define VIRTCHNL_VF_OFFLOAD_FDIR_PF\t\t0X10000000\n+\t/* 0X20000000 is reserved */\n+#define VIRTCHNL_VF_CAP_DCF\t\t\t0X40000000\n \t/* 0X80000000 is reserved */\n \n /* Define below the capability flags that are not offloads */\n@@ -690,7 +691,7 @@ struct virtchnl_dcf_vsi_map {\n \tu16 num_vfs;\t/* The actual number of VFs allocated */\n #define VIRTCHNL_DCF_VF_VSI_ID_S\t0\n #define VIRTCHNL_DCF_VF_VSI_ID_M\t(0xFFF << VIRTCHNL_DCF_VF_VSI_ID_S)\n-#define VIRTCHNL_DCF_VF_VSI_VALID\t(1 << 15)\n+#define VIRTCHNL_DCF_VF_VSI_VALID\tBIT(15)\n \tu16 vf_vsi[1];\n };\n \n@@ -1299,13 +1300,10 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,\n \t\t/* These two opcodes are specific to handle the AdminQ command,\n \t\t * so the validation needs to be done in PF's context.\n \t\t */\n-\t\treturn 0;\n+\t\tvalid_len = msglen;\n+\t\tbreak;\n \tcase VIRTCHNL_OP_DCF_DISABLE:\n \tcase VIRTCHNL_OP_DCF_GET_VSI_MAP:\n-\t\t/* The two opcodes are required by DCF without message buffer,\n-\t\t * so the valid length keeps the default value 0.\n-\t\t */\n-\t\tbreak;\n \tcase VIRTCHNL_OP_DCF_GET_PKG_INFO:\n \t\tbreak;\n \tcase VIRTCHNL_OP_GET_SUPPORTED_RXDIDS:\n", "prefixes": [ "2/5" ] }