Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77207/?format=api
{ "id": 77207, "url": "http://patches.dpdk.org/api/patches/77207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200910164716.1011901-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200910164716.1011901-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200910164716.1011901-3-bruce.richardson@intel.com", "date": "2020-09-10T16:47:15", "name": "[v2,2/3] app/test: change rawdev autotest to run selftest on all devs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8ba45e0dfbdbe4ca7950065dc645ccfe6111a59c", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200910164716.1011901-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12109, "url": "http://patches.dpdk.org/api/series/12109/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12109", "date": "2020-09-10T16:47:13", "name": "simplify unit-testing of rawdevs", "version": 2, "mbox": "http://patches.dpdk.org/series/12109/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77207/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77207/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1A974A04B5;\n\tThu, 10 Sep 2020 18:47:41 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ACBC81C11D;\n\tThu, 10 Sep 2020 18:47:39 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 91F521C11C\n for <dev@dpdk.org>; Thu, 10 Sep 2020 18:47:37 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 09:47:36 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga006.jf.intel.com with ESMTP; 10 Sep 2020 09:47:34 -0700" ], "IronPort-SDR": [ "\n owbiN7vLxDenLKuqFZrGqlQApt69VEkjAz77GqDT59eNrqO2TgI7qNOS42tcMzkAEYPbFF1BmH\n Fb9jgrjrnxWQ==", "\n isJ7vemeCHB0ydkfHAm1tdzQM1Pt0nCk5+aJUOZepb55WyoDEL9C2jskF66AV5AbVZrI8XIw8E\n PzVx4lA7tDbA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9740\"; a=\"158618980\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"158618980\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"304939284\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Nipun Gupta <nipun.gupta@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>", "Date": "Thu, 10 Sep 2020 17:47:15 +0100", "Message-Id": "<20200910164716.1011901-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200910164716.1011901-1-bruce.richardson@intel.com>", "References": "<20200821155945.29415-1-bruce.richardson@intel.com>\n <20200910164716.1011901-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 2/3] app/test: change rawdev autotest to run\n\tselftest on all devs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rather than having each rawdev provide its own autotest command, we can\ninstead just use the generic rawdev_autotest to test any and all available\nrawdevs.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_rawdev.c | 34 ++++++++++++++++++++++++--\n doc/guides/rel_notes/release_20_11.rst | 5 ++++\n 2 files changed, 37 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c\nindex d8d9595be1..7e2fb2cf27 100644\n--- a/app/test/test_rawdev.c\n+++ b/app/test/test_rawdev.c\n@@ -14,8 +14,13 @@\n static int\n test_rawdev_selftest_impl(const char *pmd, const char *opts)\n {\n+\tint ret;\n+\n+\tprintf(\"\\n### Test rawdev infrastructure using skeleton driver\\n\");\n \trte_vdev_init(pmd, opts);\n-\treturn rte_rawdev_selftest(rte_rawdev_get_dev_id(pmd));\n+\tret = rte_rawdev_selftest(rte_rawdev_get_dev_id(pmd));\n+\trte_vdev_uninit(pmd);\n+\treturn ret;\n }\n \n static int\n@@ -24,7 +29,32 @@ test_rawdev_selftest_skeleton(void)\n \treturn test_rawdev_selftest_impl(\"rawdev_skeleton\", \"\");\n }\n \n-REGISTER_TEST_COMMAND(rawdev_autotest, test_rawdev_selftest_skeleton);\n+static int\n+test_rawdev_selftests(void)\n+{\n+\tconst int count = rte_rawdev_count();\n+\tint ret = 0;\n+\tint i;\n+\n+\t/* basic sanity on rawdev infrastructure */\n+\tif (test_rawdev_selftest_skeleton() < 0)\n+\t\treturn -1;\n+\n+\t/* now run self-test on all rawdevs */\n+\tif (count > 0)\n+\t\tprintf(\"\\n### Run selftest on each available rawdev\\n\");\n+\tfor (i = 0; i < count; i++) {\n+\t\tint result = rte_rawdev_selftest(i);\n+\t\tprintf(\"Rawdev %u (%s) selftest: %s\\n\", i,\n+\t\t\t\trte_rawdevs[i].name,\n+\t\t\t\tresult == 0 ? \"Passed\" : \"Failed\");\n+\t\tret |= result;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+REGISTER_TEST_COMMAND(rawdev_autotest, test_rawdev_selftests);\n \n static int\n test_rawdev_selftest_ioat(void)\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex 667e3d54ad..2ac7dca9a0 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -93,6 +93,11 @@ API Changes\n and the function ``rte_rawdev_queue_conf_get()``\n from ``void`` to ``int`` allowing the return of error codes from drivers.\n \n+* rawdev: The running of a drivers ``selftest()`` function can now be done\n+ using the ``rawdev_autotest`` command in the ``dpdk-test`` binary. This\n+ command now calls the self-test function for each rawdev found on the\n+ system, and does not require a specific command per device type.\n+\n \n ABI Changes\n -----------\n", "prefixes": [ "v2", "2/3" ] }