Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77159/?format=api
{ "id": 77159, "url": "http://patches.dpdk.org/api/patches/77159/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-7-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200910143609.986696-7-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200910143609.986696-7-bruce.richardson@intel.com", "date": "2020-09-10T14:36:08", "name": "[v3,6/7] rawdev: mark start and stop functions optional", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a2913a1f3a74f92b3b9d090e54b9c4ce7876bef4", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-7-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12105, "url": "http://patches.dpdk.org/api/series/12105/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12105", "date": "2020-09-10T14:36:02", "name": "Enhance rawdev APIs", "version": 3, "mbox": "http://patches.dpdk.org/series/12105/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77159/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77159/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DABA6A04B5;\n\tThu, 10 Sep 2020 16:37:51 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D8341C123;\n\tThu, 10 Sep 2020 16:37:19 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id EEDCA1C119\n for <dev@dpdk.org>; Thu, 10 Sep 2020 16:37:16 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 07:37:16 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga006.jf.intel.com with ESMTP; 10 Sep 2020 07:37:15 -0700" ], "IronPort-SDR": [ "\n Rj7QsbfJkJN3iXWd1dOPxDb6p9DCxTB7Q0M1F5gZPR4g8+zDADyQMTk1g+vQtp4dq6h3hHkDeK\n YsKvkwi8Utjw==", "\n fAGT+5YtjoUYGjHs6BXMG2AnaxZjtW7xH/NEjpSx1MDlLws7Te3nvaIxsDZpBGXkENJ4tWMzIe\n 9mM6nohVS5YA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9739\"; a=\"138058427\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"138058427\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"304900412\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Thu, 10 Sep 2020 15:36:08 +0100", "Message-Id": "<20200910143609.986696-7-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200910143609.986696-1-bruce.richardson@intel.com>", "References": "<20200709152047.167730-1-bruce.richardson@intel.com>\n <20200910143609.986696-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 6/7] rawdev: mark start and stop functions\n\toptional", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Not all rawdevs will require a device start/stop function, so rather than\nrequiring such drivers to provide dummy functions, just set the\nstarted/stopped rawdev flag from the rawdev layer and return success.\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n lib/librte_rawdev/rte_rawdev.c | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c\nindex fd123bb848..36f3acf2b7 100644\n--- a/lib/librte_rawdev/rte_rawdev.c\n+++ b/lib/librte_rawdev/rte_rawdev.c\n@@ -398,20 +398,21 @@ rte_rawdev_start(uint16_t dev_id)\n \n \tRTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);\n \tdev = &rte_rawdevs[dev_id];\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_start, -ENOTSUP);\n-\n \tif (dev->started != 0) {\n \t\tRTE_RDEV_ERR(\"Device with dev_id=%\" PRIu8 \"already started\",\n \t\t\t dev_id);\n \t\treturn 0;\n \t}\n \n+\tif (dev->dev_ops->dev_start == NULL)\n+\t\tgoto mark_started;\n+\n \tdiag = (*dev->dev_ops->dev_start)(dev);\n-\tif (diag == 0)\n-\t\tdev->started = 1;\n-\telse\n+\tif (diag != 0)\n \t\treturn diag;\n \n+mark_started:\n+\tdev->started = 1;\n \treturn 0;\n }\n \n@@ -425,15 +426,18 @@ rte_rawdev_stop(uint16_t dev_id)\n \tRTE_RAWDEV_VALID_DEVID_OR_RET(dev_id);\n \tdev = &rte_rawdevs[dev_id];\n \n-\tRTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_stop);\n-\n \tif (dev->started == 0) {\n \t\tRTE_RDEV_ERR(\"Device with dev_id=%\" PRIu8 \"already stopped\",\n \t\t\tdev_id);\n \t\treturn;\n \t}\n \n+\tif (dev->dev_ops->dev_stop == NULL)\n+\t\tgoto mark_stopped;\n+\n \t(*dev->dev_ops->dev_stop)(dev);\n+\n+mark_stopped:\n \tdev->started = 0;\n }\n \n", "prefixes": [ "v3", "6/7" ] }