Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77158/?format=api
{ "id": 77158, "url": "http://patches.dpdk.org/api/patches/77158/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200910143609.986696-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200910143609.986696-6-bruce.richardson@intel.com", "date": "2020-09-10T14:36:07", "name": "[v3,5/7] rawdev: allow queue config query to return error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "434d6aa72caea804518c42df4bb70bc35d7998f7", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12105, "url": "http://patches.dpdk.org/api/series/12105/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12105", "date": "2020-09-10T14:36:02", "name": "Enhance rawdev APIs", "version": 3, "mbox": "http://patches.dpdk.org/series/12105/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77158/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77158/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 405FFA04B5;\n\tThu, 10 Sep 2020 16:37:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C02CC1C114;\n\tThu, 10 Sep 2020 16:37:16 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 498751BF8D\n for <dev@dpdk.org>; Thu, 10 Sep 2020 16:37:14 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 07:37:13 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga006.jf.intel.com with ESMTP; 10 Sep 2020 07:37:11 -0700" ], "IronPort-SDR": [ "\n OkiKhXtpOMJ+5fLdsbP1tF1IqgYfwGRrbvfT3THHk3CDb/FEB7U1V82govjd3TKVeIGe/BW1lH\n xWeJlPgiHFGw==", "\n zqpAS+BX5AYCrCYvlYrem9n5Ppbc3VoIP2gyRnYQmEJX4+CQtyPP5krtRvxNLgxK6Z3mJGGgup\n UAKmzbtVK8aw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9739\"; a=\"138058421\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"138058421\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"304900397\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Bruce Richardson <bruce.richardson@intel.com>,\n Nipun Gupta <nipun.gupta@nxp.com>, John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Thu, 10 Sep 2020 15:36:07 +0100", "Message-Id": "<20200910143609.986696-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200910143609.986696-1-bruce.richardson@intel.com>", "References": "<20200709152047.167730-1-bruce.richardson@intel.com>\n <20200910143609.986696-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 5/7] rawdev: allow queue config query to\n\treturn error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The driver APIs for returning the queue default config can fail if the\nparameters are invalid, or other reasons, so allow them to return error\ncodes to the rawdev layer and from hence to the app.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Nipun Gupta <nipun.gupta@nxp.com>\n\n---\nv3: add release note update\n---\n doc/guides/rel_notes/release_20_11.rst | 1 +\n drivers/raw/ntb/ntb.c | 6 ++++--\n drivers/raw/skeleton/skeleton_rawdev.c | 12 +++++++-----\n lib/librte_rawdev/rte_rawdev.c | 3 +--\n lib/librte_rawdev/rte_rawdev_pmd.h | 4 +++-\n 5 files changed, 16 insertions(+), 10 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex e79b88641b..667e3d54ad 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -90,6 +90,7 @@ API Changes\n allowing limited driver type-checking and ABI compatibility.\n \n * rawdev: Changed the return type of the function ``rte_dev_info_get()``\n+ and the function ``rte_rawdev_queue_conf_get()``\n from ``void`` to ``int`` allowing the return of error codes from drivers.\n \n \ndiff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c\nindex ad10857991..bddb1f5916 100644\n--- a/drivers/raw/ntb/ntb.c\n+++ b/drivers/raw/ntb/ntb.c\n@@ -246,7 +246,7 @@ ntb_dev_intr_handler(void *param)\n \t}\n }\n \n-static void\n+static int\n ntb_queue_conf_get(struct rte_rawdev *dev,\n \t\t uint16_t queue_id,\n \t\t rte_rawdev_obj_t queue_conf,\n@@ -256,11 +256,13 @@ ntb_queue_conf_get(struct rte_rawdev *dev,\n \tstruct ntb_hw *hw = dev->dev_private;\n \n \tif (conf_size != sizeof(*q_conf))\n-\t\treturn;\n+\t\treturn -EINVAL;\n \n \tq_conf->tx_free_thresh = hw->tx_queues[queue_id]->tx_free_thresh;\n \tq_conf->nb_desc = hw->rx_queues[queue_id]->nb_rx_desc;\n \tq_conf->rx_mp = hw->rx_queues[queue_id]->mpool;\n+\n+\treturn 0;\n }\n \n static void\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex 801c707fb9..f8b47a391a 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -220,10 +220,10 @@ static int skeleton_rawdev_reset(struct rte_rawdev *dev)\n \treturn 0;\n }\n \n-static void skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev,\n-\t\t\t\t\t uint16_t queue_id,\n-\t\t\t\t\t rte_rawdev_obj_t queue_conf,\n-\t\t\t\t\t size_t conf_size)\n+static int skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev,\n+\t\t\t\t\t uint16_t queue_id,\n+\t\t\t\t\t rte_rawdev_obj_t queue_conf,\n+\t\t\t\t\t size_t conf_size)\n {\n \tstruct skeleton_rawdev *skeldev;\n \tstruct skeleton_rawdev_queue *skelq;\n@@ -232,7 +232,7 @@ static void skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev,\n \n \tif (!dev || !queue_conf ||\n \t\t\tconf_size != sizeof(struct skeleton_rawdev_queue))\n-\t\treturn;\n+\t\treturn -EINVAL;\n \n \tskeldev = skeleton_rawdev_get_priv(dev);\n \tskelq = &skeldev->queues[queue_id];\n@@ -240,6 +240,8 @@ static void skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev,\n \tif (queue_id < SKELETON_MAX_QUEUES)\n \t\trte_memcpy(queue_conf, skelq,\n \t\t\tsizeof(struct skeleton_rawdev_queue));\n+\n+\treturn 0;\n }\n \n static void\ndiff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c\nindex f48d8cf10b..fd123bb848 100644\n--- a/lib/librte_rawdev/rte_rawdev.c\n+++ b/lib/librte_rawdev/rte_rawdev.c\n@@ -146,9 +146,8 @@ rte_rawdev_queue_conf_get(uint16_t dev_id,\n \tdev = &rte_rawdevs[dev_id];\n \n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_def_conf, -ENOTSUP);\n-\t(*dev->dev_ops->queue_def_conf)(dev, queue_id, queue_conf,\n+\treturn (*dev->dev_ops->queue_def_conf)(dev, queue_id, queue_conf,\n \t\t\tqueue_conf_size);\n-\treturn 0;\n }\n \n int\ndiff --git a/lib/librte_rawdev/rte_rawdev_pmd.h b/lib/librte_rawdev/rte_rawdev_pmd.h\nindex 34eb667f62..34dd7181b4 100644\n--- a/lib/librte_rawdev/rte_rawdev_pmd.h\n+++ b/lib/librte_rawdev/rte_rawdev_pmd.h\n@@ -215,8 +215,10 @@ typedef int (*rawdev_reset_t)(struct rte_rawdev *dev);\n * @param[out] queue_conf\n * Raw device queue configuration structure\n *\n+ * @return\n+ * Returns 0 on success, negative errno on failure\n */\n-typedef void (*rawdev_queue_conf_get_t)(struct rte_rawdev *dev,\n+typedef int (*rawdev_queue_conf_get_t)(struct rte_rawdev *dev,\n \t\t\t\t\tuint16_t queue_id,\n \t\t\t\t\trte_rawdev_obj_t queue_conf,\n \t\t\t\t\tsize_t queue_conf_size);\n", "prefixes": [ "v3", "5/7" ] }