Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77126/?format=api
{ "id": 77126, "url": "http://patches.dpdk.org/api/patches/77126/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599723455-353059-3-git-send-email-simei.su@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599723455-353059-3-git-send-email-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599723455-353059-3-git-send-email-simei.su@intel.com", "date": "2020-09-10T07:37:34", "name": "[v1,2/3] net/ice: add devarg for ACL ipv4 rule number", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e218188210801b5f220006cad41bc1f70a1127c9", "submitter": { "id": 1298, "url": "http://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599723455-353059-3-git-send-email-simei.su@intel.com/mbox/", "series": [ { "id": 12091, "url": "http://patches.dpdk.org/api/series/12091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12091", "date": "2020-09-10T07:37:32", "name": "net/ice: support DCF ACL capabiltiy", "version": 1, "mbox": "http://patches.dpdk.org/series/12091/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77126/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 917F5A04B5;\n\tThu, 10 Sep 2020 09:41:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6BC1C1C0D2;\n\tThu, 10 Sep 2020 09:41:24 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 7EA3D1C0D2\n for <dev@dpdk.org>; Thu, 10 Sep 2020 09:41:22 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 00:41:21 -0700", "from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com)\n ([10.67.110.178])\n by orsmga005.jf.intel.com with ESMTP; 10 Sep 2020 00:41:18 -0700" ], "IronPort-SDR": [ "\n 92BsQyQDpBJUD/DsXbCEi2V4sZ1agJyw2XsaGWG/BsjAeBnw5cXhJLw9/F7wsWrI3OifRlFJVp\n TBLenY9ByOEg==", "\n DGWAEZ8lWogFvOQmWb09dn8al8wYg3haHRLtlMKy5imsbz+9XKaR2PlqqtfNL9YHi1gXmO7KB5\n KyraWEg7Gqyw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9739\"; a=\"155884473\"", "E=Sophos;i=\"5.76,412,1592895600\"; d=\"scan'208\";a=\"155884473\"", "E=Sophos;i=\"5.76,412,1592895600\"; d=\"scan'208\";a=\"480787371\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "qi.z.zhang@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, haiyue.wang@intel.com, beilei.xing@intel.com,\n Simei Su <simei.su@intel.com>", "Date": "Thu, 10 Sep 2020 15:37:34 +0800", "Message-Id": "<1599723455-353059-3-git-send-email-simei.su@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599723455-353059-1-git-send-email-simei.su@intel.com>", "References": "<1599723455-353059-1-git-send-email-simei.su@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 2/3] net/ice: add devarg for ACL ipv4 rule\n\tnumber", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch enables devargs for ACL ipv4 rule number and refactor\nDCF capability selection API to be more flexible.\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/net/ice/ice_dcf_ethdev.c | 102 ++++++++++++++++++++++++++++++---------\n drivers/net/ice/ice_ethdev.h | 1 +\n 2 files changed, 80 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex 2faed3c..3238ce2 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -26,6 +26,16 @@\n #include \"ice_dcf_ethdev.h\"\n #include \"ice_rxtx.h\"\n \n+/* devargs */\n+#define ICE_DCF_CAP \"cap\"\n+#define ICE_DCF_ACL_IPV4_RULES_NUM \"acl_ipv4_nums\"\n+\n+static const char * const ice_dcf_valid_args[] = {\n+\tICE_DCF_CAP,\n+\tICE_DCF_ACL_IPV4_RULES_NUM,\n+\tNULL,\n+};\n+\n static uint16_t\n ice_dcf_recv_pkts(__rte_unused void *rx_queue,\n \t\t __rte_unused struct rte_mbuf **bufs,\n@@ -895,9 +905,51 @@\n };\n \n static int\n+parse_int(__rte_unused const char *key, const char *value, void *args)\n+{\n+\tint *i = (int *)args;\n+\tchar *end;\n+\tint num;\n+\n+\tnum = strtoul(value, &end, 10);\n+\t*i = num;\n+\n+\treturn 0;\n+}\n+\n+static int ice_dcf_parse_devargs(struct rte_eth_dev *dev)\n+{\n+\tstruct ice_dcf_adapter *adapter = dev->data->dev_private;\n+\tstruct ice_adapter *parent_adapter = &adapter->parent;\n+\n+\tstruct rte_devargs *devargs = dev->device->devargs;\n+\tstruct rte_kvargs *kvlist;\n+\tint ret;\n+\n+\tif (devargs == NULL)\n+\t\treturn 0;\n+\n+\tkvlist = rte_kvargs_parse(devargs->args, ice_dcf_valid_args);\n+\tif (kvlist == NULL) {\n+\t\tPMD_INIT_LOG(ERR, \"Invalid kvargs key\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tret = rte_kvargs_process(kvlist, ICE_DCF_ACL_IPV4_RULES_NUM,\n+\t\t&parse_int, &parent_adapter->devargs.acl_ipv4_rules_num);\n+\tif (ret)\n+\t\tgoto bail;\n+\n+bail:\n+\trte_kvargs_free(kvlist);\n+\treturn ret;\n+}\n+\n+static int\n ice_dcf_dev_init(struct rte_eth_dev *eth_dev)\n {\n \tstruct ice_dcf_adapter *adapter = eth_dev->data->dev_private;\n+\tint ret;\n \n \teth_dev->dev_ops = &ice_dcf_eth_dev_ops;\n \teth_dev->rx_pkt_burst = ice_dcf_recv_pkts;\n@@ -908,6 +960,12 @@\n \n \teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n+\tret = ice_dcf_parse_devargs(eth_dev);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to parse devargs\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \tadapter->real_hw.vc_event_msg_cb = ice_dcf_handle_pf_event_msg;\n \tif (ice_dcf_init_hw(eth_dev, &adapter->real_hw) != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to init DCF hardware\");\n@@ -932,49 +990,47 @@\n }\n \n static int\n-ice_dcf_cap_check_handler(__rte_unused const char *key,\n-\t\t\t const char *value, __rte_unused void *opaque)\n+handle_dcf_arg(__rte_unused const char *key, const char *value,\n+\t\t __rte_unused void *arg)\n {\n-\tif (strcmp(value, \"dcf\"))\n-\t\treturn -1;\n+\tbool *dcf = arg;\n+\n+\tif (arg == NULL || value == NULL)\n+\t\treturn -EINVAL;\n+\n+\tif (strcmp(value, \"dcf\") == 0)\n+\t\t*dcf = true;\n+\telse\n+\t\t*dcf = false;\n \n \treturn 0;\n }\n \n-static int\n-ice_dcf_cap_selected(struct rte_devargs *devargs)\n+static bool\n+check_cap_dcf_enable(struct rte_devargs *devargs)\n {\n \tstruct rte_kvargs *kvlist;\n-\tconst char *key = \"cap\";\n-\tint ret = 0;\n+\tbool enable = false;\n \n \tif (devargs == NULL)\n-\t\treturn 0;\n+\t\treturn false;\n \n \tkvlist = rte_kvargs_parse(devargs->args, NULL);\n \tif (kvlist == NULL)\n-\t\treturn 0;\n-\n-\tif (!rte_kvargs_count(kvlist, key))\n-\t\tgoto exit;\n-\n-\t/* dcf capability selected when there's a key-value pair: cap=dcf */\n-\tif (rte_kvargs_process(kvlist, key,\n-\t\t\t ice_dcf_cap_check_handler, NULL) < 0)\n-\t\tgoto exit;\n+\t\treturn false;\n \n-\tret = 1;\n+\trte_kvargs_process(kvlist, ICE_DCF_CAP, handle_dcf_arg, &enable);\n \n-exit:\n \trte_kvargs_free(kvlist);\n-\treturn ret;\n+\n+\treturn enable;\n }\n \n static int eth_ice_dcf_pci_probe(__rte_unused struct rte_pci_driver *pci_drv,\n \t\t\t struct rte_pci_device *pci_dev)\n {\n-\tif (!ice_dcf_cap_selected(pci_dev->device.devargs))\n-\t\treturn 1;\n+\tif (!check_cap_dcf_enable(pci_dev->device.devargs))\n+\t\treturn 1; /* continue to probe */\n \n \treturn rte_eth_dev_pci_generic_probe(pci_dev,\n \t\t\t\t\t sizeof(struct ice_dcf_adapter),\ndiff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h\nindex 758caa8..13f4167 100644\n--- a/drivers/net/ice/ice_ethdev.h\n+++ b/drivers/net/ice/ice_ethdev.h\n@@ -447,6 +447,7 @@ struct ice_devargs {\n \tint pipe_mode_support;\n \tint flow_mark_support;\n \tuint8_t proto_xtr[ICE_MAX_QUEUE_NUM];\n+\tint acl_ipv4_rules_num;\n };\n \n /**\n", "prefixes": [ "v1", "2/3" ] }