Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77065/?format=api
{ "id": 77065, "url": "http://patches.dpdk.org/api/patches/77065/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200909155302.28656-2-lance.richardson@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200909155302.28656-2-lance.richardson@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200909155302.28656-2-lance.richardson@broadcom.com", "date": "2020-09-09T15:52:54", "name": "[01/12] net/bnxt: fix burst mode get for Arm", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d04e8a0d9589ca8fadac33cb5d7201e99edaf292", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200909155302.28656-2-lance.richardson@broadcom.com/mbox/", "series": [ { "id": 12060, "url": "http://patches.dpdk.org/api/series/12060/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12060", "date": "2020-09-09T15:52:53", "name": "net/bnxt: vector PMD improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/12060/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77065/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77065/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E979CA04B5;\n\tWed, 9 Sep 2020 17:53:24 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 62ED51C0CE;\n\tWed, 9 Sep 2020 17:53:14 +0200 (CEST)", "from mail-pj1-f67.google.com (mail-pj1-f67.google.com\n [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 7D0631C0CD\n for <dev@dpdk.org>; Wed, 9 Sep 2020 17:53:13 +0200 (CEST)", "by mail-pj1-f67.google.com with SMTP id kk9so1560555pjb.2\n for <dev@dpdk.org>; Wed, 09 Sep 2020 08:53:13 -0700 (PDT)", "from localhost.localdomain ([192.19.231.250])\n by smtp.gmail.com with ESMTPSA id h15sm3188427pfo.23.2020.09.09.08.53.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Sep 2020 08:53:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ARxLoz6AxiMLK1VeQ63z6GCuJpZN1cUAzC3kNwlnzyA=;\n b=N3WwPHXrxEl+OYjIjlFTJpqH9IEsJy+IuRxyu4sQto4J9uev6Atm6rtKtrWZ05O9/p\n WwsvzR349rPCZhcQRvwxoLpfpQeJ8yu2Hibm6RQ1sezE/BF+2cBnICQFZWR0CWbrm/9I\n qSN1sN+WzOBhNw4ZiiSRuSmDMHe0LpXu1jrq4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ARxLoz6AxiMLK1VeQ63z6GCuJpZN1cUAzC3kNwlnzyA=;\n b=aoxl7TrqAmIvDMRaMUAD/DGX9HA8E6TmkIFA4biEyq7do3RMWfP8LzdgJ+Q6Mcv8mR\n A4kWtSW6SOOE52ekFzVA4Fgi2ztEw0fwU7VXK3uE9ATEcOwECVykC3WyFcjHWR8rpnnD\n FV9BttcnSU2RcdMLIqFhEqTgMaBWh88xZYx397GEVgHK1vB7JDry2k1Eh0v8Lmn29KQj\n PraTsNNtV54qU39OXJjcPXp6Z4DiDW5hz9wqXYH6K/QW1j+HEbnr+FFIShi+/Pz2ds3g\n R8fYZln8CTq8Ds7CWDpMob69tbBiY1jd9Andwyj4s3ZF8FrCForioHWBVIbEkxyfgv3U\n rC6A==", "X-Gm-Message-State": "AOAM533VnKVTq7OHzLz0ZknIoxRGR3/4nFmbINgAlB++N80dQVk+CnXn\n YBIKo4r+BZPbwyNeTZIdt3Wcj0YSu6iO9w==", "X-Google-Smtp-Source": "\n ABdhPJxiFnUOqRwwIth7HqcwETulkMl/rCay1AWrzxNemNrS7P90ub+wnFmRtOyxQbQaa+Kb5I378w==", "X-Received": "by 2002:a17:90a:414d:: with SMTP id\n m13mr1287679pjg.163.1599666792674;\n Wed, 09 Sep 2020 08:53:12 -0700 (PDT)", "From": "Lance Richardson <lance.richardson@broadcom.com>", "To": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Wed, 9 Sep 2020 11:52:54 -0400", "Message-Id": "<20200909155302.28656-2-lance.richardson@broadcom.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200909155302.28656-1-lance.richardson@broadcom.com>", "References": "<20200909155302.28656-1-lance.richardson@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/12] net/bnxt: fix burst mode get for Arm", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Transmit and receive burst mode get operations incorrectly return\n\"Vector SSE\" on ARM64 platforms, change to return \"Vector Neon\"\ninstead.\n\nFixes: 3983583414 (\"net/bnxt: support NEON\")\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nCc: stable@dpdk.org\n---\n drivers/net/bnxt/bnxt_ethdev.c | 60 +++++++++++++++++++++-------------\n 1 file changed, 38 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 75d055be00..7a77922c0c 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -2615,46 +2615,62 @@ bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->conf.tx_deferred_start = txq->tx_deferred_start;\n }\n \n+static const struct {\n+\teth_rx_burst_t pkt_burst;\n+\tconst char *info;\n+} bnxt_rx_burst_info[] = {\n+\t{bnxt_recv_pkts,\t\"Scalar\"},\n+#if defined(RTE_ARCH_X86)\n+\t{bnxt_recv_pkts_vec,\t\"Vector SSE\"},\n+#elif defined(RTE_ARCH_ARM64)\n+\t{bnxt_recv_pkts_vec,\t\"Vector Neon\"},\n+#endif\n+};\n+\n static int\n bnxt_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \t\t struct rte_eth_burst_mode *mode)\n {\n \teth_rx_burst_t pkt_burst = dev->rx_pkt_burst;\n+\tsize_t i;\n \n-\tif (pkt_burst == bnxt_recv_pkts) {\n-\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t \"Scalar\");\n-\t\treturn 0;\n-\t}\n-#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n-\tif (pkt_burst == bnxt_recv_pkts_vec) {\n-\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t \"Vector SSE\");\n-\t\treturn 0;\n+\tfor (i = 0; i < RTE_DIM(bnxt_rx_burst_info); i++) {\n+\t\tif (pkt_burst == bnxt_rx_burst_info[i].pkt_burst) {\n+\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n+\t\t\t\t bnxt_rx_burst_info[i].info);\n+\t\t\treturn 0;\n+\t\t}\n \t}\n-#endif\n \n \treturn -EINVAL;\n }\n \n+static const struct {\n+\teth_tx_burst_t pkt_burst;\n+\tconst char *info;\n+} bnxt_tx_burst_info[] = {\n+\t{bnxt_xmit_pkts,\t\"Scalar\"},\n+#if defined(RTE_ARCH_X86)\n+\t{bnxt_xmit_pkts_vec,\t\"Vector SSE\"},\n+#elif defined(RTE_ARCH_ARM64)\n+\t{bnxt_xmit_pkts_vec,\t\"Vector Neon\"},\n+#endif\n+};\n+\n static int\n bnxt_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \t\t struct rte_eth_burst_mode *mode)\n {\n \teth_tx_burst_t pkt_burst = dev->tx_pkt_burst;\n+\tsize_t i;\n \n-\tif (pkt_burst == bnxt_xmit_pkts) {\n-\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t \"Scalar\");\n-\t\treturn 0;\n-\t}\n-#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n-\tif (pkt_burst == bnxt_xmit_pkts_vec) {\n-\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t \"Vector SSE\");\n-\t\treturn 0;\n+\tfor (i = 0; i < RTE_DIM(bnxt_tx_burst_info); i++) {\n+\t\tif (pkt_burst == bnxt_tx_burst_info[i].pkt_burst) {\n+\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n+\t\t\t\t bnxt_tx_burst_info[i].info);\n+\t\t\treturn 0;\n+\t\t}\n \t}\n-#endif\n \n \treturn -EINVAL;\n }\n", "prefixes": [ "01/12" ] }