Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76979/?format=api
{ "id": 76979, "url": "http://patches.dpdk.org/api/patches/76979/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200909002247.864844-4-patrick.fu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200909002247.864844-4-patrick.fu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200909002247.864844-4-patrick.fu@intel.com", "date": "2020-09-09T00:22:47", "name": "[v1,3/3] lib/mirror: add flow based mirroring", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0ad7cf3d135a5ff36c80f5b89117b47f3b2473c", "submitter": { "id": 1781, "url": "http://patches.dpdk.org/api/people/1781/?format=api", "name": "Patrick Fu", "email": "patrick.fu@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200909002247.864844-4-patrick.fu@intel.com/mbox/", "series": [ { "id": 12036, "url": "http://patches.dpdk.org/api/series/12036/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12036", "date": "2020-09-09T00:22:44", "name": "lib: introduce traffic mirroring lib", "version": 1, "mbox": "http://patches.dpdk.org/series/12036/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76979/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/76979/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC3DCA04B1;\n\tWed, 9 Sep 2020 02:28:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E447A1C0D9;\n\tWed, 9 Sep 2020 02:28:38 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 14B531C0D9\n for <dev@dpdk.org>; Wed, 9 Sep 2020 02:28:36 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Sep 2020 17:28:36 -0700", "from npg-dpdk-patrickfu-casc2.sh.intel.com ([10.67.119.92])\n by fmsmga008.fm.intel.com with ESMTP; 08 Sep 2020 17:28:33 -0700" ], "IronPort-SDR": [ "\n KcaBuzMKwl1LDUmZlGNU49cGnFppfeCEqAhsyxQIXmTDNyQ2/yEveLN+zniiQ8/RA/lHbxuq6S\n R8mSrnZEtz5w==", "\n ieM1wcnL6ItDFC5fIEsbB3N8Tm5SuH2FgtFD5XykUkiaF+tiecGjtz35x17oceeYgvwCMPQsF2\n BSGeL8Suxfkw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9738\"; a=\"222453015\"", "E=Sophos;i=\"5.76,407,1592895600\"; d=\"scan'208\";a=\"222453015\"", "E=Sophos;i=\"5.76,407,1592895600\"; d=\"scan'208\";a=\"286051378\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Patrick Fu <patrick.fu@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, maxime.coquelin@redhat.com,\n bruce.richardson@intel.com, mm6021@att.com, zhihong.wang@intel.com,\n liang-min.wang@intel.com, konstantin.ananyev@intel.com,\n timothy.miskell@intel.com, cunming.liang@intel.com, patrick.fu@intel.com", "Date": "Wed, 9 Sep 2020 08:22:47 +0800", "Message-Id": "<20200909002247.864844-4-patrick.fu@intel.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20200909002247.864844-1-patrick.fu@intel.com>", "References": "<20200909002247.864844-1-patrick.fu@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 3/3] lib/mirror: add flow based mirroring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch add flow based mirroring support to the mirror lib.\nThe flow based mirroring is traffic mirroring with flow rules.\nApplications may either use a customized callback to apply their\nown flow rules, or use MAC matching rules implemented by mirror\nlib.\n\nSigned-off-by: Liang-min Wang <liang-min.wang@intel.com>\nSigned-off-by: Patrick Fu <patrick.fu@intel.com>\nSigned-off-by: Timothy Miskell <timothy.miskell@intel.com>\n---\n lib/librte_mirror/rte_mirror.c | 107 +++++++++++++++++++++++++++++++++\n 1 file changed, 107 insertions(+)", "diff": "diff --git a/lib/librte_mirror/rte_mirror.c b/lib/librte_mirror/rte_mirror.c\nindex d2c0d8eab..523ab37ff 100644\n--- a/lib/librte_mirror/rte_mirror.c\n+++ b/lib/librte_mirror/rte_mirror.c\n@@ -196,6 +196,101 @@ mirror_pkt_update(struct rte_mbuf *pkt, uint16_t dst_vlan_id)\n \trte_mbuf_refcnt_update(pkt, 1);\n }\n \n+static inline uint16_t\n+mirror_flow_cb(uint16_t qidx, struct rte_mbuf **pkts, uint16_t nb_pkts,\n+\t\tvoid *user_params, bool is_custom, uint8_t mac_offset)\n+{\n+\tstruct rte_mirror_param *data = user_params;\n+\tuint16_t i, dst_qidx, match_count = 0;\n+\tuint16_t pkt_trans;\n+\tuint16_t dst_port_id = data->dst_port_id;\n+\tuint16_t dst_vlan_id = data->dst_vlan_id;\n+\tuint64_t target_addr = *((uint64_t *)data->extra_data);\n+\tstruct rte_mbuf **pkt_buf = &data->pkt_buf[qidx*data->max_burst_size];\n+\tuint64_t *mac_addr = 0;\n+\n+\tif (nb_pkts == 0)\n+\t\treturn 0;\n+\n+\tif (nb_pkts > data->max_burst_size) {\n+\t\tMIRROR_LOG(ERR, \"Per-flow batch size, %d, exceeds \"\n+\t\t\t\"maximum limit, %d.\\n\", nb_pkts, data->max_burst_size);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (unlikely(is_custom)) {\n+\t\tfor (i = 0; i < nb_pkts; i++) {\n+\t\t\tif (data->custom_scan(pkts[i], user_params)) {\n+\t\t\t\tpkt_buf[match_count] = pkts[i];\n+\t\t\t\tmirror_pkt_update(pkt_buf[match_count],\n+\t\t\t\t\t\tdst_vlan_id);\n+\t\t\t\tmatch_count++;\n+\t\t\t}\n+\t\t}\n+\t} else {\n+\t\tfor (i = 0; i < nb_pkts; i++) {\n+\t\t\tmac_addr =\n+\t\t\t\trte_pktmbuf_mtod_offset(pkts[i],\n+\t\t\t\t\t\tuint64_t *, mac_offset);\n+\t\t\tif (is_mac_addr_match(target_addr, (*mac_addr))) {\n+\t\t\t\tpkt_buf[match_count] = pkts[i];\n+\t\t\t\tmirror_pkt_update(pkt_buf[match_count],\n+\t\t\t\t\t\tdst_vlan_id);\n+\t\t\t\tmatch_count++;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\tdst_qidx = (data->n_dst_queue > qidx) ? qidx : (data->n_dst_queue - 1);\n+\n+\trte_spinlock_lock(&data->locks[dst_qidx]);\n+\tpkt_trans = rte_eth_tx_burst(dst_port_id, dst_qidx,\n+\t\t\tpkt_buf, match_count);\n+\trte_spinlock_unlock(&data->locks[dst_qidx]);\n+\n+\tfor (i = 0; i < match_count; i++)\n+\t\tpkt_buf[i]->ol_flags &= ~VLAN_INSERT_FLAG;\n+\n+\twhile (unlikely(pkt_trans < match_count)) {\n+\t\trte_pktmbuf_free(pkt_buf[pkt_trans]);\n+\t\tpkt_trans++;\n+\t}\n+\n+\treturn nb_pkts;\n+}\n+\n+static uint16_t\n+mirror_rx_flow_custom_cb(uint16_t port_id __rte_unused, uint16_t qidx,\n+\tstruct rte_mbuf **pkts, uint16_t nb_pkts,\n+\tuint16_t maxi_pkts __rte_unused, void *user_params)\n+{\n+\treturn mirror_flow_cb(qidx, pkts, nb_pkts, user_params, true, 0);\n+}\n+\n+static uint16_t\n+mirror_tx_flow_custom_cb(uint16_t port_id __rte_unused, uint16_t qidx,\n+\tstruct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n+{\n+\treturn mirror_flow_cb(qidx, pkts, nb_pkts, user_params, true, 0);\n+}\n+\n+static uint16_t\n+mirror_rx_flow_mac_cb(uint16_t port_id __rte_unused, uint16_t qidx,\n+\tstruct rte_mbuf **pkts, uint16_t nb_pkts,\n+\tuint16_t maxi_pkts __rte_unused, void *user_params)\n+{\n+\treturn mirror_flow_cb(qidx, pkts, nb_pkts,\n+\t\t\tuser_params, false, DST_MAC_OFFSET);\n+}\n+\n+static uint16_t\n+mirror_tx_flow_mac_cb(uint16_t port_id __rte_unused, uint16_t qidx,\n+\tstruct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n+{\n+\treturn mirror_flow_cb(qidx, pkts, nb_pkts,\n+\t\t\tuser_params, false, SRC_MAC_OFFSET);\n+}\n+\n static inline uint16_t\n mirror_port_cb(uint16_t qidx, struct rte_mbuf **pkts,\n \tuint16_t nb_pkts, void *user_params)\n@@ -278,6 +373,18 @@ rte_mirror_offload_register(uint16_t src_port,\n \t\telse\n \t\t\trx_fn = mirror_rx_port_cb;\n \t\tbreak;\n+\tcase rte_mirror_type_flow_mac:\n+\t\tif (tx_cb)\n+\t\t\ttx_fn = mirror_tx_flow_mac_cb;\n+\t\telse\n+\t\t\trx_fn = mirror_rx_flow_mac_cb;\n+\t\tbreak;\n+\tcase rte_mirror_type_flow_custom:\n+\t\tif (tx_cb)\n+\t\t\ttx_fn = mirror_tx_flow_custom_cb;\n+\t\telse\n+\t\t\trx_fn = mirror_rx_flow_custom_cb;\n+\t\tbreak;\n \tdefault:\n \t\tMIRROR_LOG(ERR, \"Un-supported mirror offloading type!!!\\n\");\n \t\treturn -ENOTSUP;\n", "prefixes": [ "v1", "3/3" ] }