Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 76898,
    "url": "http://patches.dpdk.org/api/patches/76898/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200908091534.24305-2-adwivedi@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200908091534.24305-2-adwivedi@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200908091534.24305-2-adwivedi@marvell.com",
    "date": "2020-09-08T09:15:32",
    "name": "[1/3] test/event_crypto_adapter: return error with unsupported mode",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "89caafaf9e0d7d4b83f1f5bf6f20cb4200419e1c",
    "submitter": {
        "id": 1561,
        "url": "http://patches.dpdk.org/api/people/1561/?format=api",
        "name": "Ankur Dwivedi",
        "email": "adwivedi@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200908091534.24305-2-adwivedi@marvell.com/mbox/",
    "series": [
        {
            "id": 12016,
            "url": "http://patches.dpdk.org/api/series/12016/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12016",
            "date": "2020-09-08T09:15:31",
            "name": "Bug fixes in event crypto adapter test application",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/12016/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/76898/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/76898/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1D334A04AA;\n\tTue,  8 Sep 2020 11:17:59 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0537E1C1AF;\n\tTue,  8 Sep 2020 11:16:10 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 0F16B1C0CA\n for <dev@dpdk.org>; Tue,  8 Sep 2020 11:16:03 +0200 (CEST)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 0889AxwG007267; Tue, 8 Sep 2020 02:16:03 -0700",
            "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0b-0016f401.pphosted.com with ESMTP id 33ccvr1q8h-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 08 Sep 2020 02:16:03 -0700",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 8 Sep 2020 02:16:02 -0700",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 8 Sep 2020 02:16:01 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 8 Sep 2020 02:16:01 -0700",
            "from hyd1349.t110.caveonetworks.com (unknown [10.29.45.13])\n by maili.marvell.com (Postfix) with ESMTP id 323C93F7043;\n Tue,  8 Sep 2020 02:15:58 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=y+CnRYVh9T6ULkTDdfsqJ813qCek04+gvjl/10+kJ8k=;\n b=B4Hg5ZLd1j9S9prFre5XeMZOxnkjdDLzlQUzPnyn9drT9+7xxGVjg5nELmwkUjCC6fa0\n wf44sWYxKc1HM0rJtLs7H5fHn2RZHPI1U3/FrZ29DuzlH8qm3m/6iFHYWsIu277pUf/w\n 59gCZyqA2CfVJr+FbpkYN/7j4C/dRIUB2D+EJ09nevwx6JzfDBogXHzxhKZcrVrsYuAt\n o0gXdzqSGSz8JbGIP+y200olNAIk1xQCr9kSlKZ6LxS08RegW19jI+BQd+6zxbjeiSWL\n xL4eL6BLXiQvPJAjQ/yoolZkSLj69TfXFPxOzTNoEBIqTqK2s43Dpn5z1f5GgjuFc5m1 qw==",
        "From": "Ankur Dwivedi <adwivedi@marvell.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<abhinandan.gujjar@intel.com>, <jerinj@marvell.com>, <anoobj@marvell.com>,\n Ankur Dwivedi <adwivedi@marvell.com>",
        "Date": "Tue, 8 Sep 2020 14:45:32 +0530",
        "Message-ID": "<20200908091534.24305-2-adwivedi@marvell.com>",
        "X-Mailer": "git-send-email 2.28.0",
        "In-Reply-To": "<20200908091534.24305-1-adwivedi@marvell.com>",
        "References": "<20200908091534.24305-1-adwivedi@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-09-08_04:2020-09-08,\n 2020-09-08 signatures=0",
        "Subject": "[dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with\n\tunsupported mode",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The capability of a event device should be checked before creating\na event crypto adapter in a particular mode. The test case returns\nerror if the mode is not supported.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\n---\n app/test/test_event_crypto_adapter.c | 30 ++++++++++++++++++----------\n 1 file changed, 20 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c\nindex 8d42462d8..930c2a9bc 100644\n--- a/app/test/test_event_crypto_adapter.c\n+++ b/app/test/test_event_crypto_adapter.c\n@@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum rte_event_crypto_adapter_mode mode)\n \tuint32_t cap;\n \tint ret;\n \n+\tret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap);\n+\tTEST_ASSERT_SUCCESS(ret, \"Failed to get adapter capabilities\\n\");\n+\n+\tif ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) &&\n+\t    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))\n+\t\treturn -ENOTSUP;\n+\n+\tif ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) &&\n+\t    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))\n+\t\treturn -ENOTSUP;\n+\n \t/* Create adapter with default port creation callback */\n \tret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,\n-\t\t\t\t\t      TEST_CDEV_ID,\n+\t\t\t\t\t      evdev,\n \t\t\t\t\t      &conf, mode);\n \tTEST_ASSERT_SUCCESS(ret, \"Failed to create event crypto adapter\\n\");\n \n-\tret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);\n-\tTEST_ASSERT_SUCCESS(ret, \"Failed to get adapter capabilities\\n\");\n-\n \tif (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {\n \t\tret = rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID,\n \t\t\t\tTEST_CDEV_ID, TEST_CDEV_QP_ID, &response_info);\n@@ -813,6 +821,8 @@ test_crypto_adapter_conf(enum rte_event_crypto_adapter_mode mode)\n \t\t\tTEST_ASSERT(ret >= 0, \"Failed to link queue %d \"\n \t\t\t\t\t\"port=%u\\n\", qid,\n \t\t\t\t\tparams.crypto_event_port_id);\n+\t\t} else {\n+\t\t\treturn ret;\n \t\t}\n \t\tcrypto_adapter_setup_done = 1;\n \t}\n@@ -845,24 +855,24 @@ static int\n test_crypto_adapter_conf_op_forward_mode(void)\n {\n \tenum rte_event_crypto_adapter_mode mode;\n+\tint ret;\n \n \tmode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;\n-\tTEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),\n-\t\t\t\t\"Failed to config crypto adapter\");\n+\tret = test_crypto_adapter_conf(mode);\n \n-\treturn TEST_SUCCESS;\n+\treturn ret;\n }\n \n static int\n test_crypto_adapter_conf_op_new_mode(void)\n {\n \tenum rte_event_crypto_adapter_mode mode;\n+\tint ret;\n \n \tmode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;\n-\tTEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),\n-\t\t\t\t\"Failed to config crypto adapter\");\n+\tret = test_crypto_adapter_conf(mode);\n \n-\treturn TEST_SUCCESS;\n+\treturn ret;\n }\n \n \n",
    "prefixes": [
        "1/3"
    ]
}