Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76896/?format=api
{ "id": 76896, "url": "http://patches.dpdk.org/api/patches/76896/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-11-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599556475-27820-11-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599556475-27820-11-git-send-email-arybchenko@solarflare.com", "date": "2020-09-08T09:14:30", "name": "[09/14] net/sfc: avoid panic in the case of MCDI timeout", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e44b60a5c2b3d959a7a04bd71900c218271e3f21", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-11-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12014, "url": "http://patches.dpdk.org/api/series/12014/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12014", "date": "2020-09-08T09:14:20", "name": "net/sfc: factor out common driver library", "version": 1, "mbox": "http://patches.dpdk.org/series/12014/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76896/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76896/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E23B0A04AA;\n\tTue, 8 Sep 2020 11:17:40 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F19561C1A1;\n\tTue, 8 Sep 2020 11:16:07 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A9C181C10D\n for <dev@dpdk.org>; Tue, 8 Sep 2020 11:16:03 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.144])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 5278020075 for <dev@dpdk.org>; Tue, 8 Sep 2020 09:16:03 +0000 (UTC)", "from us4-mdac16-48.at1.mdlocal (unknown [10.110.50.131])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id B9C57800BB\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:16:02 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.12])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id B29F340133\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:55 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 697A540067\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:55 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 8 Sep 2020 10:14:49 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 0889EnGV032428\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 95D1F1613A9\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 8 Sep 2020 10:14:30 +0100", "Message-ID": "<1599556475-27820-11-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "References": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-TM-AS-Result": "No-0.137400-8.000000-10", "X-TMASE-MatchedRID": "PPPqS2B+Ni0pk5K7iexxzC2416nc3bQleouvej40T4gd0WOKRkwsh3Io\n zGa69omdrdoLblq9S5o2rW8Pb51lrtLucdA1OHpB0MohG+IQ2sfy++SyyVe4t1VkJxysad/IeOb\n QA+fBlTa8WuXMAMHMHjpzQoT/n3/mNyl1nd9CIt0URSScn+QSXl1PyA7eE+Ph+gtHj7OwNO3ClX\n +2r3j3WC+of4vgxtzMb5XhMobMnGETr691g6nSWRp24KintwkLxgiCVINc87CsPGMacX2fm5LSs\n JKPozupjexyWJd6V8uETBIpmSWuHgAD0FqlZdom0b4rJ92tmtF/d7a9VsfzMGYfzNl+uie3Vcr2\n 04P67pw=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-0.137400-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-MDID": "1599556562-y7rUYF3ss5W7", "Subject": "[dpdk-dev] [PATCH 09/14] net/sfc: avoid panic in the case of MCDI\n\ttimeout", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Implement dummy MCDI timeout handling which simply rejects\nfurther MCDI requests.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_mcdi.c | 15 +++++++++++++--\n drivers/net/sfc/sfc_mcdi.h | 1 +\n 2 files changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc/sfc_mcdi.c\nindex 8f446e8bc8..928a08c0a2 100644\n--- a/drivers/net/sfc/sfc_mcdi.c\n+++ b/drivers/net/sfc/sfc_mcdi.c\n@@ -33,6 +33,9 @@\n \t\t\t\tRTE_FMT_TAIL(__VA_ARGS__,)));\t\t\\\n \t} while (0)\n \n+#define sfc_efx_mcdi_crit(mcdi, ...) \\\n+\tsfc_efx_mcdi_log(mcdi, RTE_LOG_CRIT, __VA_ARGS__)\n+\n #define sfc_efx_mcdi_err(mcdi, ...) \\\n \tsfc_efx_mcdi_log(mcdi, RTE_LOG_ERR, __VA_ARGS__)\n \n@@ -55,7 +58,9 @@ sfc_efx_mcdi_timeout(struct sfc_adapter *sa)\n \n \tsfc_efx_mcdi_warn(mcdi, \"MC TIMEOUT\");\n \n-\tsfc_panic(sa, \"MCDI timeout handling is not implemented\\n\");\n+\tmcdi->state = SFC_EFX_MCDI_DEAD;\n+\tsfc_efx_mcdi_crit(mcdi,\n+\t\t\"MCDI timeout handling is not implemented - NIC is unusable\");\n }\n \n static inline boolean_t\n@@ -124,6 +129,11 @@ sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n \tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n \tuint32_t proxy_handle;\n \n+\tif (mcdi->state == SFC_EFX_MCDI_DEAD) {\n+\t\temrp->emr_rc = ENOEXEC;\n+\t\treturn;\n+\t}\n+\n \trte_spinlock_lock(&mcdi->lock);\n \n \tSFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED);\n@@ -325,7 +335,8 @@ sfc_efx_mcdi_fini(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi)\n \n \trte_spinlock_lock(&mcdi->lock);\n \n-\tSFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED);\n+\tSFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED ||\n+\t\t mcdi->state == SFC_EFX_MCDI_DEAD);\n \tmcdi->state = SFC_EFX_MCDI_UNINITIALIZED;\n \n \tsfc_efx_mcdi_info(mcdi, \"fini MCDI\");\ndiff --git a/drivers/net/sfc/sfc_mcdi.h b/drivers/net/sfc/sfc_mcdi.h\nindex e2105364ad..b93b268e32 100644\n--- a/drivers/net/sfc/sfc_mcdi.h\n+++ b/drivers/net/sfc/sfc_mcdi.h\n@@ -27,6 +27,7 @@ enum sfc_efx_mcdi_state {\n \tSFC_EFX_MCDI_INITIALIZED,\n \tSFC_EFX_MCDI_BUSY,\n \tSFC_EFX_MCDI_COMPLETED,\n+\tSFC_EFX_MCDI_DEAD,\n \n \tSFC_EFX_MCDI_NSTATES\n };\n", "prefixes": [ "09/14" ] }