Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76887/?format=api
{ "id": 76887, "url": "http://patches.dpdk.org/api/patches/76887/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-7-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599556475-27820-7-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599556475-27820-7-git-send-email-arybchenko@solarflare.com", "date": "2020-09-08T09:14:26", "name": "[05/14] net/sfc: make MCDI logging helper macros local", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "87d2db1acc51fa1d40f45f757477eb78c8e97170", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-7-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12014, "url": "http://patches.dpdk.org/api/series/12014/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12014", "date": "2020-09-08T09:14:20", "name": "net/sfc: factor out common driver library", "version": 1, "mbox": "http://patches.dpdk.org/series/12014/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76887/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76887/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 78EE3A04AA;\n\tTue, 8 Sep 2020 11:16:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E84431C10E;\n\tTue, 8 Sep 2020 11:15:48 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E1A6B2BAB\n for <dev@dpdk.org>; Tue, 8 Sep 2020 11:15:45 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.143])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 725032009B for <dev@dpdk.org>; Tue, 8 Sep 2020 09:15:45 +0000 (UTC)", "from us4-mdac16-29.at1.mdlocal (unknown [10.110.49.213])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 5EE6E8009B\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:15:45 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.12])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 1A2E140110\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:55 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D7AD840059\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:54 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 8 Sep 2020 10:14:49 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 0889EnO5032416\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 671691613A9\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 8 Sep 2020 10:14:26 +0100", "Message-ID": "<1599556475-27820-7-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "References": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-TM-AS-Result": "No-8.731200-8.000000-10", "X-TMASE-MatchedRID": "tcizGzo33Igi+Ly1jF96cbsHVDDM5xAPgcsVZH3dOCQGmHr1eMxt2UAc\n 6DyoS2rIOelg+pLqPPFsGcpYVjbbPr5FkoP8eT9ncaD+wPaBYtZIevoF6P4wcjbpMgyAfh26jGd\n KRTlT9kLb2VJ5zpbgoclZ9hhLEWzEex0yPqto0a/knMSTG9lH+KIik2/euMx1VWQnHKxp38iUR6\n 6C6i5v83xL67a3d6gmRT5xeSl5IKJ5OVTeAyRyiLBZAi3nrnzbYCdLkMLwLkPNOks35FeGOaPFj\n JEFr+olwXCBO/GKkVqOhzOa6g8KrQDfSq9t4KACXbrUBOI3b4zrqJKHagbR08XkP1A0PpolqOOv\n oFiXspE=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--8.731200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-MDID": "1599556545-hLz-dcBJeo9g", "Subject": "[dpdk-dev] [PATCH 05/14] net/sfc: make MCDI logging helper macros\n\tlocal", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Prepare to move MCDI helpers to drivers/common.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_log.h | 11 -----------\n drivers/net/sfc/sfc_mcdi.c | 21 ++++++++++++++++-----\n 2 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_log.h b/drivers/net/sfc/sfc_log.h\nindex 5383091c76..4bf44b1f15 100644\n--- a/drivers/net/sfc/sfc_log.h\n+++ b/drivers/net/sfc/sfc_log.h\n@@ -28,9 +28,6 @@ extern uint32_t sfc_logtype_driver;\n /** Device MCDI log type name prefix */\n #define SFC_LOGTYPE_MCDI_STR\tSFC_LOGTYPE_PREFIX \"mcdi\"\n \n-/** Level value used by MCDI log statements */\n-#define SFC_LOG_LEVEL_MCDI\tRTE_LOG_INFO\n-\n /* Log PMD message, automatically add prefix and \\n */\n #define SFC_LOG(sas, level, type, ...) \\\n \tdo {\t\t\t\t\t\t\t\t\\\n@@ -92,13 +89,5 @@ extern uint32_t sfc_logtype_driver;\n \t\t\t\tRTE_FMT_TAIL(__VA_ARGS__ ,)));\t\t\\\n \t} while (0)\n \n-#define sfc_log_mcdi(sa, ...) \\\n-\tdo {\t\t\t\t\t\t\t\t\\\n-\t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n-\t\t\t\t\t\t\t\t\t\\\n-\t\tSFC_LOG(_sa->priv.shared, SFC_LOG_LEVEL_MCDI,\t\t\\\n-\t\t\t_sa->mcdi.logtype, __VA_ARGS__);\t\t\\\n-\t} while (0)\n-\n \n #endif /* _SFC_LOG_H_ */\ndiff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc/sfc_mcdi.c\nindex c97a33d558..c716caabdf 100644\n--- a/drivers/net/sfc/sfc_mcdi.c\n+++ b/drivers/net/sfc/sfc_mcdi.c\n@@ -23,6 +23,17 @@\n #define SFC_EFX_MCDI_POLL_INTERVAL_MAX_US\t(US_PER_S / 10)\t/* 100ms */\n #define SFC_EFX_MCDI_WATCHDOG_INTERVAL_US\t(10 * US_PER_S)\t/* 10s */\n \n+/** Level value used by MCDI log statements */\n+#define SFC_EFX_LOG_LEVEL_MCDI\tRTE_LOG_INFO\n+\n+#define sfc_efx_log_mcdi(sa, ...) \\\n+\tdo {\t\t\t\t\t\t\t\t\\\n+\t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tSFC_LOG(_sa->priv.shared, SFC_EFX_LOG_LEVEL_MCDI,\t\\\n+\t\t\t_sa->mcdi.logtype, __VA_ARGS__);\t\t\\\n+\t} while (0)\n+\n static void\n sfc_efx_mcdi_timeout(struct sfc_adapter *sa)\n {\n@@ -178,7 +189,7 @@ sfc_efx_mcdi_do_log(const struct sfc_adapter *sa,\n \t\t\t * at the end which is required by netlogdecode.\n \t\t\t */\n \t\t\tbuffer[position] = '\\0';\n-\t\t\tsfc_log_mcdi(sa, \"%s \\\\\", buffer);\n+\t\t\tsfc_efx_log_mcdi(sa, \"%s \\\\\", buffer);\n \t\t\t/* Preserve prefix for the next log message */\n \t\t\tposition = pfxsize;\n \t\t}\n@@ -207,11 +218,11 @@ sfc_efx_mcdi_logger(void *arg, efx_log_msg_t type,\n \t *\n \t * To avoid wasting time, the actual level is examined in advance.\n \t */\n-\tif (rte_log_get_level(sa->mcdi.logtype) < (int)SFC_LOG_LEVEL_MCDI)\n+\tif (rte_log_get_level(sa->mcdi.logtype) < (int)SFC_EFX_LOG_LEVEL_MCDI)\n \t\treturn;\n \n-\t/* The format including prefix added by sfc_log_mcdi() is the format\n-\t * consumed by the Solarflare netlogdecode tool.\n+\t/* The format including prefix added by sfc_efx_log_mcdi() is the\n+\t * format consumed by the Solarflare netlogdecode tool.\n \t */\n \tpfxsize = snprintf(buffer, sizeof(buffer), \"MCDI RPC %s:\",\n \t\t\t type == EFX_LOG_MCDI_REQUEST ? \"REQ\" :\n@@ -222,7 +233,7 @@ sfc_efx_mcdi_logger(void *arg, efx_log_msg_t type,\n \t\t\t\t pfxsize, start);\n \tif (start != pfxsize) {\n \t\tbuffer[start] = '\\0';\n-\t\tsfc_log_mcdi(sa, \"%s\", buffer);\n+\t\tsfc_efx_log_mcdi(sa, \"%s\", buffer);\n \t}\n }\n \n", "prefixes": [ "05/14" ] }