Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76789/?format=api
{ "id": 76789, "url": "http://patches.dpdk.org/api/patches/76789/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200907220711.437405-8-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200907220711.437405-8-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200907220711.437405-8-thomas@monjalon.net", "date": "2020-09-07T22:06:47", "name": "[v4,07/31] examples/vm_power: convert to pkg-config-based build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "93759bc8b7af3b79277a3a8114a8013cbe1041b9", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200907220711.437405-8-thomas@monjalon.net/mbox/", "series": [ { "id": 12000, "url": "http://patches.dpdk.org/api/series/12000/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12000", "date": "2020-09-07T22:06:40", "name": "remove make support in DPDK", "version": 4, "mbox": "http://patches.dpdk.org/series/12000/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76789/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/76789/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49CBDA04AA;\n\tTue, 8 Sep 2020 00:08:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A663E1C19A;\n\tTue, 8 Sep 2020 00:07:34 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3E9CD1C120\n for <dev@dpdk.org>; Tue, 8 Sep 2020 00:07:30 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id E19C05C002F;\n Mon, 7 Sep 2020 18:07:29 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute7.internal (MEProxy); Mon, 07 Sep 2020 18:07:29 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 1539F3280059;\n Mon, 7 Sep 2020 18:07:29 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=+SZkVop2R1Qnf\n U5XL3c/Wm6vMeQbQcorNLbQkRHbPao=; b=o+OApbvfI0ZVsJpdS7q4enbOUEi4b\n rPjfp2hkXyqlUKVR38xSmrRnX2A1nOsf8ZELGcDs0hKC3liEg5SLWRfRvMdCNTTg\n qlDsroMBb++dPmZEX8afGkgVs6/H2mZ3hXTAoQ476X4KyFpa0hYc51kBH3+8Fa/v\n 5CoxW2++gNDSQ6aibGavqPoiTyUOQYaxPqDkSozQ/hfvYJPpT/pxU47vUr4yupXZ\n 7kjKjIYbB1GOysF6sRsx8v3X/52t/fLxl7uvttfQsN+C1OdWLa1Wex7y6MPuskU4\n AkQXorJdpUzr10NYuPvjtuuDpmi30uESX36Lzb31qAi/ZglsJzvfbZt5Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=+SZkVop2R1QnfU5XL3c/Wm6vMeQbQcorNLbQkRHbPao=; b=DepKLsSt\n 5SG3qqeFoK3DAbC/FGUY2/vKnE6QsxQP2KNdf8e1CkkfeJNZeEWFHgFcoI+6trEm\n KRh6VE/laqzVzx1zSldgdzLOZYOptHr0QJ56FLjqGviaV6er5Hjg4CywaahUUDhM\n xi2vozPoQBa9sUWJ9A+Ac29Qs3/Wtjj9U0G0VhhZgJ5aoTG4U/0PHfx5qxZqWKU+\n jK6aZUGQKy41XMJt/OszuvZrYlbekpPi1H7FPE/1MO3Fb5M7kuNAkeWN1B55Tzsj\n 0dXQH8oWvqDAtq2PR5wFWkfXLOHc58OtPwYAplcuYpZJ89kdc5l7dQQy0ii2GOOx\n SvB7v254DoTs0A==" ], "X-ME-Sender": "<xms:Ia9WXxEgt-5u_aZ7GXN4uxcVDR_RKX3GtXEoagrARZOn9SbPeGEWmA>\n <xme:Ia9WX2UJasDb6T2nyip-Ti0yLJOzD2PxUc2QQonsc0hz_H9KJFXePm5UVlbt90wl1\n 52eCgP7UY7Dfzzh4w>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudehuddgtdefucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre\n dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes\n mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvieeivedvffelffdttd\n duffduuedugfelvdelkefgteejkeekhfeiledvueefkeenucffohhmrghinhepvhgrrhhs\n rdhmkhdpghhnuhdrohhrghdpvgigthgrphhprdhmkhenucfkphepjeejrddufeegrddvtd\n efrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho\n mhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:Ia9WXzIWE2jgDirs8De-oqz6fenZqfI2orQadMidMyYA9IMSgWDvyA>\n <xmx:Ia9WX3HLDI1XFbJYEHA5p5KNyD35yxA2Bw7B3W0jCV6nwOxKpBQl_Q>\n <xmx:Ia9WX3XpqVNM2lRjgZlyZJjnslEwwlPvpetUngyDITIfjOik4S7ycQ>\n <xmx:Ia9WX-dzrdIrm91jhQTiU0gy46tQS9Vi9Vx-a2_7lMvXSYaYOVLMvA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, bruce.richardson@intel.com,\n ciara.power@intel.com", "Date": "Tue, 8 Sep 2020 00:06:47 +0200", "Message-Id": "<20200907220711.437405-8-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200907220711.437405-1-thomas@monjalon.net>", "References": "<20200903152717.42095-1-ciara.power@intel.com>\n <20200907220711.437405-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 07/31] examples/vm_power: convert to\n\tpkg-config-based build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nConvert the makefiles to build using pkg-config\nrather than the old build system.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vm_power_manager/Makefile | 76 ++++++++++----------\n examples/vm_power_manager/guest_cli/Makefile | 50 ++++++++-----\n 2 files changed, 67 insertions(+), 59 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/Makefile b/examples/vm_power_manager/Makefile\nindex 65c2ad179e..87b9744d8c 100644\n--- a/examples/vm_power_manager/Makefile\n+++ b/examples/vm_power_manager/Makefile\n@@ -1,65 +1,61 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2010-2014 Intel Corporation\n+# Copyright(c) 2010-2020 Intel Corporation\n \n-ifneq ($(shell pkg-config --atleast-version=0.9.3 libvirt; echo $$?), 0)\n-$(error vm_power_manager requires libvirt >= 0.9.3)\n-else\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n endif\n \n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n # binary name\n APP = vm_power_mgr\n \n # all source are stored in SRCS-y\n SRCS-y := main.c vm_power_cli.c power_manager.c channel_manager.c\n SRCS-y += channel_monitor.c parse.c\n-ifeq ($(CONFIG_RTE_ARCH_X86_64),y)\n+ifeq ($(shell uname -m),x86_64)\n SRCS-y += oob_monitor_x86.c\n else\n SRCS-y += oob_monitor_nop.c\n endif\n \n-CFLAGS += -O3 -I$(RTE_SDK)/lib/librte_power/\n-CFLAGS += $(WERROR_FLAGS)\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n \n-LDLIBS += -lvirt\n+PKGCONF ?= pkg-config\n \n-JANSSON := $(shell pkg-config --exists jansson; echo $$?)\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+ifneq ($(shell $(PKGCONF) --atleast-version=0.9.3 libvirt; echo $$?), 0)\n+$(error vm_power_manager requires libvirt >= 0.9.3)\n+endif\n+LDFLAGS += $(shell $(PKGCONF) --libs libvirt)\n+\n+JANSSON := $(shell $(PKGCONF) --exists jansson; echo $$?)\n ifeq ($(JANSSON), 0)\n-LDLIBS += $(shell pkg-config --libs jansson)\n+LDFLAGS += $(shell $(PKGCONF) --libs jansson)\n CFLAGS += -DUSE_JANSSON\n endif\n \n-ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n+# for shared library builds, we need to explicitly link these PMDs\n+LDFLAGS_SHARED += -lrte_pmd_ixgbe -lrte_pmd_i40e -lrte_pmd_bnxt\n \n-ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)\n-LDLIBS += -lrte_pmd_ixgbe\n-endif\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n \n-ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)\n-LDLIBS += -lrte_pmd_i40e\n-endif\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n \n-ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)\n-LDLIBS += -lrte_pmd_bnxt\n-endif\n+build:\n+\t@mkdir -p $@\n \n-endif\n-\n-# workaround for a gcc bug with noreturn attribute\n-# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603\n-ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)\n-CFLAGS_main.o += -Wno-return-type\n-endif\n-\n-include $(RTE_SDK)/mk/rte.extapp.mk\n-\n-endif # libvirt check\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/vm_power_manager/guest_cli/Makefile b/examples/vm_power_manager/guest_cli/Makefile\nindex 67cf081936..b84deec574 100644\n--- a/examples/vm_power_manager/guest_cli/Makefile\n+++ b/examples/vm_power_manager/guest_cli/Makefile\n@@ -1,14 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2010-2014 Intel Corporation\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n+# Copyright(c) 2010-2020 Intel Corporation\n \n # binary name\n APP = guest_vm_power_mgr\n@@ -16,14 +7,35 @@ APP = guest_vm_power_mgr\n # all source are stored in SRCS-y\n SRCS-y := main.c vm_power_cli_guest.c parse.c\n \n-CFLAGS += -O3 -I$(RTE_SDK)/lib/librte_power/\n-CFLAGS += $(WERROR_FLAGS)\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n-\n-# workaround for a gcc bug with noreturn attribute\n-# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603\n-ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)\n-CFLAGS_main.o += -Wno-return-type\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n endif\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\n", "prefixes": [ "v4", "07/31" ] }