Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76786/?format=api
{ "id": 76786, "url": "http://patches.dpdk.org/api/patches/76786/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200907220711.437405-5-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200907220711.437405-5-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200907220711.437405-5-thomas@monjalon.net", "date": "2020-09-07T22:06:44", "name": "[v4,04/31] examples/server_node_efd: convert to pkg-config-based build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ac267c7ef4917beae1dc1d21802bf4d4badeeef2", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200907220711.437405-5-thomas@monjalon.net/mbox/", "series": [ { "id": 12000, "url": "http://patches.dpdk.org/api/series/12000/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12000", "date": "2020-09-07T22:06:40", "name": "remove make support in DPDK", "version": 4, "mbox": "http://patches.dpdk.org/series/12000/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76786/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76786/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 797C3A04AA;\n\tTue, 8 Sep 2020 00:08:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 343ED1C120;\n\tTue, 8 Sep 2020 00:07:31 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id F30A61C10B\n for <dev@dpdk.org>; Tue, 8 Sep 2020 00:07:25 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id A4B405C0098;\n Mon, 7 Sep 2020 18:07:25 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute7.internal (MEProxy); Mon, 07 Sep 2020 18:07:25 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id C5B523280060;\n Mon, 7 Sep 2020 18:07:24 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=ABgn/ldkvIJWa\n swMNvOqsv69BO3dVZJ60xwnAURaRfg=; b=bXTBEQrLYd9GfxMPDmKmUntyAXykI\n ThUbx0MhAVClfU/86BuigRHKc+v+ag/8m/GGUyRqI34IFnJ8gyUEfwk4M14ih7Ca\n 0kFD4H46SPxaqM+6Zw6pPu2T0RzxcCXCCadDjW+pQlLkuVuh9tgcdv9AFwryzY1u\n UdTHl4+krXxxHPtShzCSjS+nqpKbxHHpz/jSH7R1kjb6BXtPwvEHu/BULg3g0ZiH\n cVOaUT9lOOVO0XEU0RsL0Zq49hdgzeqBYeAijZa069nSZxOzB4hoveAsQYaRNeR3\n o3YFyi8UcE6VyC5nCyB8cIzYx5T3CAoSeOmVE0jvjH4a62vn2SL1QmsuA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=ABgn/ldkvIJWaswMNvOqsv69BO3dVZJ60xwnAURaRfg=; b=T268b80O\n nnKrwUPI/Mwhk2T7IG6tWHtmz8mCNgPegxxohDu5j2VKQb4+DssA73x7maBUi2nC\n pjnNBK+lKHNMAJRx7MQo4z7tksszzOKLhZIk92apNJF0Wf8w/KmRYu4y4eD+i7Yn\n eQapzwuw4E40YI5c0du3+vIZBgG2UHkgJMXSVdjrzaBJHh1lsdSiF8hbrHbOOZwy\n xSmgt7vQ7DPS/PTlARqUzBe+KoaTvGyQNx3n1W2HJxUQ3UnHdSWeUnx+RxWuWpDB\n 1WIaQhomNrFQzEB1kB8HSRzFGcYT349Af/MTDBqIfoNN+EFq6qN+UAto96bdYQNJ\n ym4nD7mukQeOXQ==" ], "X-ME-Sender": "<xms:Ha9WX3d2wqzPKbdFDnYxzrwUaNbAJcGDFOwr5xf_GL4QRWno2kf9Wg>\n <xme:Ha9WX9N25fR8LNZs6RW3JoGCR9EXOIXN0CUdsnXwCi9dGNhJzdhTnAwdZQ58rXIwv\n XOGDgNvpUOBuV6MiA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudehuddgtdefucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepueefgefgtedvkefgvdeuteduheevvdekffeufffghffhueektddt\n jefftedvgfeinecuffhomhgrihhnpehvrghrshdrmhhkpdgvgihtshhusgguihhrrdhmkh\n dpvgigthgrphhprdhmkhenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhs\n thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmoh\n hnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:Ha9WXwiCWepJ_Rrc2O-_rbkbdX5IIhG8HkVdVn97GgLEnRhANCzy0w>\n <xmx:Ha9WX4_5MkcRuyvTW_HnNz_sUZQop9V_gRLImmNmiAvhbZq7TyPXog>\n <xmx:Ha9WXzuAAmvEq-dc4Nb_ETtMrTafldJXGf5lDcfbQ-75ibXBv4_VDg>\n <xmx:Ha9WX845SUMZsHBHKJU0nZXHFV1dlINQMSKibau5rPvVb_s-bSusOw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, bruce.richardson@intel.com,\n ciara.power@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Tue, 8 Sep 2020 00:06:44 +0200", "Message-Id": "<20200907220711.437405-5-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200907220711.437405-1-thomas@monjalon.net>", "References": "<20200903152717.42095-1-ciara.power@intel.com>\n <20200907220711.437405-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 04/31] examples/server_node_efd: convert to\n\tpkg-config-based build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kevin Laatz <kevin.laatz@intel.com>\n\nRemove references to the old make build system and use pkg-config for\nbuilding these examples.\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n examples/server_node_efd/Makefile | 18 +++-----\n examples/server_node_efd/node/Makefile | 46 ++++++++++++++------\n examples/server_node_efd/server/Makefile | 53 +++++++++++++++---------\n 3 files changed, 73 insertions(+), 44 deletions(-)", "diff": "diff --git a/examples/server_node_efd/Makefile b/examples/server_node_efd/Makefile\nindex cc2ea8b566..e4a4a94a79 100644\n--- a/examples/server_node_efd/Makefile\n+++ b/examples/server_node_efd/Makefile\n@@ -1,16 +1,10 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2016-2017 Intel Corporation\n+# Copyright(c) 2016-2020 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n+subdirs := node server\n \n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n+.PHONY: all static shared clean $(subdirs)\n+all static shared clean: $(subdirs)\n \n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += server\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += node\n-\n-include $(RTE_SDK)/mk/rte.extsubdir.mk\n+$(subdirs):\n+\t$(MAKE) -C $@ $(MAKECMDGOALS)\ndiff --git a/examples/server_node_efd/node/Makefile b/examples/server_node_efd/node/Makefile\nindex ecc551e1d6..a4efef42dc 100644\n--- a/examples/server_node_efd/node/Makefile\n+++ b/examples/server_node_efd/node/Makefile\n@@ -1,12 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2016-2017 Intel Corporation\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, can be overridden by command line or environment\n-include $(RTE_SDK)/mk/rte.vars.mk\n+# Copyright(c) 2016-2020 Intel Corporation\n \n # binary name\n APP = node\n@@ -14,8 +7,37 @@ APP = node\n # all source are stored in SRCS-y\n SRCS-y := node.c\n \n-CFLAGS += $(WERROR_FLAGS) -O3\n-CFLAGS += -I$(SRCDIR)/../shared\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+CFLAGS += -I../shared\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/server_node_efd/server/Makefile b/examples/server_node_efd/server/Makefile\nindex acbd12ae23..106e1abd74 100644\n--- a/examples/server_node_efd/server/Makefile\n+++ b/examples/server_node_efd/server/Makefile\n@@ -1,19 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2016-2017 Intel Corporation\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n-ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)\n-$(error This application can only operate in a linux environment, \\\n-please change the definition of the RTE_TARGET environment variable)\n-endif\n+# Copyright(c) 2016-2020 Intel Corporation\n \n # binary name\n APP = server\n@@ -21,10 +7,37 @@ APP = server\n # all source are stored in SRCS-y\n SRCS-y := main.c init.c args.c\n \n-INC := $(sort $(wildcard *.h))\n+CFLAGS += -I../shared\n \n-CFLAGS += $(WERROR_FLAGS) -O3\n-CFLAGS += -I$(SRCDIR)/../shared\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\n", "prefixes": [ "v4", "04/31" ] }