Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76667/?format=api
{ "id": 76667, "url": "http://patches.dpdk.org/api/patches/76667/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200907091711.5980-6-junyux.jiang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200907091711.5980-6-junyux.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200907091711.5980-6-junyux.jiang@intel.com", "date": "2020-09-07T09:17:11", "name": "[v2,5/5] net/ice: remove devargs flow-mark-support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6642a325edac5ec051151976fb8f6150eef4cb28", "submitter": { "id": 1408, "url": "http://patches.dpdk.org/api/people/1408/?format=api", "name": "Junyu Jiang", "email": "junyux.jiang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200907091711.5980-6-junyux.jiang@intel.com/mbox/", "series": [ { "id": 11987, "url": "http://patches.dpdk.org/api/series/11987/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11987", "date": "2020-09-07T09:17:06", "name": "supports RxDID #22 and FDID", "version": 2, "mbox": "http://patches.dpdk.org/series/11987/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76667/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76667/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 784ADA04B9;\n\tMon, 7 Sep 2020 11:27:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 869151C121;\n\tMon, 7 Sep 2020 11:26:45 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 20E451C11A\n for <dev@dpdk.org>; Mon, 7 Sep 2020 11:26:42 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Sep 2020 02:26:42 -0700", "from unknown (HELO intel.sh.intel.com) ([10.239.255.60])\n by fmsmga001.fm.intel.com with ESMTP; 07 Sep 2020 02:26:41 -0700" ], "IronPort-SDR": [ "\n Jsn44Empko4MyMKKganiyh0VmgF52zj2WN7W7yG5dVqaDGvbptO3MyBTUxer9OKtwt1C6fh+yA\n 4wSgsle2FEOQ==", "\n DZe0KYAe+fpe9uKuxSPRnVkfzUtlVBCT0iWsnBLWfDXcgirMKXQKlztfgxVzN4jg28tyxdHdvK\n CE1FjtfxJPHA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9736\"; a=\"157241163\"", "E=Sophos;i=\"5.76,401,1592895600\"; d=\"scan'208\";a=\"157241163\"", "E=Sophos;i=\"5.76,401,1592895600\"; d=\"scan'208\";a=\"406783337\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Junyu Jiang <junyux.jiang@intel.com>", "To": "dev@dpdk.org", "Cc": "Qi Zhang <qi.z.zhang@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>", "Date": "Mon, 7 Sep 2020 09:17:11 +0000", "Message-Id": "<20200907091711.5980-6-junyux.jiang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200907091711.5980-1-junyux.jiang@intel.com>", "References": "<20200826075501.50052-1-guinanx.sun@intel.com>\n <20200907091711.5980-1-junyux.jiang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 5/5] net/ice: remove devargs flow-mark-support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Guinan Sun <guinanx.sun@intel.com>\n\nRemove devargs \"flow-mark-support\".\n\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n doc/guides/nics/ice.rst | 12 ------------\n drivers/net/ice/ice_ethdev.c | 10 +---------\n drivers/net/ice/ice_ethdev.h | 1 -\n drivers/net/ice/ice_rxtx_vec_common.h | 6 ------\n 4 files changed, 1 insertion(+), 28 deletions(-)", "diff": "diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst\nindex 9a9f4a6bb..64b1b13a6 100644\n--- a/doc/guides/nics/ice.rst\n+++ b/doc/guides/nics/ice.rst\n@@ -75,18 +75,6 @@ Runtime Config Options\n \n -w 80:00.0,pipeline-mode-support=1\n \n-- ``Flow Mark Support`` (default ``0``)\n-\n- This is a hint to the driver to select the data path that supports flow mark extraction\n- by default.\n- NOTE: This is an experimental devarg, it will be removed when any of below conditions\n- is ready.\n- 1) all data paths support flow mark (currently vPMD does not)\n- 2) a new offload like RTE_DEV_RX_OFFLOAD_FLOW_MARK be introduced as a standard way to hint.\n- Example::\n-\n- -w 80:00.0,flow-mark-support=1\n-\n - ``Protocol extraction for per queue``\n \n Configure the RX queues to do protocol extraction into mbuf for protocol\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 8d435e889..cb6882f70 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -23,13 +23,11 @@\n /* devargs */\n #define ICE_SAFE_MODE_SUPPORT_ARG \"safe-mode-support\"\n #define ICE_PIPELINE_MODE_SUPPORT_ARG \"pipeline-mode-support\"\n-#define ICE_FLOW_MARK_SUPPORT_ARG\t\"flow-mark-support\"\n #define ICE_PROTO_XTR_ARG \"proto_xtr\"\n \n static const char * const ice_valid_args[] = {\n \tICE_SAFE_MODE_SUPPORT_ARG,\n \tICE_PIPELINE_MODE_SUPPORT_ARG,\n-\tICE_FLOW_MARK_SUPPORT_ARG,\n \tICE_PROTO_XTR_ARG,\n \tNULL\n };\n@@ -1985,11 +1983,6 @@ static int ice_parse_devargs(struct rte_eth_dev *dev)\n \tif (ret)\n \t\tgoto bail;\n \n-\tret = rte_kvargs_process(kvlist, ICE_FLOW_MARK_SUPPORT_ARG,\n-\t\t\t\t &parse_bool, &ad->devargs.flow_mark_support);\n-\tif (ret)\n-\t\tgoto bail;\n-\n bail:\n \trte_kvargs_free(kvlist);\n \treturn ret;\n@@ -5131,8 +5124,7 @@ RTE_PMD_REGISTER_KMOD_DEP(net_ice, \"* igb_uio | uio_pci_generic | vfio-pci\");\n RTE_PMD_REGISTER_PARAM_STRING(net_ice,\n \t\t\t ICE_PROTO_XTR_ARG \"=[queue:]<vlan|ipv4|ipv6|ipv6_flow|tcp>\"\n \t\t\t ICE_SAFE_MODE_SUPPORT_ARG \"=<0|1>\"\n-\t\t\t ICE_PIPELINE_MODE_SUPPORT_ARG \"=<0|1>\"\n-\t\t\t ICE_FLOW_MARK_SUPPORT_ARG \"=<0|1>\");\n+\t\t\t ICE_PIPELINE_MODE_SUPPORT_ARG \"=<0|1>\");\n \n RTE_LOG_REGISTER(ice_logtype_init, pmd.net.ice.init, NOTICE);\n RTE_LOG_REGISTER(ice_logtype_driver, pmd.net.ice.driver, NOTICE);\ndiff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h\nindex df0d65d8d..d441350e0 100644\n--- a/drivers/net/ice/ice_ethdev.h\n+++ b/drivers/net/ice/ice_ethdev.h\n@@ -444,7 +444,6 @@ struct ice_devargs {\n \tint safe_mode_support;\n \tuint8_t proto_xtr_dflt;\n \tint pipe_mode_support;\n-\tint flow_mark_support;\n \tuint8_t proto_xtr[ICE_MAX_QUEUE_NUM];\n };\n \ndiff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h\nindex 46e3be98a..e2019c8d6 100644\n--- a/drivers/net/ice/ice_rxtx_vec_common.h\n+++ b/drivers/net/ice/ice_rxtx_vec_common.h\n@@ -270,12 +270,6 @@ ice_rx_vec_dev_check_default(struct rte_eth_dev *dev)\n {\n \tint i;\n \tstruct ice_rx_queue *rxq;\n-\tstruct ice_adapter *ad =\n-\t\tICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n-\n-\t/* vPMD does not support flow mark. */\n-\tif (ad->devargs.flow_mark_support)\n-\t\treturn -1;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\trxq = dev->data->rx_queues[i];\n", "prefixes": [ "v2", "5/5" ] }