Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76618/?format=api
{ "id": 76618, "url": "http://patches.dpdk.org/api/patches/76618/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200906013133.26360-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200906013133.26360-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200906013133.26360-6-stephen@networkplumber.org", "date": "2020-09-06T01:31:27", "name": "[05/11] dpdk-pmdinfo: remove unnecessary paren and else", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8cbf98426fad3f4a45b11deb3053b7c72d8926b0", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200906013133.26360-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 11970, "url": "http://patches.dpdk.org/api/series/11970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11970", "date": "2020-09-06T01:31:22", "name": "Python script updates", "version": 1, "mbox": "http://patches.dpdk.org/series/11970/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76618/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76618/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D10DA04C5;\n\tSun, 6 Sep 2020 03:32:34 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CDBB91C119;\n\tSun, 6 Sep 2020 03:31:51 +0200 (CEST)", "from mail-pf1-f170.google.com (mail-pf1-f170.google.com\n [209.85.210.170]) by dpdk.org (Postfix) with ESMTP id 2D8CF1C0DB\n for <dev@dpdk.org>; Sun, 6 Sep 2020 03:31:48 +0200 (CEST)", "by mail-pf1-f170.google.com with SMTP id b124so6678796pfg.13\n for <dev@dpdk.org>; Sat, 05 Sep 2020 18:31:48 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id n127sm10731863pfn.155.2020.09.05.18.31.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 05 Sep 2020 18:31:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Cwmla8CMmFUdBdPAiemA09ybJYnR4MMF1AiTpy6Z9V0=;\n b=RZ34p0P68xOatkMMCjQvO0yLcC7LEyM5qkp+WS/8cUa77NL7adCCURKKKcAPqANxe9\n mMPlwT1En1Cp7Y8fhMgyN4PSb+vM9yxLUJYvhmw9oAXYRk1tUxvkGyrj27i50AF7NYy5\n SAnJ7Hnip6CQeguNXEScFxF9rFkcz0mYuaGsZvpykmf68wP5qEq/CDIx6waT9/4O6kKq\n Ceq6cvdXjS/6mhLuRcUNYqMcpd6cgRYx4gprLcUpWWWzZxN83rLHyQyO+nu2Td2Gc30w\n ZYC5lnvgKDgzZF2KwurLIExsvM+JlEwD0X3rIFSvqMC55F7yJRBAQ8ZP6ZESL0DFE1Bs\n YrAg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Cwmla8CMmFUdBdPAiemA09ybJYnR4MMF1AiTpy6Z9V0=;\n b=AjAocUJOkjen9mP1lw8a9qi9L0r79m1ffiHvgu5ij1QE3qFKHk7fKS/wNI18kDgEHv\n qhIIF3vMieyy/VjmRp22eJmJz4bLaB0G8LCwdlEchyVjkTwmgd32nmmBXhXA8OSowPRR\n A0XLL4IAcfSOgpAPo47mQyOcXmVBMc1+vbglAptdTOGDWvDQn+9IjZKRYhl4ChBvq7js\n 0jJGB0LFbp9++9xFUl9wzTA6f8vOYyROB35ow1r0oYYPQx8c/fDbP0d2L0WfGsfhJC/6\n 38suqJOUGCmHeXjKJO4O9fAgd68qK6r7oyT6N+ojeFweInGtDl6/Dz3O7WOm3BqiJVTc\n eVIw==", "X-Gm-Message-State": "AOAM53349aXfOEv+2MOW8YiyCJDbQI8nZnKKueey4bf2RGykyV7Ir2H2\n CiXOyHT/+3UUMAQDMVrt8J+b/PkCMZvANQ==", "X-Google-Smtp-Source": "\n ABdhPJy6aP4AE9YX19wNmunpay1EmvD2MqXR81OP8Dvlna+tkmlsNHWVzFDtwX8Y1GsJXyJqmA+BnQ==", "X-Received": "by 2002:a63:6dc7:: with SMTP id\n i190mr11860454pgc.27.1599355906877;\n Sat, 05 Sep 2020 18:31:46 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Sat, 5 Sep 2020 18:31:27 -0700", "Message-Id": "<20200906013133.26360-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200906013133.26360-1-stephen@networkplumber.org>", "References": "<20200906013133.26360-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 05/11] dpdk-pmdinfo: remove unnecessary paren and\n\telse", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Python lint complains:\nusertools/dpdk-pmdinfo.py:303:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:328:0: C0325: Unnecessary parens after 'not' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:341:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:394:0: C0325: Unnecessary parens after 'not' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:407:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:515:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:530:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:533:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:534:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:539:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:594:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:602:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:605:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:611:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)\nusertools/dpdk-pmdinfo.py:110:12: R1705: Unnecessary \"else\" after \"return\" (no-else-return)\nusertools/dpdk-pmdinfo.py:254:12: R1705: Unnecessary \"else\" after \"return\" (no-else-return)\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n usertools/dpdk-pmdinfo.py | 34 ++++++++++++++++------------------\n 1 file changed, 16 insertions(+), 18 deletions(-)", "diff": "diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py\nindex 9ee8fe9fa1ec..32f8a82519fb 100755\n--- a/usertools/dpdk-pmdinfo.py\n+++ b/usertools/dpdk-pmdinfo.py\n@@ -109,8 +109,7 @@ def find_subid(self, subven, subdev):\n except:\n if (subven == \"ffff\" and subdev == \"ffff\"):\n return SubDevice(\"ffff\", \"ffff\", \"(All Subdevices)\")\n- else:\n- return SubDevice(subven, subdev, \"(Unknown Subdevice)\")\n+ return SubDevice(subven, subdev, \"(Unknown Subdevice)\")\n \n \n class SubDevice:\n@@ -253,8 +252,7 @@ def _section_from_spec(self, spec):\n num = int(spec)\n if num < self.elffile.num_sections():\n return self.elffile.get_section(num)\n- else:\n- return None\n+ return None\n except ValueError:\n # Not a number. Must be a name then\n section = self.elffile.get_section_by_name(force_unicode(spec))\n@@ -300,7 +298,7 @@ def parse_pmd_info_string(self, mystring):\n except KeyError:\n continue\n \n- if (len(pmdinfo[\"pci_ids\"]) != 0):\n+ if len(pmdinfo[\"pci_ids\"]) != 0:\n print(\"PMD HW SUPPORT:\")\n if pcidb is not None:\n self.pretty_print_pmdinfo(pmdinfo)\n@@ -325,7 +323,7 @@ def display_pmd_info_strings(self, section_spec):\n \n while dataptr < len(data):\n while (dataptr < len(data) and\n- not (32 <= byte2int(data[dataptr]) <= 127)):\n+ not 32 <= byte2int(data[dataptr]) <= 127):\n dataptr += 1\n \n if dataptr >= len(data):\n@@ -338,7 +336,7 @@ def display_pmd_info_strings(self, section_spec):\n # pyelftools may return byte-strings, force decode them\n mystring = force_unicode(data[dataptr:endptr])\n rc = mystring.find(\"PMD_INFO_STRING\")\n- if (rc != -1):\n+ if rc != -1:\n self.parse_pmd_info_string(mystring)\n \n dataptr = endptr\n@@ -391,7 +389,7 @@ def search_for_autoload_path(self):\n \n while dataptr < len(data):\n while (dataptr < len(data) and\n- not (32 <= byte2int(data[dataptr]) <= 127)):\n+ not 32 <= byte2int(data[dataptr]) <= 127):\n dataptr += 1\n \n if dataptr >= len(data):\n@@ -404,7 +402,7 @@ def search_for_autoload_path(self):\n # pyelftools may return byte-strings, force decode them\n mystring = force_unicode(data[dataptr:endptr])\n rc = mystring.find(\"DPDK_PLUGIN_PATH\")\n- if (rc != -1):\n+ if rc != -1:\n rc = mystring.find(\"=\")\n return (mystring[rc + 1:], library)\n \n@@ -512,7 +510,7 @@ def scan_for_autoload_pmds(dpdk_path):\n \"\"\"\n global raw_output\n \n- if (os.path.isfile(dpdk_path) is False):\n+ if os.path.isfile(dpdk_path) is False:\n if raw_output is False:\n print(\"Must specify a file name\")\n return\n@@ -527,16 +525,16 @@ def scan_for_autoload_pmds(dpdk_path):\n \n (autoload_path, scannedfile) = readelf.search_for_autoload_path()\n if not autoload_path:\n- if (raw_output is False):\n+ if raw_output is False:\n print(\"No autoload path configured in %s\" % dpdk_path)\n return\n- if (raw_output is False):\n- if (scannedfile is None):\n+ if raw_output is False:\n+ if scannedfile is None:\n scannedfile = dpdk_path\n print(\"Found autoload path %s in %s\" % (autoload_path, scannedfile))\n \n file.close()\n- if (raw_output is False):\n+ if raw_output is False:\n print(\"Discovered Autoload HW Support:\")\n scan_autoload_path(autoload_path)\n return\n@@ -591,7 +589,7 @@ def main(stream=None):\n options.pcifile = None\n pcidb = None\n \n- if (len(args) == 0):\n+ if len(args) == 0:\n optparser.print_usage()\n exit(1)\n \n@@ -599,16 +597,16 @@ def main(stream=None):\n exit(scan_for_autoload_pmds(args[0]))\n \n ldlibpath = os.environ.get('LD_LIBRARY_PATH')\n- if (ldlibpath is None):\n+ if ldlibpath is None:\n ldlibpath = \"\"\n \n- if (os.path.exists(args[0]) is True):\n+ if os.path.exists(args[0]) is True:\n myelffile = args[0]\n else:\n myelffile = search_file(\n args[0], ldlibpath + \":/usr/lib64:/lib64:/usr/lib:/lib\")\n \n- if (myelffile is None):\n+ if myelffile is None:\n print(\"File not found\")\n sys.exit(1)\n \n", "prefixes": [ "05/11" ] }