Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76463/?format=api
{ "id": 76463, "url": "http://patches.dpdk.org/api/patches/76463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200903163308.4759-1-akhil.goyal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200903163308.4759-1-akhil.goyal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200903163308.4759-1-akhil.goyal@nxp.com", "date": "2020-09-03T16:33:07", "name": "[1/2] crypto/dpaa2_sec: support DES-CBC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c18030523addc3654606a2f66b5bc7e7f7124ca8", "submitter": { "id": 517, "url": "http://patches.dpdk.org/api/people/517/?format=api", "name": "Akhil Goyal", "email": "akhil.goyal@nxp.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200903163308.4759-1-akhil.goyal@nxp.com/mbox/", "series": [ { "id": 11932, "url": "http://patches.dpdk.org/api/series/11932/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11932", "date": "2020-09-03T16:33:07", "name": "[1/2] crypto/dpaa2_sec: support DES-CBC", "version": 1, "mbox": "http://patches.dpdk.org/series/11932/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76463/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76463/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D945A04BF;\n\tThu, 3 Sep 2020 18:33:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E01A91C0D8;\n\tThu, 3 Sep 2020 18:33:18 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id F22DE1C0D5\n for <dev@dpdk.org>; Thu, 3 Sep 2020 18:33:16 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id CF74B20161E;\n Thu, 3 Sep 2020 18:33:16 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 0B30E200FA1;\n Thu, 3 Sep 2020 18:33:15 +0200 (CEST)", "from lsv03273.swis.in-blr01.nxp.com (lsv03273.swis.in-blr01.nxp.com\n [92.120.147.113])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 841874031B;\n Thu, 3 Sep 2020 18:33:10 +0200 (CEST)" ], "From": "akhil.goyal@nxp.com", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <akhil.goyal@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Thu, 3 Sep 2020 22:03:07 +0530", "Message-Id": "<20200903163308.4759-1-akhil.goyal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 1/2] crypto/dpaa2_sec: support DES-CBC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Akhil Goyal <akhil.goyal@nxp.com>\n\nadd DES-CBC support for cipher_only, chain and ipsec protocol.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\nSigned-off-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n doc/guides/cryptodevs/features/dpaa2_sec.ini | 3 ++-\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 26 ++++++++++++++------\n drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 22 ++++++++++++++++-\n 3 files changed, 42 insertions(+), 9 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/features/dpaa2_sec.ini b/doc/guides/cryptodevs/features/dpaa2_sec.ini\nindex 3a88828b8..c31321d5d 100644\n--- a/doc/guides/cryptodevs/features/dpaa2_sec.ini\n+++ b/doc/guides/cryptodevs/features/dpaa2_sec.ini\n@@ -24,6 +24,7 @@ AES CBC (256) = Y\n AES CTR (128) = Y\n AES CTR (192) = Y\n AES CTR (256) = Y\n+DES CBC = Y\n 3DES CBC = Y\n SNOW3G UEA2 = Y\n ZUC EEA3 = Y\n@@ -52,4 +53,4 @@ AES GCM (256) = Y\n ;\n ; Supported Asymmetric algorithms of the 'dpaa2_sec' crypto driver.\n ;\n-[Asymmetric]\n\\ No newline at end of file\n+[Asymmetric]\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 6aa2a36f3..69040ec6c 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -1879,19 +1879,19 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,\n \t\t\t\t\t\tsession->iv.length,\n \t\t\t\t\t\tsession->dir);\n \t\tbreak;\n-\tcase RTE_CRYPTO_CIPHER_AES_CTR:\n-\t\tcipherdata.algtype = OP_ALG_ALGSEL_AES;\n-\t\tcipherdata.algmode = OP_ALG_AAI_CTR;\n-\t\tsession->cipher_alg = RTE_CRYPTO_CIPHER_AES_CTR;\n+\tcase RTE_CRYPTO_CIPHER_DES_CBC:\n+\t\tcipherdata.algtype = OP_ALG_ALGSEL_DES;\n+\t\tcipherdata.algmode = OP_ALG_AAI_CBC;\n+\t\tsession->cipher_alg = RTE_CRYPTO_CIPHER_DES_CBC;\n \t\tbufsize = cnstr_shdsc_blkcipher(priv->flc_desc[0].desc, 1, 0,\n \t\t\t\t\t\tSHR_NEVER, &cipherdata,\n \t\t\t\t\t\tsession->iv.length,\n \t\t\t\t\t\tsession->dir);\n \t\tbreak;\n-\tcase RTE_CRYPTO_CIPHER_3DES_CTR:\n-\t\tcipherdata.algtype = OP_ALG_ALGSEL_3DES;\n+\tcase RTE_CRYPTO_CIPHER_AES_CTR:\n+\t\tcipherdata.algtype = OP_ALG_ALGSEL_AES;\n \t\tcipherdata.algmode = OP_ALG_AAI_CTR;\n-\t\tsession->cipher_alg = RTE_CRYPTO_CIPHER_3DES_CTR;\n+\t\tsession->cipher_alg = RTE_CRYPTO_CIPHER_AES_CTR;\n \t\tbufsize = cnstr_shdsc_blkcipher(priv->flc_desc[0].desc, 1, 0,\n \t\t\t\t\t\tSHR_NEVER, &cipherdata,\n \t\t\t\t\t\tsession->iv.length,\n@@ -1915,6 +1915,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,\n \tcase RTE_CRYPTO_CIPHER_AES_F8:\n \tcase RTE_CRYPTO_CIPHER_AES_ECB:\n \tcase RTE_CRYPTO_CIPHER_3DES_ECB:\n+\tcase RTE_CRYPTO_CIPHER_3DES_CTR:\n \tcase RTE_CRYPTO_CIPHER_AES_XTS:\n \tcase RTE_CRYPTO_CIPHER_ARC4:\n \tcase RTE_CRYPTO_CIPHER_NULL:\n@@ -2392,6 +2393,11 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,\n \t\tcipherdata.algmode = OP_ALG_AAI_CBC;\n \t\tsession->cipher_alg = RTE_CRYPTO_CIPHER_3DES_CBC;\n \t\tbreak;\n+\tcase RTE_CRYPTO_CIPHER_DES_CBC:\n+\t\tcipherdata.algtype = OP_ALG_ALGSEL_DES;\n+\t\tcipherdata.algmode = OP_ALG_AAI_CBC;\n+\t\tsession->cipher_alg = RTE_CRYPTO_CIPHER_DES_CBC;\n+\t\tbreak;\n \tcase RTE_CRYPTO_CIPHER_AES_CTR:\n \t\tcipherdata.algtype = OP_ALG_ALGSEL_AES;\n \t\tcipherdata.algmode = OP_ALG_AAI_CTR;\n@@ -2401,6 +2407,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,\n \tcase RTE_CRYPTO_CIPHER_ZUC_EEA3:\n \tcase RTE_CRYPTO_CIPHER_NULL:\n \tcase RTE_CRYPTO_CIPHER_3DES_ECB:\n+\tcase RTE_CRYPTO_CIPHER_3DES_CTR:\n \tcase RTE_CRYPTO_CIPHER_AES_ECB:\n \tcase RTE_CRYPTO_CIPHER_KASUMI_F8:\n \t\tDPAA2_SEC_ERR(\"Crypto: Unsupported Cipher alg %u\",\n@@ -2732,6 +2739,10 @@ dpaa2_sec_ipsec_proto_init(struct rte_crypto_cipher_xform *cipher_xform,\n \t\tcipherdata->algtype = OP_PCL_IPSEC_3DES;\n \t\tcipherdata->algmode = OP_ALG_AAI_CBC;\n \t\tbreak;\n+\tcase RTE_CRYPTO_CIPHER_DES_CBC:\n+\t\tcipherdata->algtype = OP_PCL_IPSEC_DES;\n+\t\tcipherdata->algmode = OP_ALG_AAI_CBC;\n+\t\tbreak;\n \tcase RTE_CRYPTO_CIPHER_AES_CTR:\n \t\tcipherdata->algtype = OP_PCL_IPSEC_AES_CTR;\n \t\tcipherdata->algmode = OP_ALG_AAI_CTR;\n@@ -2742,6 +2753,7 @@ dpaa2_sec_ipsec_proto_init(struct rte_crypto_cipher_xform *cipher_xform,\n \tcase RTE_CRYPTO_CIPHER_SNOW3G_UEA2:\n \tcase RTE_CRYPTO_CIPHER_ZUC_EEA3:\n \tcase RTE_CRYPTO_CIPHER_3DES_ECB:\n+\tcase RTE_CRYPTO_CIPHER_3DES_CTR:\n \tcase RTE_CRYPTO_CIPHER_AES_ECB:\n \tcase RTE_CRYPTO_CIPHER_KASUMI_F8:\n \t\tDPAA2_SEC_ERR(\"Crypto: Unsupported Cipher alg %u\",\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h\nindex 528b64ef8..c1f95f280 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2016 NXP\n+ * Copyright 2016,2020 NXP\n *\n */\n \n@@ -437,6 +437,26 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {\n \t\t\t}, }\n \t\t}, }\n \t},\n+\t{\t/* DES CBC */\n+\t\t.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,\n+\t\t{.sym = {\n+\t\t\t.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,\n+\t\t\t{.cipher = {\n+\t\t\t\t.algo = RTE_CRYPTO_CIPHER_DES_CBC,\n+\t\t\t\t.block_size = 8,\n+\t\t\t\t.key_size = {\n+\t\t\t\t\t.min = 8,\n+\t\t\t\t\t.max = 8,\n+\t\t\t\t\t.increment = 0\n+\t\t\t\t},\n+\t\t\t\t.iv_size = {\n+\t\t\t\t\t.min = 8,\n+\t\t\t\t\t.max = 8,\n+\t\t\t\t\t.increment = 0\n+\t\t\t\t}\n+\t\t\t}, }\n+\t\t}, }\n+\t},\n \t{\t/* 3DES CBC */\n \t\t.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,\n \t\t{.sym = {\n", "prefixes": [ "1/2" ] }