Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76419/?format=api
{ "id": 76419, "url": "http://patches.dpdk.org/api/patches/76419/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-9-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200903152717.42095-9-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200903152717.42095-9-ciara.power@intel.com", "date": "2020-09-03T15:26:48", "name": "[v3,08/37] examples/ethtool: convert to pkg-config-based build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4992c8c9315e4e5cf8a63db5d16066278ebaad9f", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-9-ciara.power@intel.com/mbox/", "series": [ { "id": 11929, "url": "http://patches.dpdk.org/api/series/11929/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11929", "date": "2020-09-03T15:26:40", "name": "remove make support in DPDK", "version": 3, "mbox": "http://patches.dpdk.org/series/11929/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76419/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76419/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8EBAA04BF;\n\tThu, 3 Sep 2020 17:29:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 438E21C125;\n\tThu, 3 Sep 2020 17:28:07 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 209B71C11F\n for <dev@dpdk.org>; Thu, 3 Sep 2020 17:28:04 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Sep 2020 08:28:04 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga006.jf.intel.com with ESMTP; 03 Sep 2020 08:28:02 -0700" ], "IronPort-SDR": [ "\n uJC6zmiaZG8/2TR6s+Sf3R5U4bvs7NWkpO3YOPlHrDVwHIaXo2nNnKT6GccIccglHnF+JZjMKg\n lD8yHPT8pVcQ==", "\n UojwbU8djI9CygkL1p3L0/+mx4WDOrhhD8OaY+CIWDTpNfKIMlVkcUeWWSiGzSBUROCxNq2P98\n gC7oybsCXTZw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9733\"; a=\"145332159\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"145332159\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"302243776\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>,\n Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,\n Tomasz Kantecki <tomasz.kantecki@intel.com>,\n Sunil Kumar Kori <skori@marvell.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>", "Date": "Thu, 3 Sep 2020 16:26:48 +0100", "Message-Id": "<20200903152717.42095-9-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200903152717.42095-1-ciara.power@intel.com>", "References": "<20200807123009.21266-1-ciara.power@intel.com>\n <20200903152717.42095-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 08/37] examples/ethtool: convert to\n\tpkg-config-based build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nRemove references to the old DPDK build system from the makefiles, and use\npkg-config provided flags instead.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/ethtool/Makefile | 26 +++--------\n examples/ethtool/ethtool-app/Makefile | 56 +++++++++++++++---------\n examples/ethtool/lib/Makefile | 62 ++++++++++++++++-----------\n 3 files changed, 79 insertions(+), 65 deletions(-)", "diff": "diff --git a/examples/ethtool/Makefile b/examples/ethtool/Makefile\nindex d3b97bb50b..a1a80c44e6 100644\n--- a/examples/ethtool/Makefile\n+++ b/examples/ethtool/Makefile\n@@ -1,23 +1,11 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2015 Intel Corporation\n+# Copyright(c) 2015-2020 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n+subdirs := lib ethtool-app\n \n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n+.PHONY: all static shared clean $(subdirs)\n+all static shared clean: $(subdirs)\n \n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n-ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)\n-$(info This application can only operate in a linux environment, \\\n-please change the definition of the RTE_TARGET environment variable)\n-else\n-\n-DIRS-y += lib ethtool-app\n-endif\n-\n-DEPDIRS-ethtool-app := lib\n-\n-include $(RTE_SDK)/mk/rte.extsubdir.mk\n+ethtool-app: lib\n+$(subdirs):\n+\t$(MAKE) -C $@ $(MAKECMDGOALS)\ndiff --git a/examples/ethtool/ethtool-app/Makefile b/examples/ethtool/ethtool-app/Makefile\nindex 20ac0d3240..5ebeb200a8 100644\n--- a/examples/ethtool/ethtool-app/Makefile\n+++ b/examples/ethtool/ethtool-app/Makefile\n@@ -1,14 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2010-2014 Intel Corporation\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n+# Copyright(c) 2010-2020 Intel Corporation\n \n # binary name\n APP = ethtool\n@@ -16,17 +7,40 @@ APP = ethtool\n # all source are stored in SRCS-y\n SRCS-y := main.c ethapp.c\n \n-CFLAGS += -O3 -pthread -I$(SRCDIR)/../lib\n-CFLAGS += $(WERROR_FLAGS)\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n-\n-LDLIBS += -L$(subst ethtool-app,lib,$(RTE_OUTPUT))/lib\n-LDLIBS += -lrte_ethtool\n+CFLAGS += -I../lib\n+LDFLAGS += -L../lib/build\n+LDFLAGS_STATIC = -l:librte_ethtool.a\n+LDFLAGS_SHARED = -lrte_ethtool\n \n-ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n-ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)\n-LDLIBS += -lrte_pmd_ixgbe\n-endif\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n endif\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED += $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC += $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/ethtool/lib/Makefile b/examples/ethtool/lib/Makefile\nindex 6494741270..3bc2b9d8ba 100644\n--- a/examples/ethtool/lib/Makefile\n+++ b/examples/ethtool/lib/Makefile\n@@ -1,37 +1,49 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2015 Intel Corporation\n+# Copyright(c) 2015-2020 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n \n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n-ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)\n-$(error This application can only operate in a linux environment, \\\n-please change the definition of the RTE_TARGET environment variable)\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+ifneq ($(shell uname),Linux)\n+$(error This application can only operate in a linux environment)\n endif\n \n-# library name\n-LIB = librte_ethtool.a\n-\n-LIBABIVER := 0.1\n+PKGCONF ?= pkg-config\n \n-# all source are stored in SRC-Y\n-SRCS-y := rte_ethtool.c\n+# library name\n+LIB = librte_ethtool.so\n+LIB_STATIC = librte_ethtool.a\n+SRCS = rte_ethtool.c\n \n CFLAGS += -O3\n-CFLAGS += $(WERROR_FLAGS)\n+CFLAGS += -fPIC\n CFLAGS += -DALLOW_EXPERIMENTAL_API\n \n-ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n-ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)\n-LDLIBS += -lrte_pmd_ixgbe\n-endif\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS += -Wl,--no-undefined $(LDFLAGS_SHARED)\n+\n+# check for ixgbe by grepping pre-processor output\n+ifneq ($(shell $(CC) $(CFLAGS) -dM -E - < /dev/null | grep IXGBE),)\n+LDFLAGS += -lrte_pmd_ixgbe\n endif\n-LDLIBS += -lrte_eal -lrte_ethdev\n \n-include $(RTE_SDK)/mk/rte.extlib.mk\n+.PHONY: all clean static shared\n+all shared: build/$(LIB)\n+static: build/$(LIB_STATIC)\n+\n+clean:\n+\trm -f build/$(LIB)\n+\ttest -d build && rmdir -p build || true\n+\n+build:\n+\t@mkdir -p $@\n+\n+build/%.so: $(SRCS) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) -o $@ -shared $(SRCS) $(LDFLAGS)\n+\n+build/%.a: $(SRCS) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) -c $(SRCS) -o build/$(SRCS).o\n+\t$(AR) -cr $@ build/*.o\n", "prefixes": [ "v3", "08/37" ] }