Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76417/?format=api
{ "id": 76417, "url": "http://patches.dpdk.org/api/patches/76417/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-7-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200903152717.42095-7-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200903152717.42095-7-ciara.power@intel.com", "date": "2020-09-03T15:26:46", "name": "[v3,06/37] examples/vm_power_manager: convert to use DPDK pkg-config", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "230ceeae9225427ba158cbb170a46a47745a8a5d", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-7-ciara.power@intel.com/mbox/", "series": [ { "id": 11929, "url": "http://patches.dpdk.org/api/series/11929/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11929", "date": "2020-09-03T15:26:40", "name": "remove make support in DPDK", "version": 3, "mbox": "http://patches.dpdk.org/series/11929/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76417/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/76417/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 051B6A04BF;\n\tThu, 3 Sep 2020 17:29:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F05F01C11B;\n\tThu, 3 Sep 2020 17:28:03 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 6E4581C0DA\n for <dev@dpdk.org>; Thu, 3 Sep 2020 17:28:01 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Sep 2020 08:28:01 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga006.jf.intel.com with ESMTP; 03 Sep 2020 08:27:59 -0700" ], "IronPort-SDR": [ "\n vqfZkYeV9dJZUhE+qYf0pprHKpCCxdUwEluru4oPJq7+y8ZD1Oqh+ClvPGbYwEKkFag9qfSRBZ\n Z25qTwUFPQeQ==", "\n 2xQNyzZ13e7CyonaEa9K23Zz3tJ8Z9sre2pmBSqGcRfMbKAOt8aLfJ5Kh194mToNEr5akAYhn0\n r6f1vTZcL7dQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9733\"; a=\"145332136\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"145332136\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"302243750\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n David Hunt <david.hunt@intel.com>", "Date": "Thu, 3 Sep 2020 16:26:46 +0100", "Message-Id": "<20200903152717.42095-7-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200903152717.42095-1-ciara.power@intel.com>", "References": "<20200807123009.21266-1-ciara.power@intel.com>\n <20200903152717.42095-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 06/37] examples/vm_power_manager: convert to\n\tuse DPDK pkg-config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nConvert the build of the vm_power_manager app over to use DPDK from\npkg-config rather than using RTE_SDK/RTE_TARGET.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vm_power_manager/Makefile | 74 ++++++++++++++----------------\n 1 file changed, 35 insertions(+), 39 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/Makefile b/examples/vm_power_manager/Makefile\nindex 65c2ad179e..87b9744d8c 100644\n--- a/examples/vm_power_manager/Makefile\n+++ b/examples/vm_power_manager/Makefile\n@@ -1,65 +1,61 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2010-2014 Intel Corporation\n+# Copyright(c) 2010-2020 Intel Corporation\n \n-ifneq ($(shell pkg-config --atleast-version=0.9.3 libvirt; echo $$?), 0)\n-$(error vm_power_manager requires libvirt >= 0.9.3)\n-else\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n endif\n \n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n # binary name\n APP = vm_power_mgr\n \n # all source are stored in SRCS-y\n SRCS-y := main.c vm_power_cli.c power_manager.c channel_manager.c\n SRCS-y += channel_monitor.c parse.c\n-ifeq ($(CONFIG_RTE_ARCH_X86_64),y)\n+ifeq ($(shell uname -m),x86_64)\n SRCS-y += oob_monitor_x86.c\n else\n SRCS-y += oob_monitor_nop.c\n endif\n \n-CFLAGS += -O3 -I$(RTE_SDK)/lib/librte_power/\n-CFLAGS += $(WERROR_FLAGS)\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n \n-LDLIBS += -lvirt\n+PKGCONF ?= pkg-config\n \n-JANSSON := $(shell pkg-config --exists jansson; echo $$?)\n-ifeq ($(JANSSON), 0)\n-LDLIBS += $(shell pkg-config --libs jansson)\n-CFLAGS += -DUSE_JANSSON\n-endif\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n \n-ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n-\n-ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)\n-LDLIBS += -lrte_pmd_ixgbe\n+ifneq ($(shell $(PKGCONF) --atleast-version=0.9.3 libvirt; echo $$?), 0)\n+$(error vm_power_manager requires libvirt >= 0.9.3)\n endif\n+LDFLAGS += $(shell $(PKGCONF) --libs libvirt)\n \n-ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)\n-LDLIBS += -lrte_pmd_i40e\n+JANSSON := $(shell $(PKGCONF) --exists jansson; echo $$?)\n+ifeq ($(JANSSON), 0)\n+LDFLAGS += $(shell $(PKGCONF) --libs jansson)\n+CFLAGS += -DUSE_JANSSON\n endif\n \n-ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)\n-LDLIBS += -lrte_pmd_bnxt\n-endif\n+# for shared library builds, we need to explicitly link these PMDs\n+LDFLAGS_SHARED += -lrte_pmd_ixgbe -lrte_pmd_i40e -lrte_pmd_bnxt\n \n-endif\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n \n-# workaround for a gcc bug with noreturn attribute\n-# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603\n-ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)\n-CFLAGS_main.o += -Wno-return-type\n-endif\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+build:\n+\t@mkdir -p $@\n \n-endif # libvirt check\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\n", "prefixes": [ "v3", "06/37" ] }