Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76416/?format=api
{ "id": 76416, "url": "http://patches.dpdk.org/api/patches/76416/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-6-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200903152717.42095-6-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200903152717.42095-6-ciara.power@intel.com", "date": "2020-09-03T15:26:45", "name": "[v3,05/37] examples/pthread: convert to pkg-config-based build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "458371d48f95c671f928e1c32fe8e7b6858e1969", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-6-ciara.power@intel.com/mbox/", "series": [ { "id": 11929, "url": "http://patches.dpdk.org/api/series/11929/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11929", "date": "2020-09-03T15:26:40", "name": "remove make support in DPDK", "version": 3, "mbox": "http://patches.dpdk.org/series/11929/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76416/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F545A04BF;\n\tThu, 3 Sep 2020 17:29:06 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 58F281C10C;\n\tThu, 3 Sep 2020 17:28:02 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 6D4361C0D5\n for <dev@dpdk.org>; Thu, 3 Sep 2020 17:28:00 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Sep 2020 08:27:59 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga006.jf.intel.com with ESMTP; 03 Sep 2020 08:27:57 -0700" ], "IronPort-SDR": [ "\n /Z6u00f4b+9bIuy03dVYf2iZwkyN08SUvXYdmMAgruo7YEMHyzLBFYqtqFIs+/UjUNZ102UKEe\n 6Ujrb+lm9jeQ==", "\n xGOVkT18qxvoqWBleD+5ZxkpZwK9b7xpn7DuVhqh2+/ucURKGq35HaOp6gbJGCxIC1vUmlwTRY\n qSAKtmLrLtSQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9733\"; a=\"145332130\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"145332130\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"302243736\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Kevin Laatz <kevin.laatz@intel.com>,\n John McNamara <john.mcnamara@intel.com>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>", "Date": "Thu, 3 Sep 2020 16:26:45 +0100", "Message-Id": "<20200903152717.42095-6-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200903152717.42095-1-ciara.power@intel.com>", "References": "<20200807123009.21266-1-ciara.power@intel.com>\n <20200903152717.42095-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 05/37] examples/pthread: convert to\n\tpkg-config-based build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kevin Laatz <kevin.laatz@intel.com>\n\nRemove references to the old make build system and use pkg-config for\nbuilding these examples.\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n examples/performance-thread/Makefile | 21 +++----\n examples/performance-thread/common/common.mk | 6 +-\n .../performance-thread/l3fwd-thread/Makefile | 47 +++++++++++-----\n .../performance-thread/pthread_shim/Makefile | 56 +++++++++++++------\n 4 files changed, 83 insertions(+), 47 deletions(-)", "diff": "diff --git a/examples/performance-thread/Makefile b/examples/performance-thread/Makefile\nindex 08158914c3..ef88722d3c 100644\n--- a/examples/performance-thread/Makefile\n+++ b/examples/performance-thread/Makefile\n@@ -1,21 +1,14 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2015 Intel Corporation\n+# Copyright(c) 2015-2020 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n+subdirs := l3fwd-thread pthread_shim\n \n-include $(RTE_SDK)/mk/rte.vars.mk\n+.PHONY: all static shared clean $(subdirs)\n+all static shared clean: $(subdirs)\n \n-ifeq ($(filter y,$(CONFIG_RTE_ARCH_X86_64) $(CONFIG_RTE_ARCH_ARM64)),)\n+ifeq ($(filter $(shell uname -m),x86_64 arm64),)\n $(error This application is only supported for x86_64 and arm64 targets)\n endif\n \n-DIRS-y += l3fwd-thread\n-DIRS-y += pthread_shim\n-\n-\n-include $(RTE_SDK)/mk/rte.extsubdir.mk\n+$(subdirs):\n+\t$(MAKE) -C $@ $(MAKECMDGOALS)\ndiff --git a/examples/performance-thread/common/common.mk b/examples/performance-thread/common/common.mk\nindex 5e2b18a9ff..a33e2ab038 100644\n--- a/examples/performance-thread/common/common.mk\n+++ b/examples/performance-thread/common/common.mk\n@@ -8,9 +8,9 @@\n \n MKFILE_PATH=$(abspath $(dir $(lastword $(MAKEFILE_LIST))))\n \n-ifeq ($(CONFIG_RTE_ARCH_X86_64),y)\n+ifeq ($(shell uname -m),x86_64)\n ARCH_PATH += $(MKFILE_PATH)/arch/x86\n-else ifeq ($(CONFIG_RTE_ARCH_ARM64),y)\n+else ifeq ($(shell uname -m),arm64)\n ARCH_PATH += $(MKFILE_PATH)/arch/arm64\n endif\n \n@@ -18,4 +18,4 @@ VPATH := $(MKFILE_PATH) $(ARCH_PATH)\n \n SRCS-y += lthread.c lthread_sched.c lthread_cond.c lthread_tls.c lthread_mutex.c lthread_diag.c ctx.c\n \n-INCLUDES += -I$(MKFILE_PATH) -I$(ARCH_PATH)\n+CFLAGS += -I$(MKFILE_PATH) -I$(ARCH_PATH)\ndiff --git a/examples/performance-thread/l3fwd-thread/Makefile b/examples/performance-thread/l3fwd-thread/Makefile\nindex c6cf05a438..ca1a5d087e 100644\n--- a/examples/performance-thread/l3fwd-thread/Makefile\n+++ b/examples/performance-thread/l3fwd-thread/Makefile\n@@ -1,14 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2010-2015 Intel Corporation\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n+# Copyright(c) 2010-2020 Intel Corporation\n \n # binary name\n APP = l3fwd-thread\n@@ -16,9 +7,39 @@ APP = l3fwd-thread\n # all source are stored in SRCS-y\n SRCS-y := main.c\n \n-include $(RTE_SDK)/examples/performance-thread/common/common.mk\n+include ../common/common.mk\n \n-CFLAGS += -O3 -g $(USER_FLAGS) $(INCLUDES) $(WERROR_FLAGS)\n CFLAGS += -DALLOW_EXPERIMENTAL_API\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(filter %.c,$^) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(filter %.c,$^) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/performance-thread/pthread_shim/Makefile b/examples/performance-thread/pthread_shim/Makefile\nindex cdadf2cb77..6b19ff63fe 100644\n--- a/examples/performance-thread/pthread_shim/Makefile\n+++ b/examples/performance-thread/pthread_shim/Makefile\n@@ -1,33 +1,55 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2015 Intel Corporation\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n+# Copyright(c) 2010-2020 Intel Corporation\n \n # binary name\n APP = lthread_pthread_shim\n \n # all source are stored in SRCS-y\n-SRCS-y := main.c pthread_shim.c\n-INCLUDES := -I$(RTE_SDK)/$(RTE_TARGET)/include -I$(SRCDIR)\n-include $(RTE_SDK)/examples/performance-thread/common/common.mk\n+SRCS-y := main.c pthread_shim.c\n+\n+include ../common/common.mk\n \n-CFLAGS += -g -O3 $(USER_FLAGS) $(INCLUDES)\n-CFLAGS += $(WERROR_FLAGS)\n CFLAGS += -DALLOW_EXPERIMENTAL_API\n+CFLAGS += -D_GNU_SOURCE\n+LDFLAGS += \"-Wl,--copy-dt-needed-entries\"\n+\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n \n LDFLAGS += -lpthread\n \n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(filter %.c,$^) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(filter %.c,$^) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n # workaround for a gcc bug with noreturn attribute\n # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603\n-ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)\n+ifeq ($(shell gcc -dumpversion),-gt 0)\n CFLAGS_main.o += -Wno-return-type\n endif\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\n", "prefixes": [ "v3", "05/37" ] }