Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76413/?format=api
{ "id": 76413, "url": "http://patches.dpdk.org/api/patches/76413/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-3-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200903152717.42095-3-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200903152717.42095-3-ciara.power@intel.com", "date": "2020-09-03T15:26:42", "name": "[v3,02/37] examples/multi_process: convert to pkg-config-based build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "807b2fd09f43982fb840c6cf47b47b435e89395a", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200903152717.42095-3-ciara.power@intel.com/mbox/", "series": [ { "id": 11929, "url": "http://patches.dpdk.org/api/series/11929/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11929", "date": "2020-09-03T15:26:40", "name": "remove make support in DPDK", "version": 3, "mbox": "http://patches.dpdk.org/series/11929/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76413/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76413/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08B67A04BF;\n\tThu, 3 Sep 2020 17:28:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 496181C0CD;\n\tThu, 3 Sep 2020 17:27:59 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id B20E61C0B2\n for <dev@dpdk.org>; Thu, 3 Sep 2020 17:27:56 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Sep 2020 08:27:55 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga006.jf.intel.com with ESMTP; 03 Sep 2020 08:27:53 -0700" ], "IronPort-SDR": [ "\n OTh3oC1QRdZIc/vCY5Ti+ybURKzHHwq8ZvNGraZX53t46xhBiEXUyFLzR6/D0N8gwl7KD0Mxke\n QAVvTafAE/yA==", "\n w0vEYu/sT5UZSOS89oho7MyQYR+fmFNSvxRsFthWexRtz2TrNVqIsDaZYKug1LJYWDGShwUd9X\n 1zRGT/xs5BtA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9733\"; a=\"145332110\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"145332110\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"302243701\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Thu, 3 Sep 2020 16:26:42 +0100", "Message-Id": "<20200903152717.42095-3-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200903152717.42095-1-ciara.power@intel.com>", "References": "<20200807123009.21266-1-ciara.power@intel.com>\n <20200903152717.42095-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 02/37] examples/multi_process: convert to\n\tpkg-config-based build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nRemove references to the old make build system and use pkg-config for\nbuilding these examples.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/multi_process/Makefile | 21 ++------\n .../multi_process/client_server_mp/Makefile | 19 ++-----\n .../client_server_mp/mp_client/Makefile | 44 ++++++++++++----\n .../client_server_mp/mp_server/Makefile | 51 +++++++++++--------\n examples/multi_process/hotplug_mp/Makefile | 46 ++++++++++++-----\n examples/multi_process/simple_mp/Makefile | 44 +++++++++++-----\n examples/multi_process/symmetric_mp/Makefile | 44 +++++++++++-----\n 7 files changed, 167 insertions(+), 102 deletions(-)", "diff": "diff --git a/examples/multi_process/Makefile b/examples/multi_process/Makefile\nindex 7f7e68d912..f0a999745a 100644\n--- a/examples/multi_process/Makefile\n+++ b/examples/multi_process/Makefile\n@@ -1,18 +1,7 @@\n-# SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2010-2014 Intel Corporation\n+subdirs := client_server_mp hotplug_mp simple_mp symmetric_mp\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n+.PHONY: all static shared clean $(subdirs)\n+all static shared clean: $(subdirs)\n \n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += client_server_mp\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += simple_mp\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += symmetric_mp\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += hotplug_mp\n-\n-include $(RTE_SDK)/mk/rte.extsubdir.mk\n+$(subdirs):\n+\t$(MAKE) -C $@ $(MAKECMDGOALS)\ndiff --git a/examples/multi_process/client_server_mp/Makefile b/examples/multi_process/client_server_mp/Makefile\nindex fe7a8af605..e8debdfd9a 100644\n--- a/examples/multi_process/client_server_mp/Makefile\n+++ b/examples/multi_process/client_server_mp/Makefile\n@@ -1,16 +1,7 @@\n-# SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2010-2014 Intel Corporation\n+subdirs := mp_client mp_server\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n+.PHONY: all static shared clean $(subdirs)\n+all static shared clean: $(subdirs)\n \n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += mp_client\n-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUX) += mp_server\n-\n-include $(RTE_SDK)/mk/rte.extsubdir.mk\n+$(subdirs):\n+\t$(MAKE) -C $@ $(MAKECMDGOALS)\ndiff --git a/examples/multi_process/client_server_mp/mp_client/Makefile b/examples/multi_process/client_server_mp/mp_client/Makefile\nindex 7c447feba3..b723e545b7 100644\n--- a/examples/multi_process/client_server_mp/mp_client/Makefile\n+++ b/examples/multi_process/client_server_mp/mp_client/Makefile\n@@ -1,21 +1,43 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, can be overridden by command line or environment\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n # binary name\n APP = mp_client\n \n # all source are stored in SRCS-y\n SRCS-y := client.c\n \n-CFLAGS += $(WERROR_FLAGS) -O3\n-CFLAGS += -I$(SRCDIR)/../shared\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+CFLAGS += -I../shared\n+\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/multi_process/client_server_mp/mp_server/Makefile b/examples/multi_process/client_server_mp/mp_server/Makefile\nindex 50ebf1d7da..f49260a256 100644\n--- a/examples/multi_process/client_server_mp/mp_server/Makefile\n+++ b/examples/multi_process/client_server_mp/mp_server/Makefile\n@@ -1,34 +1,43 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n+# binary name\n+APP = mp_server\n \n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n+# all source are stored in SRCS-y\n+SRCS-y := main.c init.c args.c\n \n-include $(RTE_SDK)/mk/rte.vars.mk\n+CFLAGS += -I../shared\n \n-ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)\n-$(error This application can only operate in a linux environment, \\\n-please change the definition of the RTE_TARGET environment variable)\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n endif\n \n-# binary name\n-APP = mp_server\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n \n-# all source are stored in SRCS-y\n-SRCS-y := main.c init.c args.c\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n \n-INC := $(sort $(wildcard *.h))\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n \n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n-CFLAGS += $(WERROR_FLAGS) -O3\n-CFLAGS += -I$(SRCDIR)/../shared\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n \n-# for newer gcc, e.g. 4.4, no-strict-aliasing may not be necessary\n-# and so the next line can be removed in those cases.\n-EXTRA_CFLAGS += -fno-strict-aliasing\n+build:\n+\t@mkdir -p $@\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/multi_process/hotplug_mp/Makefile b/examples/multi_process/hotplug_mp/Makefile\nindex 1fd7aa085c..2c023a73d8 100644\n--- a/examples/multi_process/hotplug_mp/Makefile\n+++ b/examples/multi_process/hotplug_mp/Makefile\n@@ -1,14 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2018 Intel Corporation\n-\n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n+# Copyright(c) 2010-2014 Intel Corporation\n \n # binary name\n APP = hotplug_mp\n@@ -16,8 +7,35 @@ APP = hotplug_mp\n # all source are stored in SRCS-y\n SRCS-y := main.c commands.c\n \n-CFLAGS += -O3\n-CFLAGS += $(WERROR_FLAGS)\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/multi_process/simple_mp/Makefile b/examples/multi_process/simple_mp/Makefile\nindex f88b499bdc..410f8b5368 100644\n--- a/examples/multi_process/simple_mp/Makefile\n+++ b/examples/multi_process/simple_mp/Makefile\n@@ -1,23 +1,41 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n # binary name\n APP = simple_mp\n \n # all source are stored in SRCS-y\n SRCS-y := main.c mp_commands.c\n \n-CFLAGS += -O3\n-CFLAGS += $(WERROR_FLAGS)\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\ndiff --git a/examples/multi_process/symmetric_mp/Makefile b/examples/multi_process/symmetric_mp/Makefile\nindex b7544489bb..df69ecabe7 100644\n--- a/examples/multi_process/symmetric_mp/Makefile\n+++ b/examples/multi_process/symmetric_mp/Makefile\n@@ -1,23 +1,41 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n \n-ifeq ($(RTE_SDK),)\n-$(error \"Please define RTE_SDK environment variable\")\n-endif\n-\n-# Default target, detect a build directory, by looking for a path with a .config\n-RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.config)))))\n-\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n # binary name\n APP = symmetric_mp\n \n # all source are stored in SRCS-y\n SRCS-y := main.c\n \n-CFLAGS += -O3\n-CFLAGS += $(WERROR_FLAGS)\n-CFLAGS += -DALLOW_EXPERIMENTAL_API\n+# Build using pkg-config variables if possible\n+ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)\n+$(error \"no installation of DPDK found\")\n+endif\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF ?= pkg-config\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n \n-include $(RTE_SDK)/mk/rte.extapp.mk\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\n", "prefixes": [ "v3", "02/37" ] }