Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76349/?format=api
{ "id": 76349, "url": "http://patches.dpdk.org/api/patches/76349/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200903044856.61961-13-guinanx.sun@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200903044856.61961-13-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200903044856.61961-13-guinanx.sun@intel.com", "date": "2020-09-03T04:48:53", "name": "[v3,12/15] net/i40e/base: fix Rx only mode for unicast promisc on VLAN", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "df685c900c7fde0a9700afa9c1cca39b2445da72", "submitter": { "id": 1476, "url": "http://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200903044856.61961-13-guinanx.sun@intel.com/mbox/", "series": [ { "id": 11915, "url": "http://patches.dpdk.org/api/series/11915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11915", "date": "2020-09-03T04:48:41", "name": "update i40e base code", "version": 3, "mbox": "http://patches.dpdk.org/series/11915/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76349/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76349/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9B0BEA04D7;\n\tThu, 3 Sep 2020 06:57:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF84C1C1A4;\n\tThu, 3 Sep 2020 06:55:51 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 0CA441C11E;\n Thu, 3 Sep 2020 06:55:48 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Sep 2020 21:55:48 -0700", "from dpdk.sh.intel.com ([10.239.255.12])\n by orsmga002.jf.intel.com with ESMTP; 02 Sep 2020 21:55:46 -0700" ], "IronPort-SDR": [ "\n p9fOnwbF/hvoH0csE9DbD9gKeP4sUSfhdtNilL5XLew9hvSrwwVNxUDJeyZ2iNJm2iiKCQ7cz/\n 0BrexIzAaKqQ==", "\n IU8idYP7UtVpKbgknRnoSwMsqOekpK8LPqgJgEn4lbt1DDujyuwzLPabIVueNvxYB6DiujMJbT\n rbjIIEBvhE7Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9732\"; a=\"221732258\"", "E=Sophos;i=\"5.76,385,1592895600\"; d=\"scan'208\";a=\"221732258\"", "E=Sophos;i=\"5.76,385,1592895600\"; d=\"scan'208\";a=\"315349329\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>, stable@dpdk.org,\n Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>", "Date": "Thu, 3 Sep 2020 04:48:53 +0000", "Message-Id": "<20200903044856.61961-13-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200903044856.61961-1-guinanx.sun@intel.com>", "References": "<20200727053451.22214-1-guinanx.sun@intel.com>\n <20200903044856.61961-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 12/15] net/i40e/base: fix Rx only mode for\n\tunicast promisc on VLAN", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Set promiscuous mode to rx traffic only if VSI has VLANs configured.\nRename misleading PROMISC_TX bit to proper name.\nAdded I40E_AQC_SET_VSI_PROMISC_RX_ONLY during VSI unicast promiscuous\nmode configuration with port VLAN.\nAligned unicast promiscuous with VLAN to the one without VLAN.\nPreviously other VFs could listen to unicast tx traffic of other VFs.\n\nFixes: 8db9e2a1b232 (\"i40e: base driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq_cmd.h | 2 +-\n drivers/net/i40e/base/i40e_common.c | 36 +++++++++++++++++++------\n 2 files changed, 29 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\nindex 4db8cdd8c..d6402a691 100644\n--- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n+++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n@@ -1222,7 +1222,7 @@ struct i40e_aqc_set_vsi_promiscuous_modes {\n #define I40E_AQC_SET_VSI_PROMISC_BROADCAST\t0x04\n #define I40E_AQC_SET_VSI_DEFAULT\t\t0x08\n #define I40E_AQC_SET_VSI_PROMISC_VLAN\t\t0x10\n-#define I40E_AQC_SET_VSI_PROMISC_TX\t\t0x8000\n+#define I40E_AQC_SET_VSI_PROMISC_RX_ONLY\t0x8000\n \t__le16\tseid;\n #define I40E_AQC_VSI_PROM_CMD_SEID_MASK\t\t0x3FF\n \t__le16\tvlan_tag;\ndiff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 15f4e91a4..cd8b27e40 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -2270,6 +2270,22 @@ enum i40e_status_code i40e_aq_set_phy_debug(struct i40e_hw *hw, u8 cmd_flags,\n \treturn status;\n }\n \n+/**\n+ * i40e_hw_ver_ge\n+ * @hw: pointer to the hw struct\n+ * @maj: api major value\n+ * @min: api minor value\n+ *\n+ * Assert whether current HW api version is greater/equal than provided.\n+ **/\n+static bool i40e_hw_ver_ge(struct i40e_hw *hw, u16 maj, u16 min)\n+{\n+\tif (hw->aq.api_maj_ver > maj ||\n+\t (hw->aq.api_maj_ver == maj && hw->aq.api_min_ver >= min))\n+\t\treturn true;\n+\treturn false;\n+}\n+\n /**\n * i40e_aq_add_vsi\n * @hw: pointer to the hw struct\n@@ -2395,18 +2411,16 @@ enum i40e_status_code i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw,\n \n \tif (set) {\n \t\tflags |= I40E_AQC_SET_VSI_PROMISC_UNICAST;\n-\t\tif (rx_only_promisc &&\n-\t\t (((hw->aq.api_maj_ver == 1) && (hw->aq.api_min_ver >= 5)) ||\n-\t\t (hw->aq.api_maj_ver > 1)))\n-\t\t\tflags |= I40E_AQC_SET_VSI_PROMISC_TX;\n+\t\tif (rx_only_promisc && i40e_hw_ver_ge(hw, 1, 5))\n+\t\t\tflags |= I40E_AQC_SET_VSI_PROMISC_RX_ONLY;\n \t}\n \n \tcmd->promiscuous_flags = CPU_TO_LE16(flags);\n \n \tcmd->valid_flags = CPU_TO_LE16(I40E_AQC_SET_VSI_PROMISC_UNICAST);\n-\tif (((hw->aq.api_maj_ver >= 1) && (hw->aq.api_min_ver >= 5)) ||\n-\t (hw->aq.api_maj_ver > 1))\n-\t\tcmd->valid_flags |= CPU_TO_LE16(I40E_AQC_SET_VSI_PROMISC_TX);\n+\tif (i40e_hw_ver_ge(hw, 1, 5))\n+\t\tcmd->valid_flags |=\n+\t\t\tCPU_TO_LE16(I40E_AQC_SET_VSI_PROMISC_RX_ONLY);\n \n \tcmd->seid = CPU_TO_LE16(seid);\n \tstatus = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);\n@@ -2538,11 +2552,17 @@ enum i40e_status_code i40e_aq_set_vsi_uc_promisc_on_vlan(struct i40e_hw *hw,\n \ti40e_fill_default_direct_cmd_desc(&desc,\n \t\t\t\t\ti40e_aqc_opc_set_vsi_promiscuous_modes);\n \n-\tif (enable)\n+\tif (enable) {\n \t\tflags |= I40E_AQC_SET_VSI_PROMISC_UNICAST;\n+\t\tif (i40e_hw_ver_ge(hw, 1, 5))\n+\t\t\tflags |= I40E_AQC_SET_VSI_PROMISC_RX_ONLY;\n+\t}\n \n \tcmd->promiscuous_flags = CPU_TO_LE16(flags);\n \tcmd->valid_flags = CPU_TO_LE16(I40E_AQC_SET_VSI_PROMISC_UNICAST);\n+\tif (i40e_hw_ver_ge(hw, 1, 5))\n+\t\tcmd->valid_flags |=\n+\t\t\tCPU_TO_LE16(I40E_AQC_SET_VSI_PROMISC_RX_ONLY);\n \tcmd->seid = CPU_TO_LE16(seid);\n \tcmd->vlan_tag = CPU_TO_LE16(vid | I40E_AQC_SET_VSI_VLAN_VALID);\n \n", "prefixes": [ "v3", "12/15" ] }