Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7631/?format=api
{ "id": 7631, "url": "http://patches.dpdk.org/api/patches/7631/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1444874628-5453-28-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444874628-5453-28-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444874628-5453-28-git-send-email-wenzhuo.lu@intel.com", "date": "2015-10-15T02:03:40", "name": "[dpdk-dev,v2,27/35] e1000/base: fix for i354 88E1112 PHY using AutoMedia Detect", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bf4659c135ca1b79ecfcc223b6a9a5aab426a371", "submitter": { "id": 258, "url": "http://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1444874628-5453-28-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/7631/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/7631/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C2F379237;\n\tThu, 15 Oct 2015 04:05:01 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 409C58E9A\n\tfor <dev@dpdk.org>; Thu, 15 Oct 2015 04:04:58 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 14 Oct 2015 19:04:58 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 14 Oct 2015 19:04:56 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9F24s3U005124;\n\tThu, 15 Oct 2015 10:04:54 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9F24pow005956; Thu, 15 Oct 2015 10:04:53 +0800", "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9F24pF9005952; \n\tThu, 15 Oct 2015 10:04:51 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,683,1437462000\"; d=\"scan'208\";a=\"827239161\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 15 Oct 2015 10:03:40 +0800", "Message-Id": "<1444874628-5453-28-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 27/35] e1000/base: fix for i354 88E1112 PHY\n\tusing AutoMedia Detect", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "e1000_check_for_link_media_swap() is supposed to check PHY page 0 for\ncopper and PHY page 1 for \"other\" (fiber) link. We switched back from\npage 1 to page 0 too soon, before e1000_check_for_link_82575() is\nexecuted and we were never finding link on fiber (other).\n\nNote: The precedence of link type is controlled by the PHY settings.\n\nIf the link is copper, as the M88E1112 page address is set to 1, it should be\nset back to 0 before checking this link.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_82575.c | 23 +++++++++++++++--------\n 1 file changed, 15 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c\nindex e170353..4374eab 100644\n--- a/drivers/net/e1000/base/e1000_82575.c\n+++ b/drivers/net/e1000/base/e1000_82575.c\n@@ -1234,7 +1234,7 @@ STATIC s32 e1000_check_for_link_media_swap(struct e1000_hw *hw)\n \n \tDEBUGFUNC(\"e1000_check_for_link_media_swap\");\n \n-\t/* Check the copper medium. */\n+\t/* Check for copper. */\n \tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 0);\n \tif (ret_val)\n \t\treturn ret_val;\n@@ -1246,7 +1246,7 @@ STATIC s32 e1000_check_for_link_media_swap(struct e1000_hw *hw)\n \tif (data & E1000_M88E1112_STATUS_LINK)\n \t\tport = E1000_MEDIA_PORT_COPPER;\n \n-\t/* Check the other medium. */\n+\t/* Check for other. */\n \tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 1);\n \tif (ret_val)\n \t\treturn ret_val;\n@@ -1255,11 +1255,6 @@ STATIC s32 e1000_check_for_link_media_swap(struct e1000_hw *hw)\n \tif (ret_val)\n \t\treturn ret_val;\n \n-\t/* reset page to 0 */\n-\tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 0);\n-\tif (ret_val)\n-\t\treturn ret_val;\n-\n \tif (data & E1000_M88E1112_STATUS_LINK)\n \t\tport = E1000_MEDIA_PORT_OTHER;\n \n@@ -1267,8 +1262,20 @@ STATIC s32 e1000_check_for_link_media_swap(struct e1000_hw *hw)\n \tif (port && (hw->dev_spec._82575.media_port != port)) {\n \t\thw->dev_spec._82575.media_port = port;\n \t\thw->dev_spec._82575.media_changed = true;\n+\t}\n+\n+\tif (port == E1000_MEDIA_PORT_COPPER) {\n+\t\t/* reset page to 0 */\n+\t\tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 0);\n+\t\tif (ret_val)\n+\t\t\treturn ret_val;\n+\t\te1000_check_for_link_82575(hw);\n \t} else {\n-\t\tret_val = e1000_check_for_link_82575(hw);\n+\t\te1000_check_for_link_82575(hw);\n+\t\t/* reset page to 0 */\n+\t\tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 0);\n+\t\tif (ret_val)\n+\t\t\treturn ret_val;\n \t}\n \n \treturn E1000_SUCCESS;\n", "prefixes": [ "dpdk-dev", "v2", "27/35" ] }