Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76180/?format=api
{ "id": 76180, "url": "http://patches.dpdk.org/api/patches/76180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200831085145.184179-3-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200831085145.184179-3-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200831085145.184179-3-ruifeng.wang@arm.com", "date": "2020-08-31T08:51:44", "name": "[2/3] crypto/armv8: fix mempool object returning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9bb075f02c7a0857f6cc47db1b846a6b1fa91c83", "submitter": { "id": 1198, "url": "http://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200831085145.184179-3-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 11860, "url": "http://patches.dpdk.org/api/series/11860/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11860", "date": "2020-08-31T08:51:42", "name": "armv8 crypto PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/11860/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76180/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 907C5A04AB;\n\tMon, 31 Aug 2020 10:52:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B1BE1C0B6;\n\tMon, 31 Aug 2020 10:52:34 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id BEC191C0B1;\n Mon, 31 Aug 2020 10:52:32 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4CB141FB;\n Mon, 31 Aug 2020 01:52:32 -0700 (PDT)", "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.210.116])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E15753F68F;\n Mon, 31 Aug 2020 01:52:28 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "Ruifeng Wang <ruifeng.wang@arm.com>, Akhil Goyal <akhil.goyal@nxp.com>,\n Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n Declan Doherty <declan.doherty@intel.com>,\n Fiona Trahe <fiona.trahe@intel.com>, Fan Zhang <roy.fan.zhang@intel.com>", "Cc": "dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com, stable@dpdk.org", "Date": "Mon, 31 Aug 2020 16:51:44 +0800", "Message-Id": "<20200831085145.184179-3-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200831085145.184179-1-ruifeng.wang@arm.com>", "References": "<20200831085145.184179-1-ruifeng.wang@arm.com>", "Subject": "[dpdk-dev] [PATCH 2/3] crypto/armv8: fix mempool object returning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Crypto session and device session private data were put back\nto wrong pools.\nThis caused data corruption when the object was reallocated and used.\nBecause objects from different mempools have different element size,\nand wrong mempool info caused out of bound write.\nFix the issue by putting back objects to correct mempools.\n\nFixes: b3bbd9e5f265 (\"cryptodev: support device independent sessions\")\nFixes: 725d2a7fbf71 (\"cryptodev: change queue pair configure structure\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/crypto/armv8/rte_armv8_pmd.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c\nindex c95729db5..72d29ae0c 100644\n--- a/drivers/crypto/armv8/rte_armv8_pmd.c\n+++ b/drivers/crypto/armv8/rte_armv8_pmd.c\n@@ -674,8 +674,8 @@ process_op(struct armv8_crypto_qp *qp, struct rte_crypto_op *op,\n \t\tmemset(op->sym->session, 0,\n \t\t\trte_cryptodev_sym_get_existing_header_session_size(\n \t\t\t\top->sym->session));\n-\t\trte_mempool_put(qp->sess_mp, sess);\n-\t\trte_mempool_put(qp->sess_mp_priv, op->sym->session);\n+\t\trte_mempool_put(qp->sess_mp_priv, sess);\n+\t\trte_mempool_put(qp->sess_mp, op->sym->session);\n \t\top->sym->session = NULL;\n \t}\n \n", "prefixes": [ "2/3" ] }