Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 76179,
    "url": "http://patches.dpdk.org/api/patches/76179/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200831085145.184179-2-ruifeng.wang@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200831085145.184179-2-ruifeng.wang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200831085145.184179-2-ruifeng.wang@arm.com",
    "date": "2020-08-31T08:51:43",
    "name": "[1/3] test/crypto: fix stat test",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d555ca98e4c0ce3e7c81345c79c352605b4e4c3d",
    "submitter": {
        "id": 1198,
        "url": "http://patches.dpdk.org/api/people/1198/?format=api",
        "name": "Ruifeng Wang",
        "email": "ruifeng.wang@arm.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200831085145.184179-2-ruifeng.wang@arm.com/mbox/",
    "series": [
        {
            "id": 11860,
            "url": "http://patches.dpdk.org/api/series/11860/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11860",
            "date": "2020-08-31T08:51:42",
            "name": "armv8 crypto PMD",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/11860/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/76179/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/76179/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48BA4A04AB;\n\tMon, 31 Aug 2020 10:52:28 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2A2BF1C0AC;\n\tMon, 31 Aug 2020 10:52:28 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id D5CBDA3;\n Mon, 31 Aug 2020 10:52:26 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E75E1FB;\n Mon, 31 Aug 2020 01:52:26 -0700 (PDT)",
            "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.210.116])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F323C3F68F;\n Mon, 31 Aug 2020 01:52:22 -0700 (PDT)"
        ],
        "From": "Ruifeng Wang <ruifeng.wang@arm.com>",
        "To": "Declan Doherty <declan.doherty@intel.com>,\n Fiona Trahe <fiona.trahe@intel.com>, John Griffin <john.griffin@intel.com>,\n Des O Dea <des.j.o.dea@intel.com>,\n Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>",
        "Cc": "dev@dpdk.org, akhil.goyal@nxp.com, honnappa.nagarahalli@arm.com,\n nd@arm.com, Ruifeng Wang <ruifeng.wang@arm.com>, stable@dpdk.org",
        "Date": "Mon, 31 Aug 2020 16:51:43 +0800",
        "Message-Id": "<20200831085145.184179-2-ruifeng.wang@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200831085145.184179-1-ruifeng.wang@arm.com>",
        "References": "<20200831085145.184179-1-ruifeng.wang@arm.com>",
        "Subject": "[dpdk-dev] [PATCH 1/3] test/crypto: fix stat test",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "ut_setup / ut_teardown are invoked for each test case by test framework.\nThe call inside test_stats is unnecessary and even incorrect.\nThis caused double free of objects such as crypto operation structure.\nTrapped the issue when RTE_LIBRTE_MEMPOOL_DEBUG was enabled.\nFix issue by removing ut_setup / ut_teardown from test case implementation.\n\nFixes: 202d375c60bc (\"app/test: add cryptodev unit and performance tests\")\nCc: declan.doherty@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_cryptodev.c | 2 --\n 1 file changed, 2 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 70bf6fe2c..068b8c9c1 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -9326,9 +9326,7 @@ test_stats(void)\n \t\t\"rte_cryptodev_stats_get invalid Param failed\");\n \n \t/* Test expected values */\n-\tut_setup();\n \ttest_AES_CBC_HMAC_SHA1_encrypt_digest();\n-\tut_teardown();\n \tTEST_ASSERT_SUCCESS(rte_cryptodev_stats_get(ts_params->valid_devs[0],\n \t\t\t&stats),\n \t\t\"rte_cryptodev_stats_get failed\");\n",
    "prefixes": [
        "1/3"
    ]
}