Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76162/?format=api
{ "id": 76162, "url": "http://patches.dpdk.org/api/patches/76162/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200830111544.4190-13-wisamm@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200830111544.4190-13-wisamm@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200830111544.4190-13-wisamm@mellanox.com", "date": "2020-08-30T11:15:43", "name": "[12/13] app/flow-perf: add icmp matching support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6f7f4938560232b84f47f00ecee52f5bed532f67", "submitter": { "id": 938, "url": "http://patches.dpdk.org/api/people/938/?format=api", "name": "Wisam Jaddo", "email": "wisamm@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200830111544.4190-13-wisamm@mellanox.com/mbox/", "series": [ { "id": 11848, "url": "http://patches.dpdk.org/api/series/11848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11848", "date": "2020-08-30T11:15:31", "name": "app/flow-perf: add support for new items/actions", "version": 1, "mbox": "http://patches.dpdk.org/series/11848/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76162/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76162/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33A81A04AB;\n\tSun, 30 Aug 2020 13:23:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 194C91C139;\n\tSun, 30 Aug 2020 13:16:42 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47])\n by dpdk.org (Postfix) with ESMTP id 06F001C10C\n for <dev@dpdk.org>; Sun, 30 Aug 2020 13:16:35 +0200 (CEST)", "from AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18)\n by AM0PR0502MB3762.eurprd05.prod.outlook.com (2603:10a6:208:1b::31)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.21; Sun, 30 Aug\n 2020 11:16:35 +0000", "from AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::4c8a:9848:2e2a:3598]) by AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::4c8a:9848:2e2a:3598%6]) with mapi id 15.20.3326.025; Sun, 30 Aug 2020\n 11:16:35 +0000", "from mellanox.com (37.142.13.130) by\n AM4PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:205::21) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3326.19 via Frontend Transport; Sun, 30 Aug 2020 11:16:34 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=b3gNXzCXpt2BO0Y+5DfEqTUFLoPmLzqHcL427PH11HvzY5fuQreLbucXJzsNzBf7GrVIqVoReS8yt2sXNn3Eoozwfling2uTAX6Ieo+6bIcpIeWFu24dFe9uZWRruA+FP8e+xOPF6r6SkprcisU/m8y8HA+gPQv7Ftx/wqMR2UkLhHsQkMj+Wss4v6815jKiW8zWDWzoHNsm0JwxashYKXR2qu2Mf0x3fb7AEfrK26jJIbtsLi69X5KtkryJLcWVybw2vqsw636cWrh1QBRqCyAatnExw9ruCk/RHMrI53g2+1TZv/ozBuBz/N4ml7eRbVfRg6Jm8TtuRgdDUVQ+Rw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=86raxxI161eXQOspVivZQi9u89ADDf4VhPNkmqnd2+0=;\n b=ZbRDCYQ5fT6WSdS0xehIxFFpyDSKCl7As8qhwiYauIvlxkSN418TIxhp19xvCj6VExE/Niv0OYOMXEUe4cr+Zd2nAfG425OdzFwzloM/2anGv8RtWbqnBsa2VJXWet86hLzOjufvodVGmABfftojl1/8J8RHlRYfyUCa5J4ztHsPYOwoHcmj6qTuVPT3VX2RGASTOhtLmG9YFS9r/1efiMkWuWgITdS2P6/VPUzYQQaHBicIA5vMfQPuiDmqxph1ydMlvnaORiYz4AUz+adLPCeiD0UhPlu3Ag3KONZGdV0jYpaTBWZKFIK7UiLQqLmWJ9vI1oPAzrU0/9z5D6mxOA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=86raxxI161eXQOspVivZQi9u89ADDf4VhPNkmqnd2+0=;\n b=OGjU68v6a37ojG2q5dP5Wk6DmzYw/lOVOLP+GD87Xa2sleVVxmTTDE90AartifoCga4wYAY64jCA7ZP4EaO143/gAD1kdGqUppXf3y6wuJH4v1BY+eXZknkXcaO52fAciy5DvoPnkrMcIz9lIS5s/HZhQnDzv4L/wTX771Sn/Pw=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Wisam Jaddo <wisamm@mellanox.com>", "To": "dev@dpdk.org, thomas@monjalon.net, asafp@mellanox.com,\n akozyrev@nvidia.com,\n akozyrev@mellanox.com, arybchenko@solarflare.com, jackmin@mellanox.com", "Date": "Sun, 30 Aug 2020 11:15:43 +0000", "Message-Id": "<20200830111544.4190-13-wisamm@mellanox.com>", "X-Mailer": [ "git-send-email 2.17.1", "git-send-email 2.17.1" ], "In-Reply-To": "<20200830111544.4190-1-wisamm@mellanox.com>", "References": "<20200830111544.4190-1-wisamm@mellanox.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM4PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:205::21)\n To AM0PR05MB6610.eurprd05.prod.outlook.com\n (2603:10a6:208:12f::18)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "d2fe7324-f033-43a9-2c38-08d84cd627cd", "X-MS-TrafficTypeDiagnostic": "AM0PR0502MB3762:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR0502MB3762C44619E76AADDC44C0F5A9500@AM0PR0502MB3762.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:3631;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n inZJEl1+f6xm9gy2DiuBLR7bTC5W3S70xfHAtjRwtkxYiP7qa9VK5qd+vU8z5ljk1TsLiqgNuxqYBuMmhfR7Iz1At54sEemHupFZ4ncvM8hRrDnobbh9BaGKTwVjdWb0aMfJ/RQEKVa73kpA9aejBAXj8wZSjC5quqfrmiofKRXqTBNPtI5gyjrzKGkGpdx2FhG/Ai5341DEAWgI6lHiYWcOW3FcjWRU3dMzICfRC2/vjguzCiQPJtQRXBjs50RSsSCRrpYlJsxhbEZBB75sVMrSIMXKAIROkNBB++kX69Xbs3vAMUfQnER8FfEsNzujyGvl5YzaiU6v2uoUhuUUeA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6610.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(478600001)(316002)(5660300002)(8886007)(2906002)(6636002)(86362001)(36756003)(6666004)(1076003)(55016002)(8936002)(26005)(2616005)(7696005)(66946007)(66556008)(52116002)(83380400001)(16526019)(8676002)(186003)(956004)(66476007);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n yYGtBI94OmuW5o79U3wmhYIclCK+/k7H3/iXrKn7Z80IIBS1EVkYJT1/W8sCGovCglkVjnFYoJmJkyInrsKYkW8CRY+WLPUqVUbjj27cvxrphnbQvfs1QaoqP4ZuREY0dhDeek9rE4P6qUyAVJglIkm9xKLmAYqyFYauZEh46C8WEDdfGX7gZdayPEORLJ9ceP6c0BwJhQ52G7Fy522N2K5VuBkwNmKkXCusoSsf48JRLBaqVwR/BNsKP7MK1L/uhLaaEJ7K0TwBtuRWErVjmxviCCJ3tybEQ8wCwUWFtGJH7BfhDqb//TKKpLbnlZEWMfpHmQGOBMxhyRgXrxroyi/xAU3tIYhru8f0cfs64xTE79+5D5tJvCY4Hi/dA0z+g5gjECdmW9dbnufPs1K+5kCehu+PdIvdvtT6bOv1EcigtY2e4Rju4Yf7xVjQT625Ra4JVCpFh079diKGUGDSaklphxEsfSScnhZmA/9hUN1sKz897Fw86QEIiQvC8fUm7BvxGD5hdlTA07EKOda9a9YzLnILBBMRMZtifhQsGBfiedR0IxRlg2fFmNR224KZNeu5PGtgBbz6F51zZpB378vaVtYRi2qVH6PRwHRJuFd5CEfIJzYoMs3NXqUe0Ao41TFfZSgM9rUN/OB8KWai+Q==", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d2fe7324-f033-43a9-2c38-08d84cd627cd", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6610.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "30 Aug 2020 11:16:34.9513 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n KXnkkDqUliBXHQ9cwSZnlmahGgMOe4EKlWOfFgphioxIDNQWmYoDgJllJgAcrbOp+dyG2aKWkXOo7LAxoF20jg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR0502MB3762", "Subject": "[dpdk-dev] [PATCH 12/13] app/flow-perf: add icmp matching support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Start support matching on icmpv4 and icmpv6.\n\nUsage:\n--icmpv4: add icmp item to match on.\n--icmpv6: add icmpv6 item to match on.\n\nSigned-off-by: Wisam Jaddo <wisamm@mellanox.com>\nAcked-by: Alexander Kozyrev <akozyrev@nvidia.com>\n---\n app/test-flow-perf/items_gen.c | 41 +++++++++++++++++++++++++-\n app/test-flow-perf/main.c | 16 ++++++++++\n doc/guides/rel_notes/release_20_08.rst | 2 ++\n doc/guides/tools/flow-perf.rst | 6 ++++\n 4 files changed, 64 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-flow-perf/items_gen.c b/app/test-flow-perf/items_gen.c\nindex 8277ac70da..2b1ab41467 100644\n--- a/app/test-flow-perf/items_gen.c\n+++ b/app/test-flow-perf/items_gen.c\n@@ -310,6 +310,38 @@ add_meta_tag(struct rte_flow_item *items,\n \titems[items_counter].mask = &tag_mask;\n }\n \n+static void\n+add_icmpv4(struct rte_flow_item *items,\n+\tuint8_t items_counter,\n+\t__rte_unused struct additional_para para)\n+{\n+\tstatic struct rte_flow_item_icmp icmpv4_spec;\n+\tstatic struct rte_flow_item_icmp icmpv4_mask;\n+\n+\tmemset(&icmpv4_spec, 0, sizeof(struct rte_flow_item_icmp));\n+\tmemset(&icmpv4_mask, 0, sizeof(struct rte_flow_item_icmp));\n+\n+\titems[items_counter].type = RTE_FLOW_ITEM_TYPE_ICMP;\n+\titems[items_counter].spec = &icmpv4_spec;\n+\titems[items_counter].mask = &icmpv4_mask;\n+}\n+\n+static void\n+add_icmpv6(struct rte_flow_item *items,\n+\tuint8_t items_counter,\n+\t__rte_unused struct additional_para para)\n+{\n+\tstatic struct rte_flow_item_icmp6 icmpv6_spec;\n+\tstatic struct rte_flow_item_icmp6 icmpv6_mask;\n+\n+\tmemset(&icmpv6_spec, 0, sizeof(struct rte_flow_item_icmp6));\n+\tmemset(&icmpv6_mask, 0, sizeof(struct rte_flow_item_icmp6));\n+\n+\titems[items_counter].type = RTE_FLOW_ITEM_TYPE_ICMP6;\n+\titems[items_counter].spec = &icmpv6_spec;\n+\titems[items_counter].mask = &icmpv6_mask;\n+}\n+\n void\n fill_items(struct rte_flow_item *items,\n \tuint64_t *flow_items, uint32_t outer_ip_src)\n@@ -381,7 +413,14 @@ fill_items(struct rte_flow_item *items,\n \t\t\t.mask = RTE_FLOW_ITEM_TYPE_GTP,\n \t\t\t.funct = add_gtp,\n \t\t},\n-\n+\t\t{\n+\t\t\t.mask = RTE_FLOW_ITEM_TYPE_ICMP,\n+\t\t\t.funct = add_icmpv4,\n+\t\t},\n+\t\t{\n+\t\t\t.mask = RTE_FLOW_ITEM_TYPE_ICMP6,\n+\t\t\t.funct = add_icmpv6,\n+\t\t},\n \t};\n \n \tfor (j = 0; j < MAX_ITEMS_NUM; j++) {\ndiff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex 18199c6e2e..c420da6a57 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -130,6 +130,8 @@ usage(char *progname)\n \tprintf(\" --gtp: add gtp layer in flow items\\n\");\n \tprintf(\" --meta: add meta layer in flow items\\n\");\n \tprintf(\" --tag: add tag layer in flow items\\n\");\n+\tprintf(\" --icmpv4: add icmpv4 layer in flow items\\n\");\n+\tprintf(\" --icmpv6: add icmpv6 layer in flow items\\n\");\n \n \tprintf(\"To set flow actions:\\n\");\n \tprintf(\" --port-id: add port-id action in flow actions\\n\");\n@@ -284,6 +286,18 @@ args_parse(int argc, char **argv)\n \t\t\t.map = &flow_items[0],\n \t\t\t.map_idx = &items_idx\n \t\t},\n+\t\t{\n+\t\t\t.str = \"icmpv4\",\n+\t\t\t.mask = FLOW_ITEM_MASK(RTE_FLOW_ITEM_TYPE_ICMP),\n+\t\t\t.map = &flow_items[0],\n+\t\t\t.map_idx = &items_idx\n+\t\t},\n+\t\t{\n+\t\t\t.str = \"icmpv6\",\n+\t\t\t.mask = FLOW_ITEM_MASK(RTE_FLOW_ITEM_TYPE_ICMP6),\n+\t\t\t.map = &flow_items[0],\n+\t\t\t.map_idx = &items_idx\n+\t\t},\n \t\t{\n \t\t\t.str = \"ingress\",\n \t\t\t.mask = INGRESS,\n@@ -538,6 +552,8 @@ args_parse(int argc, char **argv)\n \t\t{ \"gtp\", 0, 0, 0 },\n \t\t{ \"meta\", 0, 0, 0 },\n \t\t{ \"tag\", 0, 0, 0 },\n+\t\t{ \"icmpv4\", 0, 0, 0 },\n+\t\t{ \"icmpv6\", 0, 0, 0 },\n \t\t/* Actions */\n \t\t{ \"port-id\", 0, 0, 0 },\n \t\t{ \"rss\", 0, 0, 0 },\ndiff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst\nindex b21f0bfb03..03eb4948e0 100644\n--- a/doc/guides/rel_notes/release_20_08.rst\n+++ b/doc/guides/rel_notes/release_20_08.rst\n@@ -287,6 +287,8 @@ New Features\n * Add new option to set portmask for insertion/deletion:\n ``--portmask=N`` Where N represent the hexadecimal\n bitmask of ports used.\n+ * Start supporting icmp and icmp6 matching items.\n+\n \n Removed Items\n -------------\ndiff --git a/doc/guides/tools/flow-perf.rst b/doc/guides/tools/flow-perf.rst\nindex bbefc978c6..7e5dc0c54b 100644\n--- a/doc/guides/tools/flow-perf.rst\n+++ b/doc/guides/tools/flow-perf.rst\n@@ -175,6 +175,12 @@ Items:\n \tunder ``TAG_INDEX`` with full mask, default value = 0.\n \tOther fields are open mask.\n \n+*\t``--icmpv4``\n+\tAdd icmpv4 item to all flows items, This item have open mask.\n+\n+*\t``--icmpv6``\n+\tAdd icmpv6 item to all flows items, This item have open mask.\n+\n \n Actions:\n \n", "prefixes": [ "12/13" ] }