Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76156/?format=api
{ "id": 76156, "url": "http://patches.dpdk.org/api/patches/76156/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200830111544.4190-7-wisamm@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200830111544.4190-7-wisamm@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200830111544.4190-7-wisamm@mellanox.com", "date": "2020-08-30T11:15:37", "name": "[06/13] app/flow-perf: fix memory leak from RSS action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d922a96866bb3f781ffdc97d817b41160d1100e8", "submitter": { "id": 938, "url": "http://patches.dpdk.org/api/people/938/?format=api", "name": "Wisam Jaddo", "email": "wisamm@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200830111544.4190-7-wisamm@mellanox.com/mbox/", "series": [ { "id": 11848, "url": "http://patches.dpdk.org/api/series/11848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11848", "date": "2020-08-30T11:15:31", "name": "app/flow-perf: add support for new items/actions", "version": 1, "mbox": "http://patches.dpdk.org/series/11848/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76156/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76156/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3670A04AB;\n\tSun, 30 Aug 2020 13:21:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EB6861C0D2;\n\tSun, 30 Aug 2020 13:16:33 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n (mail-eopbgr00041.outbound.protection.outlook.com [40.107.0.41])\n by dpdk.org (Postfix) with ESMTP id 788B11C0BC\n for <dev@dpdk.org>; Sun, 30 Aug 2020 13:16:29 +0200 (CEST)", "from AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18)\n by AM0PR0502MB3762.eurprd05.prod.outlook.com (2603:10a6:208:1b::31)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.21; Sun, 30 Aug\n 2020 11:16:28 +0000", "from AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::4c8a:9848:2e2a:3598]) by AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::4c8a:9848:2e2a:3598%6]) with mapi id 15.20.3326.025; Sun, 30 Aug 2020\n 11:16:28 +0000", "from mellanox.com (37.142.13.130) by\n AM4PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:205::21) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3326.19 via Frontend Transport; Sun, 30 Aug 2020 11:16:27 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=H9Q14eTjZl321YAHou5zW7JbQr3gzfWZFM2dIK/6lCR/YI6BcEY2/9eB9IeCskwIQPsAbYT5kKrqPJe9lrr6+HqbOMoE5YQhyKjQDtVO72cWHeBtyEGrjMOHSJkkX2Ir1hbnZnMPz8SK/JHWwsEkJNBrrXQyLgrIPMjjW5HhE9zMSFzPqZmxNYtvKD8V1P3+ee0i0zVemn9F/kgKrzHyPImSC2N3PxRjz3gF9s7u8g9CPMRitHVJ14960vsyf7oSrV3NQFkAJbhyvPx4JnU9Sab8bbclBXUAxntiugX8fnGiJS/crFMiDpO4aMgk0Gn7g774JZU2QHpRX9rDG2fRew==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RC22mkX0dn4vr5hto5VQHflb95cJLHLvNOIoFB1FUUE=;\n b=kqDn5z85YT9WfJRHfsyHsZuehWrbKxcG/jXDwp9GrtYDIhxh4JMKO2bCsyE06eeGkJoiirV91k2TRxSY4dXH4epxJkLZfR/TViHWSlYqGvYXb/2nWXqGSCt3+4do8rVwQQfsp1iXRFUFwIAb/8i2IDZhdGOvWNt4BrdSkdBS5vLGZty93CNq9dWCeUe6UBcw8pm6zjIRmXmhOuT6YXB1f/yTEj9AHOgKvhc/AGBKpUOhy45iD3BYFyDBMSNsQHyGQZFdFaa6hUhckGV2kNrdn2IqanX3iuMR7f9J7yFcnPcd4Kk6eCoXMDpBAkmD/JmQjJ7ZIsgXgKQ1TV6e68RDsQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RC22mkX0dn4vr5hto5VQHflb95cJLHLvNOIoFB1FUUE=;\n b=U8vA6pMwVE2hnh5Iw/nKMr0QovEDk2Olp6MQzgCGZA9mIOaqmHiitwQTvg8HhUzYARuhx3k84QC1R0N75UpCz/MU6PKCMxZLjz0SPCMlSzz8MSbCQpkTLgupzTark3yq+37flHk7wYb45OeOiIdHUXSq1D7IJ48UETOja22z7+Q=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Wisam Jaddo <wisamm@mellanox.com>", "To": "dev@dpdk.org, thomas@monjalon.net, asafp@mellanox.com,\n akozyrev@nvidia.com,\n akozyrev@mellanox.com, arybchenko@solarflare.com, jackmin@mellanox.com", "Cc": "wisamm@mellanox.com", "Date": "Sun, 30 Aug 2020 11:15:37 +0000", "Message-Id": "<20200830111544.4190-7-wisamm@mellanox.com>", "X-Mailer": [ "git-send-email 2.17.1", "git-send-email 2.17.1" ], "In-Reply-To": "<20200830111544.4190-1-wisamm@mellanox.com>", "References": "<20200830111544.4190-1-wisamm@mellanox.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM4PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:205::21)\n To AM0PR05MB6610.eurprd05.prod.outlook.com\n (2603:10a6:208:12f::18)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "6a75f377-04a2-4be2-4994-08d84cd623d6", "X-MS-TrafficTypeDiagnostic": "AM0PR0502MB3762:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR0502MB3762FC0AAB7F406E90CA853EA9500@AM0PR0502MB3762.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:2043;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 2mwE7G8RSC0Nhr0ZwmZ5G8BGOZF8osXWxy2gW5gBKuauuF/ejBQi4Qs5cLhqOBocBchrTRGWOQM6mBow4mzj+k9v0c5JoZqRjy9XrapQx08SmTLvgNpO23+ONpjMnyk08K5R7uS/yr96aeoTCgyjqxeVZnH8LHMr3YmvgV6aAZVgyl7Gb5GP8bxY4u7bkBh63XO0uGnhoqiRQwTW7Mg/55RJFMir+NwmkKpHByJJKaRPrB5HrWaxWdUiXoBBy63LVhOFigBTvfDCqpUPy2LkU2z8aV5sH2qXq0JqXC7HesLE/Oe6e/n119+fqYQh8tqyIvRexb8GRk1Jw1Lg3TAEGA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6610.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(478600001)(107886003)(316002)(5660300002)(8886007)(2906002)(6636002)(4326008)(86362001)(36756003)(6666004)(1076003)(55016002)(8936002)(26005)(2616005)(7696005)(66946007)(66556008)(52116002)(83380400001)(16526019)(8676002)(186003)(956004)(66476007);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n biK4iQ1gvlNLUnoiAOfDH8kXiqVvpGPiFjHOZqbKaqr7a8SkhEuqnOVZmHtk/1J+D/jHkABphrs7jZCQLh5RWrSRTtQ9DMyWC8MhW0kFBGz6DHImsN3gw+jrbmT15VhsCxKl/UNQiTlsiMVv+6Y9C8/K7I9PDKP/B6yZXPpiv62eD9nXMnRIEd8krOZue6xNQtCY2XTkP/I6vU5cad1qp8donBPts7RlIGBAQGm42q1zhd3J/B+n0zpO7fWfdNMRWJRDsiA4LEVKi/RtYfjpKkiQAPI4cRrbwA5Ab8eiTZKAVtWPWPiRW8FlReBwykaCnAOf52dbtF2B4qsEl+IkZ38GgNcYPVsgkiDipitcg0StUcbq2eI3QutjAQiJUMEnR5bYj8O5aijLvmjn9WX84VLFQ477UL8bwINqwjUP/wbiY/c4G961E83ev68Mz/dk+fR3CgcBT3hnnXT67+EpXMVDUHmgKaSgheyVRb4TSxx4QVGa97diS6DyW4wRQWDe9qJFE0yubVeJ7jecnsPrd4Zb8Xvnvra2Eza0fBdyMAPZMk43fWOhsycNzL8rsucyFNGRdgObBriyMVyVw/uiCsM69j9ZNLrtR8H5mjUzFOebpCQ8/ip/sW8Zzg5QxeOXLZ3RSMzVW7YIcyAnFdGLKw==", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6a75f377-04a2-4be2-4994-08d84cd623d6", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6610.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "30 Aug 2020 11:16:28.3112 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n bnk/9FOACssmXR5ZmSnSoJdZkLQgz3QgXJzkpFKbfyWXcYWYNTPKalstX/ILu5BLArQTfSGGHuCtjPsaXcKbIw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR0502MB3762", "Subject": "[dpdk-dev] [PATCH 06/13] app/flow-perf: fix memory leak from RSS\n\taction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, each call for add_rss_action will allocate\nextra memory for rss_data, which will reflect bad results\non memory consumption for all flows, and will leads into\nmemory leak.\n\nIn this fix, it will check if it's allocated before\nreallocating it.\n\nFixes: bf3688f1e816 (\"app/flow-perf: add insertion rate calculation\")\nCc: wisamm@mellanox.com\n\nSigned-off-by: Wisam Jaddo <wisamm@mellanox.com>\nAcked-by: Alexander Kozyrev <akozyrev@nvidia.com>\n---\n app/test-flow-perf/actions_gen.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-flow-perf/actions_gen.c b/app/test-flow-perf/actions_gen.c\nindex 9fe11abc94..99e47bf786 100644\n--- a/app/test-flow-perf/actions_gen.c\n+++ b/app/test-flow-perf/actions_gen.c\n@@ -86,8 +86,9 @@ add_rss(struct rte_flow_action *actions,\n \n \tuint16_t queue;\n \n-\trss_data = rte_malloc(\"rss_data\",\n-\t\tsizeof(struct action_rss_data), 0);\n+\tif (rss_data == NULL)\n+\t\trss_data = rte_malloc(\"rss_data\",\n+\t\t\tsizeof(struct action_rss_data), 0);\n \n \tif (rss_data == NULL)\n \t\trte_exit(EXIT_FAILURE, \"No Memory available!\");\n", "prefixes": [ "06/13" ] }