Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76123/?format=api
{ "id": 76123, "url": "http://patches.dpdk.org/api/patches/76123/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200828050112.19482-7-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200828050112.19482-7-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200828050112.19482-7-kalesh-anakkur.purayil@broadcom.com", "date": "2020-08-28T05:01:12", "name": "[6/6] net/bnxt: fix speed setting on BCM957508-N2100 adapters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7531b4698ea2faa3b32372280f3ecc8925b6603b", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200828050112.19482-7-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 11835, "url": "http://patches.dpdk.org/api/series/11835/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11835", "date": "2020-08-28T05:01:06", "name": "bnxt bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/11835/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76123/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/76123/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62CE3A04B1;\n\tFri, 28 Aug 2020 06:47:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C31FE1C0C2;\n\tFri, 28 Aug 2020 06:46:25 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id C6C8A1B951\n for <dev@dpdk.org>; Fri, 28 Aug 2020 06:46:17 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 9554F29D66B;\n Thu, 27 Aug 2020 21:46:16 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 9554F29D66B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1598589976;\n bh=D6QC33I9JtBtwB7csEUIdO7BlR3RSCN9Fp7deVpwMUA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=itkLEczwvEnwXlVS6iDF7DmgW987wowXXsl5Cmf5MDCU0do3/8tqQj2xZ4AXCQ6lp\n 02aUkLryUlNb6h0brR7skKx+aeo8sUXmVcPmV7HlE5vJun6f1INXIG9sC8S/DAPjYy\n olrmi6NzupElG/WdGwswOjpD8J89Bc6nDwjiBy48=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Fri, 28 Aug 2020 10:31:12 +0530", "Message-Id": "<20200828050112.19482-7-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200828050112.19482-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200828050112.19482-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 6/6] net/bnxt: fix speed setting on\n\tBCM957508-N2100 adapters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nOn BCM957508-N2100 adapters, FW will not allow any user other\nthan BMC to shutdown the port. As a result, bnxt_get_hwrm_link_config()\nalways returns link up.\n\nBecause of this, driver will not update the new port configurations\nsuch as speed, autoneg during a port start.\n\nFixed the condition to invoke bnxt_set_hwrm_link_config() in\nbnxt_init_chip().\n\nFixes: 7bc8e9a227cc (\"net/bnxt: support async link notification\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 4 ++++\n drivers/net/bnxt/bnxt_ethdev.c | 44 ++++++++++++++++++++++++++++--------------\n 2 files changed, 33 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex f4b2a3f..a38fe8c 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -81,6 +81,10 @@\n #define BROADCOM_DEV_ID_58808\t\t0x16f0\n #define BROADCOM_DEV_ID_58802_VF\t0xd800\n \n+#define BROADCOM_DEV_957508_N2100\t0x5208\n+#define IS_BNXT_DEV_957508_N2100(bp)\t\\\n+\t((bp)->pdev->id.subsystem_device_id == BROADCOM_DEV_957508_N2100)\n+\n #define BNXT_MAX_MTU\t\t9574\n #define VLAN_TAG_SIZE\t\t4\n #define BNXT_NUM_VLANS\t\t2\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 510a0d9..0a038d4 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -605,9 +605,35 @@ static int bnxt_init_ctx_mem(struct bnxt *bp)\n \treturn rc;\n }\n \n-static int bnxt_init_chip(struct bnxt *bp)\n+static int bnxt_update_phy_setting(struct bnxt *bp)\n {\n \tstruct rte_eth_link new;\n+\tint rc;\n+\n+\trc = bnxt_get_hwrm_link_config(bp, &new);\n+\tif (rc) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to get link settings\\n\");\n+\t\treturn rc;\n+\t}\n+\n+\t/*\n+\t * On BCM957508-N2100 adapters, FW will not allow any user other\n+\t * than BMC to shutdown the port. bnxt_get_hwrm_link_config() call\n+\t * always returns link up. Force phy update always in that case.\n+\t */\n+\tif (!new.link_status || IS_BNXT_DEV_957508_N2100(bp)) {\n+\t\trc = bnxt_set_hwrm_link_config(bp, true);\n+\t\tif (rc) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to update PHY settings\\n\");\n+\t\t\treturn rc;\n+\t\t}\n+\t}\n+\n+\treturn rc;\n+}\n+\n+static int bnxt_init_chip(struct bnxt *bp)\n+{\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(bp->eth_dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tuint32_t intr_vector = 0;\n@@ -737,21 +763,9 @@ static int bnxt_init_chip(struct bnxt *bp)\n \t\tgoto err_free;\n #endif\n \n-\trc = bnxt_get_hwrm_link_config(bp, &new);\n-\tif (rc) {\n-\t\tPMD_DRV_LOG(ERR, \"HWRM Get link config failure rc: %x\\n\", rc);\n+\trc = bnxt_update_phy_setting(bp);\n+\tif (rc)\n \t\tgoto err_free;\n-\t}\n-\n-\tif (!bp->link_info->link_up) {\n-\t\trc = bnxt_set_hwrm_link_config(bp, true);\n-\t\tif (rc) {\n-\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\"HWRM link config failure rc: %x\\n\", rc);\n-\t\t\tgoto err_free;\n-\t\t}\n-\t}\n-\tbnxt_print_link_info(bp->eth_dev);\n \n \tbp->mark_table = rte_zmalloc(\"bnxt_mark_table\", BNXT_MARK_TABLE_SZ, 0);\n \tif (!bp->mark_table)\n", "prefixes": [ "6/6" ] }