Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76121/?format=api
{ "id": 76121, "url": "http://patches.dpdk.org/api/patches/76121/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200828050112.19482-5-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200828050112.19482-5-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200828050112.19482-5-kalesh-anakkur.purayil@broadcom.com", "date": "2020-08-28T05:01:10", "name": "[4/6] net/bnxt: fix a possible segfault in vector mode Tx path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "85cb2bdab6592cc54ee831cfa66792e71fced7e7", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200828050112.19482-5-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 11835, "url": "http://patches.dpdk.org/api/series/11835/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11835", "date": "2020-08-28T05:01:06", "name": "bnxt bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/11835/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76121/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76121/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD7BDA04B1;\n\tFri, 28 Aug 2020 06:46:51 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D3D31C0B5;\n\tFri, 28 Aug 2020 06:46:23 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id 154781B951\n for <dev@dpdk.org>; Fri, 28 Aug 2020 06:46:17 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id D585E29D667;\n Thu, 27 Aug 2020 21:46:15 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com D585E29D667", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1598589976;\n bh=HifoKGeWH5gdaqvCmBbcvaFpitSxLG/hFEir2u/wobg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=D6qNnSWGyvg5ObjiiJ+lDISxvA40IEy4RMGgSBd7VxRMpIR+EHZx7hjksfoEEz/7Y\n l+t1ID/dasGIr3eBV34N8nk/nAlVzt2mGHN2QZMvXWP2ruvmbxS0DCheEHVRv6Zb0V\n Y0D7H+r2h8UQYraIjD8JVsfeG7AmiFNUmpZxJ9Zk=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Fri, 28 Aug 2020 10:31:10 +0530", "Message-Id": "<20200828050112.19482-5-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200828050112.19482-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200828050112.19482-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 4/6] net/bnxt: fix a possible segfault in vector\n\tmode Tx path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nrte_pktmbuf_prefree_seg() can return NULL if the mbuf still\nhas remaining references on it.\n\nAdding a NULL check to prevent segfault.\n\nFixes: bc4a000f2f53 (\"net/bnxt: implement SSE vector mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 2 ++\n drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 ++\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\nindex 488a0b4..bf76c2a 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\n@@ -329,6 +329,8 @@ bnxt_tx_cmp_vec(struct bnxt_tx_queue *txq, int nr_pkts)\n \t\ttx_buf = &txr->tx_buf_ring[cons];\n \t\tcons = RING_NEXT(txr->tx_ring_struct, cons);\n \t\tmbuf = rte_pktmbuf_prefree_seg(tx_buf->mbuf);\n+\t\tif (unlikely(mbuf == NULL))\n+\t\t\tcontinue;\n \t\ttx_buf->mbuf = NULL;\n \n \t\tif (blk && mbuf->pool != free[0]->pool) {\ndiff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\nindex c4ca5cf..98220bc 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n@@ -334,6 +334,8 @@ bnxt_tx_cmp_vec(struct bnxt_tx_queue *txq, int nr_pkts)\n \t\ttx_buf = &txr->tx_buf_ring[cons];\n \t\tcons = RING_NEXT(txr->tx_ring_struct, cons);\n \t\tmbuf = rte_pktmbuf_prefree_seg(tx_buf->mbuf);\n+\t\tif (unlikely(mbuf == NULL))\n+\t\t\tcontinue;\n \t\ttx_buf->mbuf = NULL;\n \n \t\tif (blk && mbuf->pool != free[0]->pool) {\n", "prefixes": [ "4/6" ] }