Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76112/?format=api
{ "id": 76112, "url": "http://patches.dpdk.org/api/patches/76112/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200827161304.32300-17-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200827161304.32300-17-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200827161304.32300-17-ciara.power@intel.com", "date": "2020-08-27T16:13:03", "name": "[v2,16/17] efd: add checks for max SIMD bitwidth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7489e83a9380928bd94e5035724b6557c324fa71", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200827161304.32300-17-ciara.power@intel.com/mbox/", "series": [ { "id": 11831, "url": "http://patches.dpdk.org/api/series/11831/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11831", "date": "2020-08-27T16:12:47", "name": "add max SIMD bitwidth to EAL", "version": 2, "mbox": "http://patches.dpdk.org/series/11831/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76112/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76112/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7B282A04B1;\n\tThu, 27 Aug 2020 18:16:24 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 188991C192;\n\tThu, 27 Aug 2020 18:14:00 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 6BB7C1C0B0\n for <dev@dpdk.org>; Thu, 27 Aug 2020 18:13:43 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Aug 2020 09:13:40 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga007.fm.intel.com with ESMTP; 27 Aug 2020 09:13:39 -0700" ], "IronPort-SDR": [ "\n +KqGqj3XHPuEMyPipIGb5Utr8Xi/ErYK5Ln+L44TSFwkMkpCKBbsQSGkYaK8XIc/docuNxPzww\n SuL4MKy2EW1Q==", "\n 2z+PgT1K401wMVKnwYiwnwwMUjE8KwriRmlaFnFVcysoqjev/bgJz+lp3AJZAktz94VGcrwHO8\n OHXAXapTCsQg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9726\"; a=\"220767057\"", "E=Sophos;i=\"5.76,360,1592895600\"; d=\"scan'208\";a=\"220767057\"", "E=Sophos;i=\"5.76,360,1592895600\"; d=\"scan'208\";a=\"280681621\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Power <ciara.power@intel.com>,\n Byron Marohn <byron.marohn@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>", "Date": "Thu, 27 Aug 2020 17:13:03 +0100", "Message-Id": "<20200827161304.32300-17-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200827161304.32300-1-ciara.power@intel.com>", "References": "<20200807155859.63888-1-ciara.power@intel.com>\n <20200827161304.32300-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 16/17] efd: add checks for max SIMD bitwidth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When choosing a vector path to take, an extra condition must be\nsatisfied to ensure the max SIMD bitwidth allows for the CPU enabled\npath.\n\nCc: Byron Marohn <byron.marohn@intel.com>\nCc: Yipeng Wang <yipeng1.wang@intel.com>\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n lib/librte_efd/rte_efd.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c\nindex 6a799556d4..509ecc8256 100644\n--- a/lib/librte_efd/rte_efd.c\n+++ b/lib/librte_efd/rte_efd.c\n@@ -645,7 +645,9 @@ rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,\n \t * For less than 4 bits, scalar function performs better\n \t * than vectorised version\n \t */\n-\tif (RTE_EFD_VALUE_NUM_BITS > 3 && rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2))\n+\tif (RTE_EFD_VALUE_NUM_BITS > 3\n+\t\t\t&& rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)\n+\t\t\t&& rte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)\n \t\ttable->lookup_fn = EFD_LOOKUP_AVX2;\n \telse\n #endif\n@@ -655,7 +657,8 @@ rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,\n \t * than vectorised version\n \t */\n \tif (RTE_EFD_VALUE_NUM_BITS > 16 &&\n-\t rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON))\n+\t rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON) &&\n+\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_128_SIMD)\n \t\ttable->lookup_fn = EFD_LOOKUP_NEON;\n \telse\n #endif\n", "prefixes": [ "v2", "16/17" ] }