Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76105/?format=api
{ "id": 76105, "url": "http://patches.dpdk.org/api/patches/76105/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200827161304.32300-10-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200827161304.32300-10-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200827161304.32300-10-ciara.power@intel.com", "date": "2020-08-27T16:12:56", "name": "[v2,09/17] net/iavf: add checks for max SIMD bitwidth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "58b57c75abacea4750006576f934201827d75258", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200827161304.32300-10-ciara.power@intel.com/mbox/", "series": [ { "id": 11831, "url": "http://patches.dpdk.org/api/series/11831/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11831", "date": "2020-08-27T16:12:47", "name": "add max SIMD bitwidth to EAL", "version": 2, "mbox": "http://patches.dpdk.org/series/11831/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76105/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76105/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1286AA04B1;\n\tThu, 27 Aug 2020 18:15:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2DE981C10C;\n\tThu, 27 Aug 2020 18:13:51 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id A8BC51C08C\n for <dev@dpdk.org>; Thu, 27 Aug 2020 18:13:40 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Aug 2020 09:13:28 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga007.fm.intel.com with ESMTP; 27 Aug 2020 09:13:27 -0700" ], "IronPort-SDR": [ "\n RpsqJqDOMISqR2vCh4w8QXCJ+eZsQqxMaIfRoC3J7tRzpIIIr+/DG+ktrDYjTovBlwuD9bSpuw\n Dacn74jx1i5g==", "\n IZs+ucnv+imOBAdsBH7HIZH5FfZPLQvwiYGg+EjKssho2sT/0rjHArdcWCus9VZFf8ua2wuQOz\n H7Wpz9hNrUbA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9726\"; a=\"220767025\"", "E=Sophos;i=\"5.76,360,1592895600\"; d=\"scan'208\";a=\"220767025\"", "E=Sophos;i=\"5.76,360,1592895600\"; d=\"scan'208\";a=\"280681518\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Power <ciara.power@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Beilei Xing <beilei.xing@intel.com>", "Date": "Thu, 27 Aug 2020 17:12:56 +0100", "Message-Id": "<20200827161304.32300-10-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200827161304.32300-1-ciara.power@intel.com>", "References": "<20200807155859.63888-1-ciara.power@intel.com>\n <20200827161304.32300-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 09/17] net/iavf: add checks for max SIMD\n\tbitwidth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When choosing a vector path to take, an extra condition must be\nsatisfied to ensure the max SIMD bitwidth allows for the CPU enabled\npath.\n\nCc: Jingjing Wu <jingjing.wu@intel.com>\nCc: Beilei Xing <beilei.xing@intel.com>\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n drivers/net/iavf/iavf_rxtx.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex 05a7dd898a..b798d082a2 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -2105,14 +2105,16 @@ iavf_set_rx_function(struct rte_eth_dev *dev)\n \tint i;\n \tbool use_avx2 = false;\n \n-\tif (!iavf_rx_vec_dev_check(dev)) {\n+\tif (!iavf_rx_vec_dev_check(dev) &&\n+\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_128_SIMD) {\n \t\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\t\trxq = dev->data->rx_queues[i];\n \t\t\t(void)iavf_rxq_vec_setup(rxq);\n \t\t}\n \n-\t\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||\n-\t\t rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1)\n+\t\tif ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||\n+\t\t rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&\n+\t\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)\n \t\t\tuse_avx2 = true;\n \n \t\tif (dev->data->scattered_rx) {\n@@ -2178,7 +2180,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev)\n \tint i;\n \tbool use_avx2 = false;\n \n-\tif (!iavf_tx_vec_dev_check(dev)) {\n+\tif (!iavf_tx_vec_dev_check(dev) &&\n+\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_128_SIMD) {\n \t\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n \t\t\ttxq = dev->data->tx_queues[i];\n \t\t\tif (!txq)\n@@ -2186,8 +2189,9 @@ iavf_set_tx_function(struct rte_eth_dev *dev)\n \t\t\tiavf_txq_vec_setup(txq);\n \t\t}\n \n-\t\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||\n-\t\t rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1)\n+\t\tif ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||\n+\t\t rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&\n+\t\t\t\trte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)\n \t\t\tuse_avx2 = true;\n \n \t\tPMD_DRV_LOG(DEBUG, \"Using %sVector Tx (port %d).\",\n", "prefixes": [ "v2", "09/17" ] }