Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76097/?format=api
http://patches.dpdk.org/api/patches/76097/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200827161304.32300-2-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200827161304.32300-2-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200827161304.32300-2-ciara.power@intel.com", "date": "2020-08-27T16:12:48", "name": "[v2,01/17] eal: add max SIMD bitwidth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dcdab411d378eff4c0838add85de5bc2ccc51b95", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200827161304.32300-2-ciara.power@intel.com/mbox/", "series": [ { "id": 11831, "url": "http://patches.dpdk.org/api/series/11831/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11831", "date": "2020-08-27T16:12:47", "name": "add max SIMD bitwidth to EAL", "version": 2, "mbox": "http://patches.dpdk.org/series/11831/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76097/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76097/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CFC34A04B1;\n\tThu, 27 Aug 2020 18:13:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B0FBE1BEC3;\n\tThu, 27 Aug 2020 18:13:36 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 134F61BEC3\n for <dev@dpdk.org>; Thu, 27 Aug 2020 18:13:34 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Aug 2020 09:13:15 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga007.fm.intel.com with ESMTP; 27 Aug 2020 09:13:14 -0700" ], "IronPort-SDR": [ "\n 0SKRy4zdMeAxKmhKfVImDs357q89H2RkWSXs8HE0cUXoh69Ej2TBqzUDq9ARlZd3/MLSVAP7yp\n d9brXP91ryNA==", "\n 5mL/rimbV4eHonS9TzTFMGprG1UBjV+XX81d6Xv4jSFwxg824Qcf4p82sIDWMLV9AIvUpQDP1a\n 3ksS7iL9sGSA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9726\"; a=\"220766981\"", "E=Sophos;i=\"5.76,360,1592895600\"; d=\"scan'208\";a=\"220766981\"", "E=Sophos;i=\"5.76,360,1592895600\"; d=\"scan'208\";a=\"280681407\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Power <ciara.power@intel.com>, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>", "Date": "Thu, 27 Aug 2020 17:12:48 +0100", "Message-Id": "<20200827161304.32300-2-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200827161304.32300-1-ciara.power@intel.com>", "References": "<20200807155859.63888-1-ciara.power@intel.com>\n <20200827161304.32300-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 01/17] eal: add max SIMD bitwidth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds a max SIMD bitwidth EAL configuration. The API allows\nfor an app to set this value. It can also be set using EAL argument\n--force-max-simd-bitwidth, which will lock the value and override any\nmodifications made by the app.\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n\n---\nv2: Added to Doxygen comment for API.\n---\n lib/librte_eal/common/eal_common_options.c | 60 ++++++++++++++++++++++\n lib/librte_eal/common/eal_internal_cfg.h | 8 +++\n lib/librte_eal/common/eal_options.h | 2 +\n lib/librte_eal/include/rte_eal.h | 32 ++++++++++++\n lib/librte_eal/rte_eal_version.map | 4 ++\n 5 files changed, 106 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex a5426e1234..90f4e8f5c3 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -102,6 +102,7 @@ eal_long_options[] = {\n \t{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},\n \t{OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM },\n \t{OPT_NO_TELEMETRY, 0, NULL, OPT_NO_TELEMETRY_NUM },\n+\t{OPT_FORCE_MAX_SIMD_BITWIDTH, 1, NULL, OPT_FORCE_MAX_SIMD_BITWIDTH_NUM},\n \t{0, 0, NULL, 0 }\n };\n \n@@ -1309,6 +1310,32 @@ eal_parse_iova_mode(const char *name)\n \treturn 0;\n }\n \n+static int\n+eal_parse_simd_bitwidth(const char *arg, bool locked)\n+{\n+\tchar *end;\n+\tuint16_t bitwidth;\n+\tint ret;\n+\tstruct internal_config *internal_conf =\n+\t\teal_get_internal_configuration();\n+\n+\tif (arg == NULL || arg[0] == '\\0')\n+\t\treturn -1;\n+\n+\terrno = 0;\n+\tbitwidth = strtoul(arg, &end, 0);\n+\n+\t/* check for errors */\n+\tif ((errno != 0) || end == NULL || (*end != '\\0'))\n+\t\treturn -1;\n+\n+\tret = rte_set_max_simd_bitwidth(bitwidth);\n+\tif (ret < 0)\n+\t\treturn -1;\n+\tinternal_conf->max_simd_bitwidth.locked = locked;\n+\treturn 0;\n+}\n+\n static int\n eal_parse_base_virtaddr(const char *arg)\n {\n@@ -1707,6 +1734,13 @@ eal_parse_common_option(int opt, const char *optarg,\n \tcase OPT_NO_TELEMETRY_NUM:\n \t\tconf->no_telemetry = 1;\n \t\tbreak;\n+\tcase OPT_FORCE_MAX_SIMD_BITWIDTH_NUM:\n+\t\tif (eal_parse_simd_bitwidth(optarg, 1) < 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"invalid parameter for --\"\n+\t\t\t\t\tOPT_FORCE_MAX_SIMD_BITWIDTH \"\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tbreak;\n \n \t/* don't know what to do, leave this to caller */\n \tdefault:\n@@ -1903,6 +1937,31 @@ eal_check_common_options(struct internal_config *internal_cfg)\n \treturn 0;\n }\n \n+uint16_t\n+rte_get_max_simd_bitwidth(void)\n+{\n+\tconst struct internal_config *internal_conf =\n+\t\teal_get_internal_configuration();\n+\treturn internal_conf->max_simd_bitwidth.bitwidth;\n+}\n+\n+int\n+rte_set_max_simd_bitwidth(uint16_t bitwidth)\n+{\n+\tstruct internal_config *internal_conf =\n+\t\teal_get_internal_configuration();\n+\tif (internal_conf->max_simd_bitwidth.locked) {\n+\t\tRTE_LOG(NOTICE, EAL, \"Cannot set max SIMD bitwidth - user runtime override enabled\");\n+\t\treturn -EPERM;\n+\t}\n+\tif (bitwidth < RTE_NO_SIMD || !rte_is_power_of_2(bitwidth)) {\n+\t\tRTE_LOG(ERR, EAL, \"Invalid bitwidth value!\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\tinternal_conf->max_simd_bitwidth.bitwidth = bitwidth;\n+\treturn 0;\n+}\n+\n void\n eal_common_usage(void)\n {\n@@ -1981,6 +2040,7 @@ eal_common_usage(void)\n \t \" --\"OPT_BASE_VIRTADDR\" Base virtual address\\n\"\n \t \" --\"OPT_TELEMETRY\" Enable telemetry support (on by default)\\n\"\n \t \" --\"OPT_NO_TELEMETRY\" Disable telemetry support\\n\"\n+\t \" --\"OPT_FORCE_MAX_SIMD_BITWIDTH\" Force the max SIMD bitwidth\\n\"\n \t \"\\nEAL options for DEBUG use only:\\n\"\n \t \" --\"OPT_HUGE_UNLINK\" Unlink hugepage files after init\\n\"\n \t \" --\"OPT_NO_HUGE\" Use malloc instead of hugetlbfs\\n\"\ndiff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h\nindex 13f93388a7..367e0cc19e 100644\n--- a/lib/librte_eal/common/eal_internal_cfg.h\n+++ b/lib/librte_eal/common/eal_internal_cfg.h\n@@ -33,6 +33,12 @@ struct hugepage_info {\n \tint lock_descriptor; /**< file descriptor for hugepage dir */\n };\n \n+struct simd_bitwidth {\n+\t/**< flag indicating if bitwidth is locked from further modification */\n+\tbool locked;\n+\tuint16_t bitwidth; /**< bitwidth value */\n+};\n+\n /**\n * internal configuration\n */\n@@ -85,6 +91,8 @@ struct internal_config {\n \tvolatile unsigned int init_complete;\n \t/**< indicates whether EAL has completed initialization */\n \tunsigned int no_telemetry; /**< true to disable Telemetry */\n+\t/** max simd bitwidth path to use */\n+\tstruct simd_bitwidth max_simd_bitwidth;\n };\n \n void eal_reset_internal_config(struct internal_config *internal_cfg);\ndiff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h\nindex 89769d48b4..ef33979664 100644\n--- a/lib/librte_eal/common/eal_options.h\n+++ b/lib/librte_eal/common/eal_options.h\n@@ -85,6 +85,8 @@ enum {\n \tOPT_TELEMETRY_NUM,\n #define OPT_NO_TELEMETRY \"no-telemetry\"\n \tOPT_NO_TELEMETRY_NUM,\n+#define OPT_FORCE_MAX_SIMD_BITWIDTH \"force-max-simd-bitwidth\"\n+\tOPT_FORCE_MAX_SIMD_BITWIDTH_NUM,\n \tOPT_LONG_MAX_NUM\n };\n \ndiff --git a/lib/librte_eal/include/rte_eal.h b/lib/librte_eal/include/rte_eal.h\nindex ddcf6a2e7a..8148f650f2 100644\n--- a/lib/librte_eal/include/rte_eal.h\n+++ b/lib/librte_eal/include/rte_eal.h\n@@ -43,6 +43,13 @@ enum rte_proc_type_t {\n \tRTE_PROC_INVALID\n };\n \n+enum rte_max_simd_t {\n+\tRTE_NO_SIMD = 64,\n+\tRTE_MAX_128_SIMD = 128,\n+\tRTE_MAX_256_SIMD = 256,\n+\tRTE_MAX_512_SIMD = 512\n+};\n+\n /**\n * Get the process type in a multi-process setup\n *\n@@ -51,6 +58,31 @@ enum rte_proc_type_t {\n */\n enum rte_proc_type_t rte_eal_process_type(void);\n \n+/**\n+ * Get the supported SIMD bitwidth.\n+ *\n+ * @return\n+ * uint16_t bitwidth.\n+ */\n+__rte_experimental\n+uint16_t rte_get_max_simd_bitwidth(void);\n+\n+/**\n+ * Set the supported SIMD bitwidth.\n+ * This API should only be called once at initialization, before EAL init.\n+ *\n+ * @param bitwidth\n+ * uint16_t bitwidth.\n+ * @return\n+ * 0 on success.\n+ * @return\n+ * -EINVAL on invalid bitwidth parameter.\n+ * @return\n+ * -EPERM if bitwidth is locked.\n+ */\n+__rte_experimental\n+int rte_set_max_simd_bitwidth(uint16_t bitwidth);\n+\n /**\n * Request iopl privilege for all RPL.\n *\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex bf0c17c233..8059ea76b6 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -403,6 +403,10 @@ EXPERIMENTAL {\n \trte_mp_disable;\n \trte_thread_register;\n \trte_thread_unregister;\n+\n+\t# added in 20.11\n+\trte_get_max_simd_bitwidth;\n+\trte_set_max_simd_bitwidth;\n };\n \n INTERNAL {\n", "prefixes": [ "v2", "01/17" ] }{ "id": 76097, "url": "