Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76081/?format=api
{ "id": 76081, "url": "http://patches.dpdk.org/api/patches/76081/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200827101008.76906-4-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200827101008.76906-4-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200827101008.76906-4-jia.guo@intel.com", "date": "2020-08-27T10:10:06", "name": "[v2,3/5] net/ice: maximize vector rx burst for ice", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1357cc36011f2ba3beebb3055327a25b8cb76aad", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200827101008.76906-4-jia.guo@intel.com/mbox/", "series": [ { "id": 11826, "url": "http://patches.dpdk.org/api/series/11826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11826", "date": "2020-08-27T10:10:03", "name": "maximize vector rx burst for PMDs", "version": 2, "mbox": "http://patches.dpdk.org/series/11826/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76081/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76081/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3166A04B1;\n\tThu, 27 Aug 2020 12:13:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 279BC1C1A8;\n\tThu, 27 Aug 2020 12:13:20 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 65E441C1A5\n for <dev@dpdk.org>; Thu, 27 Aug 2020 12:13:18 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Aug 2020 03:13:18 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by orsmga005.jf.intel.com with ESMTP; 27 Aug 2020 03:13:14 -0700" ], "IronPort-SDR": [ "\n QCttrccPBf72OQ5rxeEGWLY/N92N4WqZYMYf5KTCLCkPLRXFH3/fn7U5H7d2brinNKFVbIvnVM\n kYtmEY9weSGw==", "\n 1qwdXwAvyXlPM85Hmu6SGLLiDthmBn6wMqWrOppsfT12hl9BM1iutWP4HRk+Leoh7tWVGGUSxb\n fAzeh8KZGR8Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9725\"; a=\"155712661\"", "E=Sophos;i=\"5.76,359,1592895600\"; d=\"scan'208\";a=\"155712661\"", "E=Sophos;i=\"5.76,359,1592895600\"; d=\"scan'208\";a=\"475150495\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jeff Guo <jia.guo@intel.com>", "To": "qiming.yang@intel.com, beilei.xing@intel.com, wei.zhao1@intel.com,\n qi.z.zhang@intel.com, jingjing.wu@intel.com", "Cc": "bruce.richardson@intel.com, dev@dpdk.org, jia.guo@intel.com,\n helin.zhang@intel.com, mb@smartsharesystems.com, ferruh.yigit@intel.com,\n barbette@kth.se", "Date": "Thu, 27 Aug 2020 18:10:06 +0800", "Message-Id": "<20200827101008.76906-4-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200827101008.76906-1-jia.guo@intel.com>", "References": "<20200827101008.76906-1-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/5] net/ice: maximize vector rx burst for ice", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The limitation of burst size in vector rx was removed, since it should\nretrieve as much received packets as possible. And also the scattered\nreceive path should use a wrapper function to achieve the goal of\nburst maximizing.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\n drivers/net/ice/ice_rxtx_vec_avx2.c | 11 +------\n drivers/net/ice/ice_rxtx_vec_sse.c | 49 ++++++++++++++++++++---------\n 2 files changed, 35 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx_vec_avx2.c b/drivers/net/ice/ice_rxtx_vec_avx2.c\nindex be50677c2..b7e624fda 100644\n--- a/drivers/net/ice/ice_rxtx_vec_avx2.c\n+++ b/drivers/net/ice/ice_rxtx_vec_avx2.c\n@@ -603,10 +603,6 @@ _ice_recv_raw_pkts_vec_avx2(struct ice_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \treturn received;\n }\n \n-/**\n- * Notice:\n- * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n- */\n uint16_t\n ice_recv_pkts_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t uint16_t nb_pkts)\n@@ -615,9 +611,7 @@ ice_recv_pkts_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\n }\n \n /**\n- * vPMD receive routine that reassembles single burst of 32 scattered packets\n- * Notice:\n- * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n+ * vPMD receive routine that reassembles scattered packets\n */\n static uint16_t\n ice_recv_scattered_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\n@@ -657,9 +651,6 @@ ice_recv_scattered_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\n \n /**\n * vPMD receive routine that reassembles scattered packets.\n- * Main receive routine that can handle arbitrary burst sizes\n- * Notice:\n- * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n */\n uint16_t\n ice_recv_scattered_pkts_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\ndiff --git a/drivers/net/ice/ice_rxtx_vec_sse.c b/drivers/net/ice/ice_rxtx_vec_sse.c\nindex 382ef31f3..25ae368cc 100644\n--- a/drivers/net/ice/ice_rxtx_vec_sse.c\n+++ b/drivers/net/ice/ice_rxtx_vec_sse.c\n@@ -205,10 +205,11 @@ ice_rx_desc_to_ptype_v(__m128i descs[4], struct rte_mbuf **rx_pkts,\n }\n \n /**\n+ * vPMD raw receive routine, only accept(nb_pkts >= ICE_DESCS_PER_LOOP)\n+ *\n * Notice:\n * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > ICE_VPMD_RX_BURST, only scan ICE_VPMD_RX_BURST\n- * numbers of DD bits\n+ * - floor align nb_pkts to a ICE_DESCS_PER_LOOP power-of-two\n */\n static inline uint16_t\n _ice_recv_raw_pkts_vec(struct ice_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n@@ -264,9 +265,6 @@ _ice_recv_raw_pkts_vec(struct ice_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \tconst __m128i eop_check = _mm_set_epi64x(0x0000000200000002LL,\n \t\t\t\t\t\t 0x0000000200000002LL);\n \n-\t/* nb_pkts shall be less equal than ICE_MAX_RX_BURST */\n-\tnb_pkts = RTE_MIN(nb_pkts, ICE_MAX_RX_BURST);\n-\n \t/* nb_pkts has to be floor-aligned to ICE_DESCS_PER_LOOP */\n \tnb_pkts = RTE_ALIGN_FLOOR(nb_pkts, ICE_DESCS_PER_LOOP);\n \n@@ -444,8 +442,6 @@ _ice_recv_raw_pkts_vec(struct ice_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n /**\n * Notice:\n * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > ICE_VPMD_RX_BURST, only scan ICE_VPMD_RX_BURST\n- * numbers of DD bits\n */\n uint16_t\n ice_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n@@ -454,15 +450,12 @@ ice_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \treturn _ice_recv_raw_pkts_vec(rx_queue, rx_pkts, nb_pkts, NULL);\n }\n \n-/* vPMD receive routine that reassembles scattered packets\n- * Notice:\n- * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > ICE_VPMD_RX_BURST, only scan ICE_VPMD_RX_BURST\n- * numbers of DD bits\n+/**\n+ * vPMD receive routine that reassembles scattered packets\n */\n-uint16_t\n-ice_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n-\t\t\t uint16_t nb_pkts)\n+static uint16_t\n+ice_recv_scattered_burst_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t uint16_t nb_pkts)\n {\n \tstruct ice_rx_queue *rxq = rx_queue;\n \tuint8_t split_flags[ICE_VPMD_RX_BURST] = {0};\n@@ -496,6 +489,32 @@ ice_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\t\t\t &split_flags[i]);\n }\n \n+/**\n+ * vPMD receive routine that reassembles scattered packets.\n+ */\n+uint16_t\n+ice_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t uint16_t nb_pkts)\n+{\n+\tuint16_t retval = 0;\n+\n+\twhile (nb_pkts > ICE_VPMD_RX_BURST) {\n+\t\tuint16_t burst;\n+\n+\t\tburst = ice_recv_scattered_burst_vec(rx_queue,\n+\t\t\t\t\t\t rx_pkts + retval,\n+\t\t\t\t\t\t ICE_VPMD_RX_BURST);\n+\t\tretval += burst;\n+\t\tnb_pkts -= burst;\n+\t\tif (burst < ICE_VPMD_RX_BURST)\n+\t\t\treturn retval;\n+\t}\n+\n+\treturn retval + ice_recv_scattered_burst_vec(rx_queue,\n+\t\t\t\t\t\t rx_pkts + retval,\n+\t\t\t\t\t\t nb_pkts);\n+}\n+\n static inline void\n ice_vtx1(volatile struct ice_tx_desc *txdp, struct rte_mbuf *pkt,\n \t uint64_t flags)\n", "prefixes": [ "v2", "3/5" ] }