Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75945/?format=api
{ "id": 75945, "url": "http://patches.dpdk.org/api/patches/75945/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200825211317.8358-2-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200825211317.8358-2-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200825211317.8358-2-dharmik.thakkar@arm.com", "date": "2020-08-25T21:13:17", "name": "[2/2] build: find max lcore programmatically", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "718ef12284bedd3ab6e684567bebb75026113e7b", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200825211317.8358-2-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 11784, "url": "http://patches.dpdk.org/api/series/11784/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11784", "date": "2020-08-25T21:13:17", "name": "[1/2] config/arm: avoid variable reuse", "version": 1, "mbox": "http://patches.dpdk.org/series/11784/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75945/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/75945/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 25B7DA04B1;\n\tTue, 25 Aug 2020 23:14:02 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1B16ADE3;\n\tTue, 25 Aug 2020 23:14:01 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id E657BDE3\n for <dev@dpdk.org>; Tue, 25 Aug 2020 23:13:58 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A9171045;\n Tue, 25 Aug 2020 14:13:58 -0700 (PDT)", "from localhost.localdomain (2p2660v4-1.austin.arm.com\n [10.118.12.95])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 350293F71F;\n Tue, 25 Aug 2020 14:13:58 -0700 (PDT)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Tue, 25 Aug 2020 16:13:17 -0500", "Message-Id": "<20200825211317.8358-2-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200825211317.8358-1-dharmik.thakkar@arm.com>", "References": "<20200825211317.8358-1-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH 2/2] build: find max lcore programmatically", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For Arm, RTE_MAX_LCORE is hard-coded into the config. It leads to incorrect\nRTE_MAX_LCORE when machines have same Implemener and part number\nbut different number of CPUs.\nFor x86, RTE_MAX_LCORE is always set to 128 (using the value\nset in meson_options.txt)\n\nUse python script to find max lcore when using native build to\ncorrectly set RTE_MAX_LCORE.\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n config/get_max_lcores.py | 13 +++++++++++++\n config/meson.build | 13 ++++++++++++-\n 2 files changed, 25 insertions(+), 1 deletion(-)\n create mode 100755 config/get_max_lcores.py", "diff": "diff --git a/config/get_max_lcores.py b/config/get_max_lcores.py\nnew file mode 100755\nindex 000000000000..ebf1c7efdadd\n--- /dev/null\n+++ b/config/get_max_lcores.py\n@@ -0,0 +1,13 @@\n+#!/usr/bin/python3\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2020 Arm Limited\n+\n+import os\n+\n+max_lcores = []\n+\n+nCPU = os.cpu_count()\n+\n+max_lcores.append(str(nCPU & 0xFFF)) # Number of CPUs\n+\n+print(' '.join(max_lcores))\ndiff --git a/config/meson.build b/config/meson.build\nindex 6996e5cbeaa5..80c05bc15d2f 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -237,11 +237,22 @@ else # for 32-bit we need smaller reserved memory areas\n \tdpdk_conf.set('RTE_MAX_MEM_MB', 2048)\n endif\n \n-\n compile_time_cpuflags = []\n subdir(arch_subdir)\n dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS', ','.join(compile_time_cpuflags))\n \n+# set max lcores\n+if machine != 'default' and not meson.is_cross_build()\n+\t# The script returns max lcores\n+\tparams = files('get_max_lcores.py')\n+\tcmd_out = run_command(params)\n+\tif cmd_out.returncode() == 0\n+\t\tcmd_lcore = cmd_out.stdout().to_lower().strip().split(' ')\n+\tendif\n+\tmax_lcore = cmd_lcore[0].to_int()\n+\tdpdk_conf.set('RTE_MAX_LCORE', max_lcore)\n+endif\n+\n # set the install path for the drivers\n dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)\n \n", "prefixes": [ "2/2" ] }