Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75919/?format=api
{ "id": 75919, "url": "http://patches.dpdk.org/api/patches/75919/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200825114447.135030-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200825114447.135030-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200825114447.135030-1-bruce.richardson@intel.com", "date": "2020-08-25T11:44:46", "name": "[1/2] config: remove explicit undefinition of unset values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "808cabb46bced366ce42d2f3cf3f4604aa302784", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200825114447.135030-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11777, "url": "http://patches.dpdk.org/api/series/11777/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11777", "date": "2020-08-25T11:44:46", "name": "[1/2] config: remove explicit undefinition of unset values", "version": 1, "mbox": "http://patches.dpdk.org/series/11777/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75919/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/75919/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 75488A04B1;\n\tTue, 25 Aug 2020 13:44:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4C08B1C11B;\n\tTue, 25 Aug 2020 13:44:54 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 0FF091C116\n for <dev@dpdk.org>; Tue, 25 Aug 2020 13:44:52 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Aug 2020 04:44:52 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.56])\n by orsmga004.jf.intel.com with ESMTP; 25 Aug 2020 04:44:51 -0700" ], "IronPort-SDR": [ "\n tWoTBs+lOsSLLov0B083dxi4JifNQhKzOMkz3P0RLE7iuDxPD7hcyg3/VUY9P59CYTmO6iWXWV\n 49O6Hl6rf8gA==", "\n 4tHUEIwlrKkHvbrNHNQjKROmP0GNkb80cwK2tRouwC04UYBxn8q3zntf4Uqhpimsbd8h6HZimX\n GDCQZRXgqjfw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9723\"; a=\"217640595\"", "E=Sophos;i=\"5.76,352,1592895600\"; d=\"scan'208\";a=\"217640595\"", "E=Sophos;i=\"5.76,352,1592895600\"; d=\"scan'208\";a=\"443603511\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "bluca@debian.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 25 Aug 2020 12:44:46 +0100", "Message-Id": "<20200825114447.135030-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] config: remove explicit undefinition of\n\tunset values", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rather than explicitly clearing any setting of undefined values in our\nrte_config.h file, it's better to instead just add a comment that the value\nis not set. Using a comment allows the user to set the value using CFLAGS\nor similar mechanism without the config file clearing the value again.\n\nThe text used \"<VALUE> is not set\" is modelled after the kernel approach of\ndoing the same thing.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/rte_config.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/config/rte_config.h b/config/rte_config.h\nindex 9bb915347c..1c5a86d6a7 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -85,17 +85,17 @@\n \n /* ip_fragmentation defines */\n #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4\n-#undef RTE_LIBRTE_IP_FRAG_TBL_STAT\n+// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set\n \n /* rte_power defines */\n #define RTE_MAX_LCORE_FREQS 64\n \n /* rte_sched defines */\n-#undef RTE_SCHED_RED\n-#undef RTE_SCHED_COLLECT_STATS\n-#undef RTE_SCHED_SUBPORT_TC_OV\n+// RTE_SCHED_RED is not set\n+// RTE_SCHED_COLLECT_STATS is not set\n+// RTE_SCHED_SUBPORT_TC_OV is not set\n #define RTE_SCHED_PORT_N_GRINDERS 8\n-#undef RTE_SCHED_VECTOR\n+// RTE_SCHED_VECTOR is not set\n \n /* KNI defines */\n #define RTE_KNI_PREEMPT_DEFAULT 1\n@@ -123,7 +123,7 @@\n \n /* i40e defines */\n #define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1\n-#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC\n+// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4\n", "prefixes": [ "1/2" ] }