Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75909/?format=api
{ "id": 75909, "url": "http://patches.dpdk.org/api/patches/75909/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200825093116.26538-12-ophirmu@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200825093116.26538-12-ophirmu@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200825093116.26538-12-ophirmu@nvidia.com", "date": "2020-08-25T09:31:14", "name": "[v2,11/13] net/mlx5: remove ibv_* dependency in Rx/Tx objects", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ca39a04af75f31748ef905424dd09ccb13694d6e", "submitter": { "id": 1908, "url": "http://patches.dpdk.org/api/people/1908/?format=api", "name": "Ophir Munk", "email": "ophirmu@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200825093116.26538-12-ophirmu@nvidia.com/mbox/", "series": [ { "id": 11773, "url": "http://patches.dpdk.org/api/series/11773/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11773", "date": "2020-08-25T09:31:06", "name": "mlx5 PMD multi OS support - part #4", "version": 2, "mbox": "http://patches.dpdk.org/series/11773/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75909/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8199CA04B1;\n\tTue, 25 Aug 2020 11:33:21 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 928A11C210;\n\tTue, 25 Aug 2020 11:31:45 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id C97731C1B9\n for <dev@dpdk.org>; Tue, 25 Aug 2020 11:31:29 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n ophirmu@nvidia.com) with SMTP; 25 Aug 2020 12:31:25 +0300", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 07P9VPN1030009;\n Tue, 25 Aug 2020 12:31:25 +0300" ], "From": "Ophir Munk <ophirmu@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Ophir Munk <ophirmu@mellanox.com>", "Date": "Tue, 25 Aug 2020 09:31:14 +0000", "Message-Id": "<20200825093116.26538-12-ophirmu@nvidia.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20200825093116.26538-1-ophirmu@nvidia.com>", "References": "<20200820145028.4090-1-ophirmu@nvidia.com>\n <20200825093116.26538-1-ophirmu@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v2 11/13] net/mlx5: remove ibv_* dependency in\n\tRx/Tx objects", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ophir Munk <ophirmu@mellanox.com>\n\nReplace pointers to ibv structs with pointers to void (file\nmlx5_rxtx.h). Specifically the following pointers were replaced:\n'struct ibv_cq *', 'struct ibv_wq *', 'struct ibv_comp_channel *',\n'struct ibv_rwq_ind_table *a', 'struct ibv_qp *'.\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 5 +++--\n drivers/net/mlx5/mlx5_rxtx.h | 14 +++++++-------\n drivers/net/mlx5/mlx5_trigger.c | 3 ++-\n drivers/net/mlx5/mlx5_txq.c | 2 +-\n 4 files changed, 13 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 92d8876..946f745 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1790,7 +1790,8 @@ mlx5_rxq_obj_new(struct rte_eth_dev *dev, uint16_t idx,\n \t\t\t\trte_errno = ENOMEM;\n \t\t\t\tgoto error;\n \t\t\t}\n-\t\t\ttmpl->fd = tmpl->ibv_channel->fd;\n+\t\t\ttmpl->fd = ((struct ibv_comp_channel *)\n+\t\t\t\t\t(tmpl->ibv_channel))->fd;\n \t\t} else if (tmpl->type == MLX5_RXQ_OBJ_TYPE_DEVX_RQ) {\n \t\t\tint devx_ev_flag =\n \t\t\t MLX5DV_DEVX_CREATE_EVENT_CHANNEL_FLAGS_OMIT_EV_DATA;\n@@ -3299,7 +3300,7 @@ mlx5_ind_table_obj_drop_new(struct rte_eth_dev *dev)\n \t\t(priv->sh->ctx,\n \t\t &(struct ibv_rwq_ind_table_init_attr){\n \t\t\t.log_ind_tbl_size = 0,\n-\t\t\t.ind_tbl = &rxq->wq,\n+\t\t\t.ind_tbl = (struct ibv_wq **)&rxq->wq,\n \t\t\t.comp_mask = 0,\n \t\t });\n \tif (!tmpl.ind_table) {\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 0fc7754..f3fe2e1 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -178,9 +178,9 @@ struct mlx5_rxq_obj {\n \tRTE_STD_C11\n \tunion {\n \t\tstruct {\n-\t\t\tstruct ibv_wq *wq; /* Work Queue. */\n-\t\t\tstruct ibv_cq *ibv_cq; /* Completion Queue. */\n-\t\t\tstruct ibv_comp_channel *ibv_channel;\n+\t\t\tvoid *wq; /* Work Queue. */\n+\t\t\tvoid *ibv_cq; /* Completion Queue. */\n+\t\t\tvoid *ibv_channel;\n \t\t};\n \t\tstruct {\n \t\t\tstruct mlx5_devx_obj *rq; /* DevX Rx Queue object. */\n@@ -229,7 +229,7 @@ struct mlx5_ind_table_obj {\n \tenum mlx5_ind_tbl_type type;\n \tRTE_STD_C11\n \tunion {\n-\t\tstruct ibv_rwq_ind_table *ind_table; /**< Indirection table. */\n+\t\tvoid *ind_table; /**< Indirection table. */\n \t\tstruct mlx5_devx_obj *rqt; /* DevX RQT object. */\n \t};\n \tuint32_t queues_n; /**< Number of queues in the list. */\n@@ -243,7 +243,7 @@ struct mlx5_hrxq {\n \tstruct mlx5_ind_table_obj *ind_table; /* Indirection table. */\n \tRTE_STD_C11\n \tunion {\n-\t\tstruct ibv_qp *qp; /* Verbs queue pair. */\n+\t\tvoid *qp; /* Verbs queue pair. */\n \t\tstruct mlx5_devx_obj *tir; /* DevX TIR object. */\n \t};\n #ifdef HAVE_IBV_FLOW_DV_SUPPORT\n@@ -350,8 +350,8 @@ struct mlx5_txq_obj {\n \tRTE_STD_C11\n \tunion {\n \t\tstruct {\n-\t\t\tstruct ibv_cq *cq; /* Completion Queue. */\n-\t\t\tstruct ibv_qp *qp; /* Queue Pair. */\n+\t\t\tvoid *cq; /* Completion Queue. */\n+\t\t\tvoid *qp; /* Queue Pair. */\n \t\t};\n \t\tstruct {\n \t\t\tstruct mlx5_devx_obj *sq;\ndiff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex 6f1e6d4..549af35 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -153,7 +153,8 @@ mlx5_rxq_start(struct rte_eth_dev *dev)\n \t\tif (!rxq_ctrl->obj)\n \t\t\tgoto error;\n \t\tif (obj_type == MLX5_RXQ_OBJ_TYPE_IBV)\n-\t\t\trxq_ctrl->wqn = rxq_ctrl->obj->wq->wq_num;\n+\t\t\trxq_ctrl->wqn =\n+\t\t\t\t((struct ibv_wq *)(rxq_ctrl->obj->wq))->wq_num;\n \t\telse if (obj_type == MLX5_RXQ_OBJ_TYPE_DEVX_RQ)\n \t\t\trxq_ctrl->wqn = rxq_ctrl->obj->rq->id;\n \t}\ndiff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex fed9d8a..66ad368 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -1317,7 +1317,7 @@ mlx5_txq_obj_new(struct rte_eth_dev *dev, uint16_t idx,\n \ttxq_data->cqe_n = log2above(cq_info.cqe_cnt);\n \ttxq_data->cqe_s = 1 << txq_data->cqe_n;\n \ttxq_data->cqe_m = txq_data->cqe_s - 1;\n-\ttxq_data->qp_num_8s = tmpl.qp->qp_num << 8;\n+\ttxq_data->qp_num_8s = ((struct ibv_qp *)tmpl.qp)->qp_num << 8;\n \ttxq_data->wqes = qp.sq.buf;\n \ttxq_data->wqe_n = log2above(qp.sq.wqe_cnt);\n \ttxq_data->wqe_s = 1 << txq_data->wqe_n;\n", "prefixes": [ "v2", "11/13" ] }