Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 75905,
    "url": "http://patches.dpdk.org/api/patches/75905/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200825093116.26538-9-ophirmu@nvidia.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200825093116.26538-9-ophirmu@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200825093116.26538-9-ophirmu@nvidia.com",
    "date": "2020-08-25T09:31:11",
    "name": "[v2,08/13] net/mlx5: call meter detach only if DR is supported",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6989e1b2f49c1f3c1b43c3ff1a05bfbb44f1e5c6",
    "submitter": {
        "id": 1908,
        "url": "http://patches.dpdk.org/api/people/1908/?format=api",
        "name": "Ophir Munk",
        "email": "ophirmu@nvidia.com"
    },
    "delegate": {
        "id": 3268,
        "url": "http://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200825093116.26538-9-ophirmu@nvidia.com/mbox/",
    "series": [
        {
            "id": 11773,
            "url": "http://patches.dpdk.org/api/series/11773/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11773",
            "date": "2020-08-25T09:31:06",
            "name": "mlx5 PMD multi OS support - part #4",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/11773/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/75905/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/75905/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4085EA04B1;\n\tTue, 25 Aug 2020 11:32:40 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6DE921C1E9;\n\tTue, 25 Aug 2020 11:31:40 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id BC7341C1B6\n for <dev@dpdk.org>; Tue, 25 Aug 2020 11:31:29 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n ophirmu@nvidia.com) with SMTP; 25 Aug 2020 12:31:25 +0300",
            "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 07P9VPMw030009;\n Tue, 25 Aug 2020 12:31:25 +0300"
        ],
        "From": "Ophir Munk <ophirmu@nvidia.com>",
        "To": "dev@dpdk.org",
        "Cc": "Ophir Munk <ophirmu@mellanox.com>",
        "Date": "Tue, 25 Aug 2020 09:31:11 +0000",
        "Message-Id": "<20200825093116.26538-9-ophirmu@nvidia.com>",
        "X-Mailer": "git-send-email 2.8.4",
        "In-Reply-To": "<20200825093116.26538-1-ophirmu@nvidia.com>",
        "References": "<20200820145028.4090-1-ophirmu@nvidia.com>\n <20200825093116.26538-1-ophirmu@nvidia.com>",
        "Subject": "[dpdk-dev] [PATCH v2 08/13] net/mlx5: call meter detach only if DR\n\tis supported",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Ophir Munk <ophirmu@mellanox.com>\n\nFlow metering is supported only in direct rules (DR). Currently the APIs\nof meter actions create and modify are under #ifdef\nHAVE_MLX5_DR_CREATE_ACTION_FLOW_METER, while detaching the meter action\nis executed unconditionally. This commit adds the same ifdef to API\nmlx5_flow_meter_detach().\nThis commit avoids compilation failure of non-Linux operating systems\nwhich do not support DR.\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_meter.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_meter.c b/drivers/net/mlx5/mlx5_flow_meter.c\nindex bf34687..b36bc7b 100644\n--- a/drivers/net/mlx5/mlx5_flow_meter.c\n+++ b/drivers/net/mlx5/mlx5_flow_meter.c\n@@ -1221,6 +1221,7 @@ mlx5_flow_meter_attach(struct mlx5_priv *priv, uint32_t meter_id,\n void\n mlx5_flow_meter_detach(struct mlx5_flow_meter *fm)\n {\n+#ifdef HAVE_MLX5_DR_CREATE_ACTION_FLOW_METER\n \tMLX5_ASSERT(fm->ref_cnt);\n \tif (--fm->ref_cnt)\n \t\treturn;\n@@ -1230,6 +1231,9 @@ mlx5_flow_meter_detach(struct mlx5_flow_meter *fm)\n \tfm->ingress = 0;\n \tfm->egress = 0;\n \tfm->transfer = 0;\n+#else\n+\t(void)fm;\n+#endif\n }\n \n /**\n",
    "prefixes": [
        "v2",
        "08/13"
    ]
}