Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75903/?format=api
{ "id": 75903, "url": "http://patches.dpdk.org/api/patches/75903/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200825093116.26538-5-ophirmu@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200825093116.26538-5-ophirmu@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200825093116.26538-5-ophirmu@nvidia.com", "date": "2020-08-25T09:31:07", "name": "[v2,04/13] net/mlx5: move mlx5_get_ifname prototype under Linux", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e9b0394da2f8118d6f62c7a5abcbf36b53c7fcbc", "submitter": { "id": 1908, "url": "http://patches.dpdk.org/api/people/1908/?format=api", "name": "Ophir Munk", "email": "ophirmu@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200825093116.26538-5-ophirmu@nvidia.com/mbox/", "series": [ { "id": 11773, "url": "http://patches.dpdk.org/api/series/11773/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11773", "date": "2020-08-25T09:31:06", "name": "mlx5 PMD multi OS support - part #4", "version": 2, "mbox": "http://patches.dpdk.org/series/11773/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75903/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/75903/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 18CCDA04B1;\n\tTue, 25 Aug 2020 11:32:21 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 071C61C1DB;\n\tTue, 25 Aug 2020 11:31:38 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id A727D1C1AD\n for <dev@dpdk.org>; Tue, 25 Aug 2020 11:31:29 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n ophirmu@nvidia.com) with SMTP; 25 Aug 2020 12:31:25 +0300", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 07P9VPMs030009;\n Tue, 25 Aug 2020 12:31:25 +0300" ], "From": "Ophir Munk <ophirmu@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Ophir Munk <ophirmu@mellanox.com>", "Date": "Tue, 25 Aug 2020 09:31:07 +0000", "Message-Id": "<20200825093116.26538-5-ophirmu@nvidia.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20200825093116.26538-1-ophirmu@nvidia.com>", "References": "<20200820145028.4090-1-ophirmu@nvidia.com>\n <20200825093116.26538-1-ophirmu@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v2 04/13] net/mlx5: move mlx5_get_ifname\n\tprototype under Linux", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ophir Munk <ophirmu@mellanox.com>\n\nmlx5_get_ifname() prototype includes 'IF_NAMESIZE' definition from Linux\nfile net/if.h. Since this API is only used under Linux and to enable\ncompilation under non-Linux OS - move this prototype from shared file\nmlx5.h to file linux/mlx5_os.h.\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/linux/mlx5_os.h | 6 ++++++\n drivers/net/mlx5/mlx5.c | 1 -\n drivers/net/mlx5/mlx5.h | 2 --\n 3 files changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.h b/drivers/net/mlx5/linux/mlx5_os.h\nindex 31add39..759def2 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.h\n+++ b/drivers/net/mlx5/linux/mlx5_os.h\n@@ -6,6 +6,8 @@\n #ifndef RTE_PMD_MLX5_OS_H_\n #define RTE_PMD_MLX5_OS_H_\n \n+#include <net/if.h>\n+\n /* verb enumerations translations to local enums. */\n enum {\n \tDEV_SYSFS_NAME_MAX = IBV_SYSFS_NAME_MAX + 1,\n@@ -15,4 +17,8 @@ enum {\n #define PCI_DRV_FLAGS (RTE_PCI_DRV_INTR_LSC | \\\n \t\t\tRTE_PCI_DRV_INTR_RMV | \\\n \t\t\tRTE_PCI_DRV_PROBE_AGAIN)\n+\n+/* mlx5_ethdev_os.c */\n+\n+int mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[IF_NAMESIZE]);\n #endif /* RTE_PMD_MLX5_OS_H_ */\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 1e4c695..b099b23 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -9,7 +9,6 @@\n #include <stdint.h>\n #include <stdlib.h>\n #include <errno.h>\n-#include <net/if.h>\n #include <sys/mman.h>\n #include <linux/rtnetlink.h>\n \ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 1880a82..3aea3b5 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -10,7 +10,6 @@\n #include <stdbool.h>\n #include <stdint.h>\n #include <limits.h>\n-#include <net/if.h>\n #include <netinet/in.h>\n #include <sys/queue.h>\n \n@@ -813,7 +812,6 @@ int mlx5_dev_configure_rss_reta(struct rte_eth_dev *dev);\n \n /* mlx5_ethdev_os.c */\n \n-int mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[IF_NAMESIZE]);\n unsigned int mlx5_ifindex(const struct rte_eth_dev *dev);\n int mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]);\n int mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu);\n", "prefixes": [ "v2", "04/13" ] }