Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75734/?format=api
{ "id": 75734, "url": "http://patches.dpdk.org/api/patches/75734/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200820090351.3780-2-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200820090351.3780-2-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200820090351.3780-2-huwei013@chinasoftinc.com", "date": "2020-08-20T09:03:49", "name": "[v3,1/3] net/hns3: report Rx drop packets enable configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "908dbff17eae3c43443f1299b6d2ba04de7cfd79", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200820090351.3780-2-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 11723, "url": "http://patches.dpdk.org/api/series/11723/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11723", "date": "2020-08-20T09:03:48", "name": "minor updates for getting queue info", "version": 3, "mbox": "http://patches.dpdk.org/series/11723/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75734/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/75734/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 84789A04AF;\n\tThu, 20 Aug 2020 11:04:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 859D31C044;\n\tThu, 20 Aug 2020 11:04:18 +0200 (CEST)", "from mail.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id BEEEF1BEBA\n for <dev@dpdk.org>; Thu, 20 Aug 2020 11:04:15 +0200 (CEST)", "from localhost.localdomain (65.49.108.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Thu, 20 Aug 2020\n 17:04:12 +0800" ], "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>, \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>, \"Min Hu\n (Connor)\" <humin29@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>", "Date": "Thu, 20 Aug 2020 17:03:49 +0800", "Message-ID": "<20200820090351.3780-2-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200820090351.3780-1-huwei013@chinasoftinc.com>", "References": "<20200818025132.27912-1-huwei013@chinasoftinc.com>\n <20200820090351.3780-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[65.49.108.226]", "Subject": "[dpdk-dev] [PATCH v3 1/3] net/hns3: report Rx drop packets enable\n\tconfiguration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nCurrently, if there are not available Rx buffer descriptors in recieving\ndirection based on hns3 network engine, incoming packets will always be\ndropped by hardware. This patch reports the '.rx_drop_en' information to\nDPDK framework in the '.dev_infos_get', '.rxq_info_get' and\n'.rx_queue_setup' ops implementation function.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 9 +++++++++\n drivers/net/hns3/hns3_ethdev_vf.c | 9 +++++++++\n drivers/net/hns3/hns3_rxtx.c | 6 ++++++\n 3 files changed, 24 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 81e773046..bcbbd7e81 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2495,6 +2495,15 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \t\t.nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT,\n \t};\n \n+\tinfo->default_rxconf = (struct rte_eth_rxconf) {\n+\t\t/*\n+\t\t * If there are no available Rx buffer descriptors, incoming\n+\t\t * packets are always dropped by hardware based on hns3 network\n+\t\t * engine.\n+\t\t */\n+\t\t.rx_drop_en = 1,\n+\t};\n+\n \tinfo->vmdq_queue_num = 0;\n \n \tinfo->reta_size = HNS3_RSS_IND_TBL_SIZE;\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 1d2941f0e..3156ed7f5 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -947,6 +947,15 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \t\t.nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT,\n \t};\n \n+\tinfo->default_rxconf = (struct rte_eth_rxconf) {\n+\t\t/*\n+\t\t * If there are no available Rx buffer descriptors, incoming\n+\t\t * packets are always dropped by hardware based on hns3 network\n+\t\t * engine.\n+\t\t */\n+\t\t.rx_drop_en = 1,\n+\t};\n+\n \tinfo->vmdq_queue_num = 0;\n \n \tinfo->reta_size = HNS3_RSS_IND_TBL_SIZE;\ndiff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex c0f798159..3e5e32e38 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -1251,6 +1251,12 @@ hns3_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t nb_desc,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (conf->rx_drop_en == 0)\n+\t\thns3_warn(hw, \"if there are no available Rx descriptors,\"\n+\t\t\t \"incoming packets are always dropped. input parameter\"\n+\t\t\t \" conf->rx_drop_en(%u) is uneffective.\",\n+\t\t\t conf->rx_drop_en);\n+\n \tif (dev->data->rx_queues[idx]) {\n \t\thns3_rx_queue_release(dev->data->rx_queues[idx]);\n \t\tdev->data->rx_queues[idx] = NULL;\n", "prefixes": [ "v3", "1/3" ] }