Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75634/?format=api
{ "id": 75634, "url": "http://patches.dpdk.org/api/patches/75634/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200813072503.1411-1-vipul.ashri@oracle.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200813072503.1411-1-vipul.ashri@oracle.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200813072503.1411-1-vipul.ashri@oracle.com", "date": "2020-08-13T07:25:02", "name": "[v2] net/virtio: fix wrong variable assignment in helper macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ca26e3fa0ccddf44fe8d572f1255c24cb3589ca6", "submitter": { "id": 1867, "url": "http://patches.dpdk.org/api/people/1867/?format=api", "name": "Vipul Ashri", "email": "vipul.ashri@oracle.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200813072503.1411-1-vipul.ashri@oracle.com/mbox/", "series": [ { "id": 11689, "url": "http://patches.dpdk.org/api/series/11689/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11689", "date": "2020-08-13T07:25:02", "name": "[v2] net/virtio: fix wrong variable assignment in helper macro", "version": 2, "mbox": "http://patches.dpdk.org/series/11689/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75634/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75634/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7CD20A034C;\n\tTue, 18 Aug 2020 15:50:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E42031C193;\n\tTue, 18 Aug 2020 15:47:18 +0200 (CEST)", "from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78])\n by dpdk.org (Postfix) with ESMTP id 7EBFF1C023;\n Thu, 13 Aug 2020 09:25:22 +0200 (CEST)", "from pps.filterd (aserp2120.oracle.com [127.0.0.1])\n by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07D7H3Jt159651;\n Thu, 13 Aug 2020 07:25:21 GMT", "from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])\n by aserp2120.oracle.com with ESMTP id 32sm0mxxt1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);\n Thu, 13 Aug 2020 07:25:21 +0000", "from pps.filterd (userp3030.oracle.com [127.0.0.1])\n by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07D7MXZv007390;\n Thu, 13 Aug 2020 07:25:20 GMT", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n by userp3030.oracle.com with ESMTP id 32t602xnmt-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 13 Aug 2020 07:25:20 +0000", "from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20])\n by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07D7PJ4a030885;\n Thu, 13 Aug 2020 07:25:19 GMT", "from VASHRI-IN.in.oracle.com (/10.191.246.206)\n by default (Oracle Beehive Gateway v4.0)\n with ESMTP ; Thu, 13 Aug 2020 07:25:18 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=corp-2020-01-29;\n bh=PyGERTMxQIjj1Gc+veOLRN0Vc7P2HSS60BlhuK2xveE=;\n b=k/CmQLAerSKd7bHUJdK4Vdch+2NoIeInQpqr2doIlafOJVyMrTGp5sLmVxmrXVLN4+FX\n KTidlKhme6L4Kj5ehjDqTWHR5a36hzu+rRv5qIHHmNGhUiNK16SA3m7OPgldPCMm9sQX\n tbG61uzaWzJDZyujf44SyTi4FjNjWei/BLWVrvyKgTufwUJbhsGnYcMeYU6k5p3FlDbg\n NDCA5c/lLNq4czjG8rqgeSYULkiiBsbBHU1ZBW0OofpFAT10hUMd0dbkIntbfKsaDWy7\n Gok0xKOYlCazpdpX+NEfBiePhb0CPLo/sQTmzjnh24Hq6Li76wlYzxyG8aQYp+vhjWMk +Q==", "From": "Vipul Ashri <vipul.ashri@oracle.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, vipul.ashri@oracle.com, edwin.leung@oracle.com,\n stable@dpdk.org", "Date": "Thu, 13 Aug 2020 12:55:02 +0530", "Message-Id": "<20200813072503.1411-1-vipul.ashri@oracle.com>", "X-Mailer": "git-send-email 2.28.0.windows.1", "In-Reply-To": "<20200812092306.1345-1-vipul.ashri@oracle.com>", "References": "<20200812092306.1345-1-vipul.ashri@oracle.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": [ "vendor=nai engine=6000 definitions=9711\n signatures=668679", "vendor=nai engine=6000 definitions=9711\n signatures=668679" ], "X-Proofpoint-Spam-Details": [ "rule=notspam policy=default score=0 malwarescore=0\n mlxscore=0 phishscore=0\n bulkscore=0 adultscore=0 spamscore=0 suspectscore=1 mlxlogscore=999\n classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000\n definitions=main-2008130056", "rule=notspam policy=default score=0 phishscore=0\n clxscore=1011\n suspectscore=1 mlxlogscore=999 priorityscore=1501 adultscore=0\n impostorscore=0 spamscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0\n malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2006250000 definitions=main-2008130055" ], "X-Mailman-Approved-At": "Tue, 18 Aug 2020 15:47:00 +0200", "Subject": "[dpdk-dev] [PATCH v2] net/virtio: fix wrong variable assignment in\n\thelper macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always\nfailing as assignment done using var_ having local scope only.\nThis leads to TX packets not going out and found broken due to cleanup\nmalfunctioning. This patch fixes the wrong variable assignment.\n\nFixes: 57f90f894588 (\"net/virtio: reuse packed ring functions\")\nCc: stable@dpdk.org\n\nSigned-off-by: Vipul Ashri <vipul.ashri@oracle.com>\n---\n drivers/net/virtio/virtqueue.h | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h\nindex 105a9c00c..20c95471e 100644\n--- a/drivers/net/virtio/virtqueue.h\n+++ b/drivers/net/virtio/virtqueue.h\n@@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)\n \n /* avoid write operation when necessary, to lessen cache issues */\n #define ASSIGN_UNLESS_EQUAL(var, val) do {\t\\\n-\ttypeof(var) var_ = (var);\t\t\\\n-\ttypeof(val) val_ = (val);\t\t\\\n-\tif ((var_) != (val_))\t\t\t\\\n-\t\t(var_) = (val_);\t\t\\\n+\tif ((var) != (val))\t\t\t\\\n+\t\t(var) = (val);\t\t\t\\\n } while (0)\n \n #define virtqueue_clear_net_hdr(hdr) do {\t\t\\\n", "prefixes": [ "v2" ] }