Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75560/?format=api
{ "id": 75560, "url": "http://patches.dpdk.org/api/patches/75560/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200814110045.217724-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200814110045.217724-3-bruce.richardson@intel.com", "date": "2020-08-14T11:00:43", "name": "[2/4] examples/vm_power_manager: fix string truncation warning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0df6733f74ab4bca66f246a3934dc31d67c0575c", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11655, "url": "http://patches.dpdk.org/api/series/11655/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11655", "date": "2020-08-14T11:00:41", "name": "fixes for example app builds", "version": 1, "mbox": "http://patches.dpdk.org/series/11655/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75560/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/75560/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6EC72A04AC;\n\tFri, 14 Aug 2020 13:01:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6CE1F1C112;\n\tFri, 14 Aug 2020 13:01:21 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 6B7091C10A;\n Fri, 14 Aug 2020 13:01:19 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Aug 2020 04:01:15 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.56])\n by orsmga005.jf.intel.com with ESMTP; 14 Aug 2020 04:01:13 -0700" ], "IronPort-SDR": [ "\n PX01sNHICniLtdDEshshJzbuC1+oH5df88nXS4AGgqJCuNEeTy4NJT9gyX8v/1eh5xiXhUqfEo\n qD2e4sMZg5ig==", "\n fKy/i+Cd46jYMgd9/kc9UtvifiX6+pJVzFSkpoxvDt8VvxUOc12faZFvbcf/2ZZ+M/o4uy3B82\n pBeZr/hLx2Og==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9712\"; a=\"134445498\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"134445498\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"470553464\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n David Hunt <david.hunt@intel.com>, Alan Carew <alan.carew@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Fri, 14 Aug 2020 12:00:43 +0100", "Message-Id": "<20200814110045.217724-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200814110045.217724-1-bruce.richardson@intel.com>", "References": "<20200814110045.217724-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/4] examples/vm_power_manager: fix string\n\ttruncation warning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When compiling on ubuntu 20.04, a warning was issued about possible\ntruncation of the path string for the power management socket.\n\nchannel_manager.c: In function ‘add_all_channels’:\nchannel_manager.c:470:41: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 90 [-Wformat-truncation=]\n 470 | sizeof(chan_info->channel_path), \"%s%s\",\n | ^~\n\nThis can be fixed by adding in an explicit truncation check to the code and\nhandling it appropriately.\n\nFixes: e8ae9b662506 (\"examples/vm_power: channel manager and monitor in host\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vm_power_manager/channel_manager.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c\nindex 3da01b46d8..0a28cb643b 100644\n--- a/examples/vm_power_manager/channel_manager.c\n+++ b/examples/vm_power_manager/channel_manager.c\n@@ -466,9 +466,15 @@ add_all_channels(const char *vm_name)\n \t\t\tcontinue;\n \t\t}\n \n-\t\tsnprintf(chan_info->channel_path,\n+\t\tif ((size_t)snprintf(chan_info->channel_path,\n \t\t\t\tsizeof(chan_info->channel_path), \"%s%s\",\n-\t\t\t\tCHANNEL_MGR_SOCKET_PATH, dir->d_name);\n+\t\t\t\tCHANNEL_MGR_SOCKET_PATH, dir->d_name)\n+\t\t\t\t\t>= sizeof(chan_info->channel_path)) {\n+\t\t\tRTE_LOG(ERR, CHANNEL_MANAGER, \"Pathname too long for channel '%s%s'\\n\",\n+\t\t\t\t\tCHANNEL_MGR_SOCKET_PATH, dir->d_name);\n+\t\t\trte_free(chan_info);\n+\t\t\tcontinue;\n+\t\t}\n \n \t\tif (setup_channel_info(&vm_info, &chan_info, channel_num) < 0) {\n \t\t\trte_free(chan_info);\n", "prefixes": [ "2/4" ] }