Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75559/?format=api
{ "id": 75559, "url": "http://patches.dpdk.org/api/patches/75559/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200814110045.217724-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200814110045.217724-2-bruce.richardson@intel.com", "date": "2020-08-14T11:00:42", "name": "[1/4] power: make guest channel headers public", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "370bf7fbdb5526acc435ce6e1bae1431322b5a6b", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11655, "url": "http://patches.dpdk.org/api/series/11655/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11655", "date": "2020-08-14T11:00:41", "name": "fixes for example app builds", "version": 1, "mbox": "http://patches.dpdk.org/series/11655/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75559/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75559/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 195B9A04B0;\n\tFri, 14 Aug 2020 13:01:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E1A881C0D8;\n\tFri, 14 Aug 2020 13:01:11 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id D7CA61C0D7;\n Fri, 14 Aug 2020 13:01:09 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Aug 2020 04:01:08 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.56])\n by orsmga005.jf.intel.com with ESMTP; 14 Aug 2020 04:01:07 -0700" ], "IronPort-SDR": [ "\n h5xCcHb9OHT/isoCheO6vrgX1Rs4GtzAEUOd3agXEmKAnTz1Y0xZsbp/Aet1hZZDO8MXSs9TVb\n KKU+xTKwKOSQ==", "\n +SAFmVbo6QKCgMN24MptKvqvSZrg8niOHuJ5GT//g87VyzizN5M4i/DvvxRoX1tTrkxP6tRc9+\n QXTnXc+Eg1IA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9712\"; a=\"154349810\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"154349810\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"470553423\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n David Hunt <david.hunt@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n Alan Carew <alan.carew@intel.com>", "Date": "Fri, 14 Aug 2020 12:00:42 +0100", "Message-Id": "<20200814110045.217724-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200814110045.217724-1-bruce.richardson@intel.com>", "References": "<20200814110045.217724-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/4] power: make guest channel headers public", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The channel commands header file contains definitions that are used by the\nexample application for power management, and so need to be made public.\nSimilarly the guest_channel.h header is used by the guest_cli example\nutility, so needs to be public also. Without this change, the example\napps, or any end-user apps based on them, can not be compiled outside the\nmain DPDK build.\n\nFixes: 210c383e247b (\"power: packet format for vm power management\")\nFixes: cd0d5547e873 (\"power: vm communication channels in guest\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vm_power_manager/channel_manager.c | 1 -\n examples/vm_power_manager/channel_monitor.c | 1 -\n examples/vm_power_manager/channel_monitor.h | 2 +-\n examples/vm_power_manager/guest_cli/main.c | 1 +\n examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-\n examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 +-\n examples/vm_power_manager/vm_power_cli.c | 1 -\n lib/librte_power/guest_channel.c | 3 +--\n lib/librte_power/meson.build | 4 +++-\n lib/librte_power/power_kvm_vm.c | 3 +--\n .../{channel_commands.h => rte_power_channel_commands.h} | 0\n .../{guest_channel.h => rte_power_guest_channel.h} | 2 +-\n 12 files changed, 10 insertions(+), 12 deletions(-)\n rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} (100%)\n rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%)", "diff": "diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c\nindex 74a2a677e8..3da01b46d8 100644\n--- a/examples/vm_power_manager/channel_manager.c\n+++ b/examples/vm_power_manager/channel_manager.c\n@@ -27,7 +27,6 @@\n #include <libvirt/libvirt.h>\n \n #include \"channel_manager.h\"\n-#include \"channel_commands.h\"\n #include \"channel_monitor.h\"\n #include \"power_manager.h\"\n \ndiff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c\nindex 1d00a6cf6c..75a29d2589 100644\n--- a/examples/vm_power_manager/channel_monitor.c\n+++ b/examples/vm_power_manager/channel_monitor.c\n@@ -35,7 +35,6 @@\n \n #include <libvirt/libvirt.h>\n #include \"channel_monitor.h\"\n-#include \"channel_commands.h\"\n #include \"channel_manager.h\"\n #include \"power_manager.h\"\n #include \"oob_monitor.h\"\ndiff --git a/examples/vm_power_manager/channel_monitor.h b/examples/vm_power_manager/channel_monitor.h\nindex 7362a80d26..fe6ceedc95 100644\n--- a/examples/vm_power_manager/channel_monitor.h\n+++ b/examples/vm_power_manager/channel_monitor.h\n@@ -6,7 +6,7 @@\n #define CHANNEL_MONITOR_H_\n \n #include \"channel_manager.h\"\n-#include \"channel_commands.h\"\n+#include \"rte_power_channel_commands.h\"\n \n struct core_share {\n \tunsigned int pcpu;\ndiff --git a/examples/vm_power_manager/guest_cli/main.c b/examples/vm_power_manager/guest_cli/main.c\nindex f63b3c988a..4c0c98f498 100644\n--- a/examples/vm_power_manager/guest_cli/main.c\n+++ b/examples/vm_power_manager/guest_cli/main.c\n@@ -14,6 +14,7 @@\n #include <rte_eal.h>\n #include <rte_log.h>\n \n+#include \"rte_power_channel_commands.h\"\n #include \"vm_power_cli_guest.h\"\n #include \"parse.h\"\n \ndiff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\nindex 96c1a1ff69..263e7ec9ff 100644\n--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\n+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\n@@ -19,7 +19,7 @@\n #include <rte_ethdev.h>\n \n #include <rte_power.h>\n-#include <guest_channel.h>\n+#include <rte_power_guest_channel.h>\n \n #include \"vm_power_cli_guest.h\"\n \ndiff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h\nindex 6ad14a3dea..33c01ff7ca 100644\n--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h\n+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h\n@@ -9,7 +9,7 @@\n extern \"C\" {\n #endif\n \n-#include \"channel_commands.h\"\n+struct channel_packet;\n \n struct channel_packet *get_policy(void);\n \ndiff --git a/examples/vm_power_manager/vm_power_cli.c b/examples/vm_power_manager/vm_power_cli.c\nindex 7edeaccda5..4c41645664 100644\n--- a/examples/vm_power_manager/vm_power_cli.c\n+++ b/examples/vm_power_manager/vm_power_cli.c\n@@ -21,7 +21,6 @@\n #include \"channel_manager.h\"\n #include \"channel_monitor.h\"\n #include \"power_manager.h\"\n-#include \"channel_commands.h\"\n \n struct cmd_quit_result {\n \tcmdline_fixed_string_t quit;\ndiff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c\nindex 7b5926e5c4..d49cf0cd57 100644\n--- a/lib/librte_power/guest_channel.c\n+++ b/lib/librte_power/guest_channel.c\n@@ -16,8 +16,7 @@\n \n #include <rte_log.h>\n \n-#include \"guest_channel.h\"\n-#include \"channel_commands.h\"\n+#include \"rte_power_guest_channel.h\"\n \n #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1\n \ndiff --git a/lib/librte_power/meson.build b/lib/librte_power/meson.build\nindex 78c031c943..e9b1fa6e45 100644\n--- a/lib/librte_power/meson.build\n+++ b/lib/librte_power/meson.build\n@@ -10,5 +10,7 @@ sources = files('rte_power.c', 'power_acpi_cpufreq.c',\n \t\t'rte_power_empty_poll.c',\n \t\t'power_pstate_cpufreq.c',\n \t\t'power_common.c')\n-headers = files('rte_power.h','rte_power_empty_poll.h')\n+headers = files('rte_power.h','rte_power_empty_poll.h',\n+\t\t'rte_power_guest_channel.h',\n+\t\t'rte_power_channel_commands.h')\n deps += ['timer']\ndiff --git a/lib/librte_power/power_kvm_vm.c b/lib/librte_power/power_kvm_vm.c\nindex 409c3e03ab..e9094e1230 100644\n--- a/lib/librte_power/power_kvm_vm.c\n+++ b/lib/librte_power/power_kvm_vm.c\n@@ -6,8 +6,7 @@\n \n #include <rte_log.h>\n \n-#include \"guest_channel.h\"\n-#include \"channel_commands.h\"\n+#include \"rte_power_guest_channel.h\"\n #include \"power_kvm_vm.h\"\n #include \"power_common.h\"\n \ndiff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/rte_power_channel_commands.h\nsimilarity index 100%\nrename from lib/librte_power/channel_commands.h\nrename to lib/librte_power/rte_power_channel_commands.h\ndiff --git a/lib/librte_power/guest_channel.h b/lib/librte_power/rte_power_guest_channel.h\nsimilarity index 98%\nrename from lib/librte_power/guest_channel.h\nrename to lib/librte_power/rte_power_guest_channel.h\nindex e15db46fc7..9853839129 100644\n--- a/lib/librte_power/guest_channel.h\n+++ b/lib/librte_power/rte_power_guest_channel.h\n@@ -8,7 +8,7 @@\n extern \"C\" {\n #endif\n \n-#include <channel_commands.h>\n+#include <rte_power_channel_commands.h>\n \n /**\n * Check if any Virtio-Serial VM end-points exist in path.\n", "prefixes": [ "1/4" ] }