Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75525/?format=api
{ "id": 75525, "url": "http://patches.dpdk.org/api/patches/75525/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1597360905-74106-11-git-send-email-navasile@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1597360905-74106-11-git-send-email-navasile@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1597360905-74106-11-git-send-email-navasile@linux.microsoft.com", "date": "2020-08-13T23:21:33", "name": "[10/22] uio: move SDDL string to INF on Windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "96f8e13c5b92f0aa7e329400fcdb0d058cb6ba8f", "submitter": { "id": 1668, "url": "http://patches.dpdk.org/api/people/1668/?format=api", "name": "Narcisa Ana Maria Vasile", "email": "navasile@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1597360905-74106-11-git-send-email-navasile@linux.microsoft.com/mbox/", "series": [ { "id": 11644, "url": "http://patches.dpdk.org/api/series/11644/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11644", "date": "2020-08-13T23:21:23", "name": "windows/netuio: add netuio driver for Windows", "version": 1, "mbox": "http://patches.dpdk.org/series/11644/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75525/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/75525/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3162AA04B1;\n\tFri, 14 Aug 2020 01:23:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 547601C12D;\n\tFri, 14 Aug 2020 01:22:54 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by dpdk.org (Postfix) with ESMTP id 066781C0D4\n for <dev@dpdk.org>; Fri, 14 Aug 2020 01:22:45 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1059)\n id E687220B4920; Thu, 13 Aug 2020 16:22:43 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E687220B4920", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1597360963;\n bh=aOf8EmcQn/hUQI5C+ip9HjlbSfVaBbC7WRgOSOVlVS8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=TX3H7oa5THthqxR8V+nqa97TJDfo8AeqZ5HWZH5yrvzZ8BrPXoIvE2R/9FWjAZMmh\n uOMynMFM1yyGt6NYiYSrF+tbUmzg9BnaWJBvmlnX+C9FRN8ycoNek97lI121P3VDzl\n /KfFHLFHN5pBcL+DH4eG8cXEjfKTj7IqmcIx8t28=", "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>", "To": "dev@dpdk.org, thomas@monjalon.net, haramakr@linux.microsoft.com,\n ocardona@microsoft.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com", "Cc": "ranjit.menon@intel.com, dmitrym@microsoft.com,\n Harini Ramakrishnan <haramakr@microsoft.com>", "Date": "Thu, 13 Aug 2020 16:21:33 -0700", "Message-Id": "<1597360905-74106-11-git-send-email-navasile@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>", "References": "<1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>", "Subject": "[dpdk-dev] [PATCH 10/22] uio: move SDDL string to INF on Windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Harini Ramakrishnan <haramakr@microsoft.com>\n\n---\n kernel/windows/netuio/netuio.inf | 7 +++++++\n kernel/windows/netuio/netuio_dev.c | 15 +++++----------\n 2 files changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/kernel/windows/netuio/netuio.inf b/kernel/windows/netuio/netuio.inf\nindex 0453b371a..b1696cc50 100644\n--- a/kernel/windows/netuio/netuio.inf\n+++ b/kernel/windows/netuio/netuio.inf\n@@ -62,6 +62,13 @@ CopyFiles=Drivers_Dir\n [Drivers_Dir]\n netuio.sys\n \n+[netuio_Device.NT.HW]\n+AddReg=Device.HW.Registry\n+\n+[Device.HW.Registry]\n+; Ensure that only administrators can access our device object.\n+HKR,,Security,,\"D:P(A;;GA;;;SY)(A;;GA;;;BA)\"\n+\n ;-------------- Service installation\n [netuio_Device.NT.Services]\n AddService = netuio,%SPSVCINST_ASSOCSERVICE%, netuio_Service_Inst\ndiff --git a/kernel/windows/netuio/netuio_dev.c b/kernel/windows/netuio/netuio_dev.c\nindex f5d41cb65..a1fe447f7 100644\n--- a/kernel/windows/netuio/netuio_dev.c\n+++ b/kernel/windows/netuio/netuio_dev.c\n@@ -33,18 +33,13 @@ netuio_create_device(_Inout_ PWDFDEVICE_INIT DeviceInit)\n \n PAGED_CODE();\n \n- // Ensure that only administrators can access our device object.\n- status = WdfDeviceInitAssignSDDLString(DeviceInit, &SDDL_DEVOBJ_SYS_ALL_ADM_ALL);\n+ WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);\n \n- if (NT_SUCCESS(status)) {\n- WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);\n-\n- // Set the device context cleanup callback.\n- // This function will be called when the WDF Device Object associated to the current device is destroyed\n- deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;\n+ // Set the device context cleanup callback.\n+ // This function will be called when the WDF Device Object associated to the current device is destroyed\n+ deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;\n \n- status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);\n- }\n+ status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);\n \n \tif (NT_SUCCESS(status)) {\n \t\t// Create a device interface so that applications can find and talk to us.\n", "prefixes": [ "10/22" ] }