Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75503/?format=api
{ "id": 75503, "url": "http://patches.dpdk.org/api/patches/75503/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200813172344.3228-3-vikas.gupta@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200813172344.3228-3-vikas.gupta@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200813172344.3228-3-vikas.gupta@broadcom.com", "date": "2020-08-13T17:23:38", "name": "[v2,2/8] crypto/bcmfs: add vfio support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4ff34685230f91d81cf7446bed7bb81cf637a65a", "submitter": { "id": 1907, "url": "http://patches.dpdk.org/api/people/1907/?format=api", "name": "Vikas Gupta", "email": "vikas.gupta@broadcom.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200813172344.3228-3-vikas.gupta@broadcom.com/mbox/", "series": [ { "id": 11642, "url": "http://patches.dpdk.org/api/series/11642/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11642", "date": "2020-08-13T17:23:36", "name": "Add Crypto PMD for Broadcom`s FlexSparc devices", "version": 2, "mbox": "http://patches.dpdk.org/series/11642/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75503/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75503/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ADAC4A04B0;\n\tThu, 13 Aug 2020 19:24:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 114871C0CE;\n\tThu, 13 Aug 2020 19:24:07 +0200 (CEST)", "from mail-qt1-f195.google.com (mail-qt1-f195.google.com\n [209.85.160.195]) by dpdk.org (Postfix) with ESMTP id 18B6C1C0D2\n for <dev@dpdk.org>; Thu, 13 Aug 2020 19:24:05 +0200 (CEST)", "by mail-qt1-f195.google.com with SMTP id f19so439368qtp.2\n for <dev@dpdk.org>; Thu, 13 Aug 2020 10:24:05 -0700 (PDT)", "from rahul_yocto_ubuntu18.ibn.broadcom.net ([192.19.234.250])\n by smtp.gmail.com with ESMTPSA id g129sm6246635qkb.39.2020.08.13.10.24.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 13 Aug 2020 10:24:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=eYtOjoKRuQ7dsEkvDwOB1OKgYYjcvEzdLyXIBCQzGbI=;\n b=MJtDGrB3I1/k9ntFSH/i8JuRv+rJMDq+qteuPO7899SOoXJxSZR7knc0yM1vPZ/YeW\n a3vuD0WWUTElcSRP9ONGPlN+u5od3wIgSkoU+XuWTzNI4x5Lr1dTMB+99x6DSF/AnqCV\n 2NNRgqAE90Kk/blw7mHENkAVduEaY1vutvbkM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=eYtOjoKRuQ7dsEkvDwOB1OKgYYjcvEzdLyXIBCQzGbI=;\n b=OXEqyuSbXpUDByjJjSTw4giJh7Hw3RxzSrfR2acg5mHGUt3cFapLK0BRxJiQMX1zmG\n eAbmDXVhAn8qXRwbJ/E5LbkIJeq9RiRHGD3EEXzlPvmMxdFVwBs1IbMGSeP5TH1eB26b\n 9iaYxlWbnYrSaOkg77pBM2Dib0U1YKGbU0MzEYVySNLSnmkcNnK4vf1d3c49wDc240I4\n r1QpdsTryOVzw+RuAi/YJbV/Hx4zNmVNA8hflqUci46+YtRfSj2SztK+EhT4nSQSP/YU\n Rvqt/+DSDDRc1QsSawyaGATeBojl8TLbs0WCJszf4ITRf3jb29LL2Ytb8xt5P0LAs2fl\n 0jNQ==", "X-Gm-Message-State": "AOAM533v9vQev5yFrhfwhQnjCIyCx+ZbDuDRnhYmU62HIwDvITnlBnFi\n V0UjyCNp0k2QY2ZzCFIfXQ0TKps/upwlQJ8oNr5F/Yui192aAVbLYE8m1la24HyQP+kRhVZhDqZ\n dHjymgqx5L9dWmOvE/yixT2t6dH3amMEWc/AZXB6dOZ6ZhrNex9GCsgrtzNSF", "X-Google-Smtp-Source": "\n ABdhPJyi+g303vL8qZFfvi4D+c0Jvkh8JS3Sl88Fhbt4GvZLpvY9K/ysuI5ncgiJh4iybVOBOwYZuA==", "X-Received": "by 2002:ac8:7593:: with SMTP id s19mr6378645qtq.199.1597339444038;\n Thu, 13 Aug 2020 10:24:04 -0700 (PDT)", "From": "Vikas Gupta <vikas.gupta@broadcom.com>", "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com", "Cc": "vikram.prakash@broadcom.com, Vikas Gupta <vikas.gupta@broadcom.com>,\n Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>", "Date": "Thu, 13 Aug 2020 22:53:38 +0530", "Message-Id": "<20200813172344.3228-3-vikas.gupta@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200813172344.3228-1-vikas.gupta@broadcom.com>", "References": "<20200812063127.8687-1-vikas.gupta@broadcom.com>\n <20200813172344.3228-1-vikas.gupta@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 2/8] crypto/bcmfs: add vfio support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add vfio support for device.\n\nSigned-off-by: Vikas Gupta <vikas.gupta@broadcom.com>\nSigned-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/crypto/bcmfs/bcmfs_device.c | 5 ++\n drivers/crypto/bcmfs/bcmfs_device.h | 6 ++\n drivers/crypto/bcmfs/bcmfs_vfio.c | 107 ++++++++++++++++++++++++++++\n drivers/crypto/bcmfs/bcmfs_vfio.h | 17 +++++\n drivers/crypto/bcmfs/meson.build | 3 +-\n 5 files changed, 137 insertions(+), 1 deletion(-)\n create mode 100644 drivers/crypto/bcmfs/bcmfs_vfio.c\n create mode 100644 drivers/crypto/bcmfs/bcmfs_vfio.h", "diff": "diff --git a/drivers/crypto/bcmfs/bcmfs_device.c b/drivers/crypto/bcmfs/bcmfs_device.c\nindex 47c776de6..3b5cc9e98 100644\n--- a/drivers/crypto/bcmfs/bcmfs_device.c\n+++ b/drivers/crypto/bcmfs/bcmfs_device.c\n@@ -11,6 +11,7 @@\n \n #include \"bcmfs_device.h\"\n #include \"bcmfs_logs.h\"\n+#include \"bcmfs_vfio.h\"\n \n struct bcmfs_device_attr {\n \tconst char name[BCMFS_MAX_PATH_LEN];\n@@ -71,6 +72,10 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev,\n \n \tfsdev->vdev = vdev;\n \n+\t/* attach to VFIO */\n+\tif (bcmfs_attach_vfio(fsdev))\n+\t\tgoto cleanup;\n+\n \tTAILQ_INSERT_TAIL(&fsdev_list, fsdev, next);\n \n \treturn fsdev;\ndiff --git a/drivers/crypto/bcmfs/bcmfs_device.h b/drivers/crypto/bcmfs/bcmfs_device.h\nindex cc64a8df2..c41cc0031 100644\n--- a/drivers/crypto/bcmfs/bcmfs_device.h\n+++ b/drivers/crypto/bcmfs/bcmfs_device.h\n@@ -35,6 +35,12 @@ struct bcmfs_device {\n \tchar name[BCMFS_DEV_NAME_LEN];\n \t/* Parent vdev */\n \tstruct rte_vdev_device *vdev;\n+\t/* vfio handle */\n+\tint vfio_dev_fd;\n+\t/* mapped address */\n+\tuint8_t *mmap_addr;\n+\t/* mapped size */\n+\tuint32_t mmap_size;\n };\n \n #endif /* _BCMFS_DEV_H_ */\ndiff --git a/drivers/crypto/bcmfs/bcmfs_vfio.c b/drivers/crypto/bcmfs/bcmfs_vfio.c\nnew file mode 100644\nindex 000000000..dc2def580\n--- /dev/null\n+++ b/drivers/crypto/bcmfs/bcmfs_vfio.c\n@@ -0,0 +1,107 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Broadcom.\n+ * All rights reserved.\n+ */\n+\n+#include <errno.h>\n+#include <sys/mman.h>\n+#include <sys/ioctl.h>\n+\n+#include <rte_vfio.h>\n+\n+#include \"bcmfs_device.h\"\n+#include \"bcmfs_logs.h\"\n+#include \"bcmfs_vfio.h\"\n+\n+#ifdef VFIO_PRESENT\n+static int\n+vfio_map_dev_obj(const char *path, const char *dev_obj,\n+\t\t uint32_t *size, void **addr, int *dev_fd)\n+{\n+\tint32_t ret;\n+\tstruct vfio_group_status status = { .argsz = sizeof(status) };\n+\n+\tstruct vfio_device_info d_info = { .argsz = sizeof(d_info) };\n+\tstruct vfio_region_info reg_info = { .argsz = sizeof(reg_info) };\n+\n+\tret = rte_vfio_setup_device(path, dev_obj, dev_fd, &d_info);\n+\tif (ret) {\n+\t\tBCMFS_LOG(ERR, \"VFIO Setting for device failed\");\n+\t\treturn ret;\n+\t}\n+\n+\t/* getting device region info*/\n+\tret = ioctl(*dev_fd, VFIO_DEVICE_GET_REGION_INFO, ®_info);\n+\tif (ret < 0) {\n+\t\tBCMFS_LOG(ERR, \"Error in VFIO getting REGION_INFO\");\n+\t\tgoto map_failed;\n+\t}\n+\n+\t*addr = mmap(NULL, reg_info.size,\n+\t\t PROT_WRITE | PROT_READ, MAP_SHARED,\n+\t\t *dev_fd, reg_info.offset);\n+\tif (*addr == MAP_FAILED) {\n+\t\tBCMFS_LOG(ERR, \"Error mapping region (errno = %d)\", errno);\n+\t\tret = errno;\n+\t\tgoto map_failed;\n+\t}\n+\t*size = reg_info.size;\n+\n+\treturn 0;\n+\n+map_failed:\n+\trte_vfio_release_device(path, dev_obj, *dev_fd);\n+\n+\treturn ret;\n+}\n+\n+int\n+bcmfs_attach_vfio(struct bcmfs_device *dev)\n+{\n+\tint ret;\n+\tint vfio_dev_fd;\n+\tvoid *v_addr = NULL;\n+\tuint32_t size = 0;\n+\n+\tret = vfio_map_dev_obj(dev->dirname, dev->name,\n+\t\t\t &size, &v_addr, &vfio_dev_fd);\n+\tif (ret)\n+\t\treturn -1;\n+\n+\tdev->mmap_size = size;\n+\tdev->mmap_addr = v_addr;\n+\tdev->vfio_dev_fd = vfio_dev_fd;\n+\n+\treturn 0;\n+}\n+\n+void\n+bcmfs_release_vfio(struct bcmfs_device *dev)\n+{\n+\tint ret;\n+\n+\tif (dev == NULL)\n+\t\treturn;\n+\n+\t/* unmap the addr */\n+\tmunmap(dev->mmap_addr, dev->mmap_size);\n+\t/* release the device */\n+\tret = rte_vfio_release_device(dev->dirname, dev->name,\n+\t\t\t\t dev->vfio_dev_fd);\n+\tif (ret < 0) {\n+\t\tBCMFS_LOG(ERR, \"cannot release device\");\n+\t\treturn;\n+\t}\n+}\n+#else\n+int\n+bcmfs_attach_vfio(struct bcmfs_device *dev __rte_unused)\n+{\n+\treturn -1;\n+}\n+\n+void\n+bcmfs_release_vfio(struct bcmfs_device *dev __rte_unused)\n+{\n+}\n+#endif\ndiff --git a/drivers/crypto/bcmfs/bcmfs_vfio.h b/drivers/crypto/bcmfs/bcmfs_vfio.h\nnew file mode 100644\nindex 000000000..d0fdf6483\n--- /dev/null\n+++ b/drivers/crypto/bcmfs/bcmfs_vfio.h\n@@ -0,0 +1,17 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2020 Broadcom\n+ * All rights reserved.\n+ */\n+\n+#ifndef _BCMFS_VFIO_H_\n+#define _BCMFS_VFIO_H_\n+\n+/* Attach the bcmfs device to vfio */\n+int\n+bcmfs_attach_vfio(struct bcmfs_device *dev);\n+\n+/* Release the bcmfs device from vfio */\n+void\n+bcmfs_release_vfio(struct bcmfs_device *dev);\n+\n+#endif /* _BCMFS_VFIO_H_ */\ndiff --git a/drivers/crypto/bcmfs/meson.build b/drivers/crypto/bcmfs/meson.build\nindex a4bdd8ee5..fd39eba20 100644\n--- a/drivers/crypto/bcmfs/meson.build\n+++ b/drivers/crypto/bcmfs/meson.build\n@@ -6,5 +6,6 @@\n deps += ['eal', 'bus_vdev']\n sources = files(\n \t\t'bcmfs_logs.c',\n-\t\t'bcmfs_device.c'\n+\t\t'bcmfs_device.c',\n+\t\t'bcmfs_vfio.c'\n \t\t)\n", "prefixes": [ "v2", "2/8" ] }