Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75467/?format=api
{ "id": 75467, "url": "http://patches.dpdk.org/api/patches/75467/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200812191847.16529-4-steven.lariau@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200812191847.16529-4-steven.lariau@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200812191847.16529-4-steven.lariau@arm.com", "date": "2020-08-12T19:18:46", "name": "[v2,3/4] test/stack: propagate errors to main core", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4d286d3d01ca251edf80337eb79669842b5ec9b2", "submitter": { "id": 1862, "url": "http://patches.dpdk.org/api/people/1862/?format=api", "name": "Steven Lariau", "email": "steven.lariau@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200812191847.16529-4-steven.lariau@arm.com/mbox/", "series": [ { "id": 11622, "url": "http://patches.dpdk.org/api/series/11622/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11622", "date": "2020-08-12T19:18:43", "name": "test/stack: improve multithreaded test", "version": 2, "mbox": "http://patches.dpdk.org/series/11622/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75467/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75467/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B6207A04DB;\n\tWed, 12 Aug 2020 21:20:59 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5BF8B1C0CF;\n\tWed, 12 Aug 2020 21:20:59 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 2C77D1C0C5\n for <dev@dpdk.org>; Wed, 12 Aug 2020 21:20:58 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2C4BD6E;\n Wed, 12 Aug 2020 12:20:57 -0700 (PDT)", "from localhost.localdomain (unknown [10.57.38.163])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE6313F22E;\n Wed, 12 Aug 2020 12:20:56 -0700 (PDT)" ], "From": "Steven Lariau <steven.lariau@arm.com>", "To": "Gage Eads <gage.eads@intel.com>,\n\tOlivier Matz <olivier.matz@6wind.com>", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tSteven Lariau <steven.lariau@arm.com>", "Date": "Wed, 12 Aug 2020 20:18:46 +0100", "Message-Id": "<20200812191847.16529-4-steven.lariau@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200812191847.16529-1-steven.lariau@arm.com>", "References": "<20200805155721.19808-1-steven.lariau@arm.com>\n <20200812191847.16529-1-steven.lariau@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 3/4] test/stack: propagate errors to main core", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use rte_eal_wait_lcore to wait and get the return value for all cores.\nThis is used to propagate any error to the main core.\n\nSigned-off-by: Steven Lariau <steven.lariau@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Gage Eads <gage.eads@intel.com>\n---\n app/test/test_stack.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_stack.c b/app/test/test_stack.c\nindex efd473855..d959b566a 100644\n--- a/app/test/test_stack.c\n+++ b/app/test/test_stack.c\n@@ -322,8 +322,10 @@ stack_thread_push_pop(__rte_unused void *args)\n static int\n test_stack_multithreaded(uint32_t flags)\n {\n+\tunsigned int lcore_id;\n \tstruct rte_stack *s;\n \trte_atomic64_t size;\n+\tint result = 0;\n \n \tif (rte_lcore_count() < 2) {\n \t\tprintf(\"Not enough cores for test_stack_multithreaded, expecting at least 2\\n\");\n@@ -346,10 +348,14 @@ test_stack_multithreaded(uint32_t flags)\n \n \tif (rte_eal_mp_remote_launch(stack_thread_push_pop, NULL, CALL_MASTER))\n \t\trte_panic(\"Failed to launch tests\\n\");\n-\trte_eal_mp_wait_lcore();\n+\n+\tRTE_LCORE_FOREACH(lcore_id) {\n+\t\tif (rte_eal_wait_lcore(lcore_id) < 0)\n+\t\t\tresult = -1;\n+\t}\n \n \trte_stack_free(s);\n-\treturn 0;\n+\treturn result;\n }\n \n static int\n", "prefixes": [ "v2", "3/4" ] }