Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 75360,
    "url": "http://patches.dpdk.org/api/patches/75360/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200811062424.14248-5-fady@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200811062424.14248-5-fady@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200811062424.14248-5-fady@mellanox.com",
    "date": "2020-08-11T06:24:23",
    "name": "[v5,4/5] telemetry: implement empty stubs for Windows",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "3711ba60a4325b4b45fbc5cd4fd9b518a3e451c4",
    "submitter": {
        "id": 1650,
        "url": "http://patches.dpdk.org/api/people/1650/?format=api",
        "name": "Fady Bader",
        "email": "fady@mellanox.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200811062424.14248-5-fady@mellanox.com/mbox/",
    "series": [
        {
            "id": 11580,
            "url": "http://patches.dpdk.org/api/series/11580/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11580",
            "date": "2020-08-11T06:24:19",
            "name": "compiling ethdev lib under windows",
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/11580/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/75360/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/75360/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87D6AA04D8;\n\tTue, 11 Aug 2020 08:25:59 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D36171C0BC;\n\tTue, 11 Aug 2020 08:25:22 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 481041C027\n for <dev@dpdk.org>; Tue, 11 Aug 2020 08:25:16 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n fady@mellanox.com) with SMTP; 11 Aug 2020 09:25:12 +0300",
            "from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx\n [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 07B6P7ZT029652;\n Tue, 11 Aug 2020 09:25:12 +0300"
        ],
        "From": "Fady Bader <fady@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com,\n yohadt@mellanox.com, dmitry.kozliuk@gmail.com,\n harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,\n pallavi.kadam@intel.com, ranjit.menon@intel.com, kevin.laatz@intel.com,\n ferruh.yigit@intel.com, arybchenko@solarflare.com,\n ciara.power@intel.com, navasile@linux.microsoft.com",
        "Date": "Tue, 11 Aug 2020 09:24:23 +0300",
        "Message-Id": "<20200811062424.14248-5-fady@mellanox.com>",
        "X-Mailer": "git-send-email 2.16.1.windows.4",
        "In-Reply-To": "<20200811062424.14248-1-fady@mellanox.com>",
        "References": "<20200625133038.25180-1-fady@mellanox.com>\n <20200811062424.14248-1-fady@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v5 4/5] telemetry: implement empty stubs for\n\tWindows",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Telemetry didn't compile under Windows.\nEmpty stubs implementation was added for Windows.\n\nSigned-off-by: Fady Bader <fady@mellanox.com>\n---\n lib/librte_telemetry/rte_telemetry.h    |  4 +++\n lib/librte_telemetry/telemetry.c        | 50 +++++++++++++++++++++++++++++++++\n lib/librte_telemetry/telemetry_legacy.c | 25 +++++++++++++++++\n 3 files changed, 79 insertions(+)",
    "diff": "diff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h\nindex d13010b8fb..c3c0e44599 100644\n--- a/lib/librte_telemetry/rte_telemetry.h\n+++ b/lib/librte_telemetry/rte_telemetry.h\n@@ -5,6 +5,10 @@\n #include <stdint.h>\n #include <rte_compat.h>\n \n+#ifdef RTE_EXEC_ENV_WINDOWS\n+#include <sched.h>\n+#endif\n+\n #ifndef _RTE_TELEMETRY_H_\n #define _RTE_TELEMETRY_H_\n \ndiff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c\nindex 0252282735..59ad9cc7ec 100644\n--- a/lib/librte_telemetry/telemetry.c\n+++ b/lib/librte_telemetry/telemetry.c\n@@ -2,6 +2,7 @@\n  * Copyright(c) 2020 Intel Corporation\n  */\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n #include <unistd.h>\n #include <pthread.h>\n #include <sys/socket.h>\n@@ -20,6 +21,20 @@\n #include \"telemetry_data.h\"\n #include \"rte_telemetry_legacy.h\"\n \n+#else /* RTE_EXEC_ENV_WINDOWS */\n+\n+/* includes for Windows */\n+#include <rte_common.h>\n+#include <rte_log.h>\n+\n+#include \"rte_telemetry.h\"\n+#include \"telemetry_json.h\"\n+#include \"telemetry_data.h\"\n+#include \"rte_telemetry_legacy.h\"\n+\n+#endif\n+\n+#ifndef RTE_EXEC_ENV_WINDOWS\n #define MAX_CMD_LEN 56\n #define MAX_HELP_LEN 64\n #define MAX_OUTPUT_LEN (1024 * 16)\n@@ -42,17 +57,24 @@ struct socket {\n };\n static struct socket v2_socket; /* socket for v2 telemetry */\n static struct socket v1_socket; /* socket for v1 telemetry */\n+#endif\n+\n static char telemetry_log_error[1024]; /* Will contain error on init failure */\n+\n+#ifndef RTE_EXEC_ENV_WINDOWS\n /* list of command callbacks, with one command registered by default */\n static struct cmd_callback callbacks[TELEMETRY_MAX_CALLBACKS];\n static int num_callbacks; /* How many commands are registered */\n /* Used when accessing or modifying list of command callbacks */\n static rte_spinlock_t callback_sl = RTE_SPINLOCK_INITIALIZER;\n static uint16_t v2_clients;\n+#endif\n \n int\n rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help)\n {\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+\n \tint i = 0;\n \n \tif (strlen(cmd) >= MAX_CMD_LEN || fn == NULL || cmd[0] != '/'\n@@ -76,8 +98,19 @@ rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help)\n \trte_spinlock_unlock(&callback_sl);\n \n \treturn 0;\n+\n+#else /* RTE_EXEC_ENV_WINDOWS */\n+\n+\tRTE_SET_USED(cmd);\n+\tRTE_SET_USED(fn);\n+\tRTE_SET_USED(help);\n+\n+\treturn 0;\n+\n+#endif\n }\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n static int\n list_commands(const char *cmd __rte_unused, const char *params __rte_unused,\n \t\tstruct rte_tel_data *d)\n@@ -411,11 +444,14 @@ telemetry_v2_init(const char *runtime_dir, rte_cpuset_t *cpuset)\n \n \treturn 0;\n }\n+#endif\n \n int32_t\n rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset,\n \t\tconst char **err_str)\n {\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+\n \tif (telemetry_v2_init(runtime_dir, cpuset) != 0) {\n \t\t*err_str = telemetry_log_error;\n \t\treturn -1;\n@@ -424,4 +460,18 @@ rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset,\n \t\t*err_str = telemetry_log_error;\n \t}\n \treturn 0;\n+\n+#else /* RTE_EXEC_ENV_WINDOWS */\n+\n+\tRTE_SET_USED(runtime_dir);\n+\tRTE_SET_USED(cpuset);\n+\tRTE_SET_USED(err_str);\n+\n+\tsnprintf(telemetry_log_error, sizeof(telemetry_log_error),\n+\t\t\"Telemetry is not supported on Windows.\");\n+\n+\treturn 0;\n+\n+#endif\n }\n+\ndiff --git a/lib/librte_telemetry/telemetry_legacy.c b/lib/librte_telemetry/telemetry_legacy.c\nindex a341fe4ebd..40e7bbe2f8 100644\n--- a/lib/librte_telemetry/telemetry_legacy.c\n+++ b/lib/librte_telemetry/telemetry_legacy.c\n@@ -2,6 +2,7 @@\n  * Copyright(c) 2020 Intel Corporation\n  */\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n #include <unistd.h>\n #include <sys/socket.h>\n #include <sys/un.h>\n@@ -15,6 +16,15 @@\n \n #include \"rte_telemetry_legacy.h\"\n \n+#else /* RTE_EXEC_ENV_WINDOWS */\n+\n+#include <rte_common.h>\n+\n+#include \"rte_telemetry_legacy.h\"\n+\n+#endif\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+\n #define MAX_LEN 128\n #define BUF_SIZE 1024\n #define CLIENTS_UNREG_ACTION \"\\\"action\\\":2\"\n@@ -48,12 +58,15 @@ struct json_command callbacks[TELEMETRY_LEGACY_MAX_CALLBACKS] = {\n };\n int num_legacy_callbacks = 1;\n static rte_spinlock_t callback_sl = RTE_SPINLOCK_INITIALIZER;\n+#endif\n \n int\n rte_telemetry_legacy_register(const char *cmd,\n \t\tenum rte_telemetry_legacy_data_req data_req,\n \t\ttelemetry_legacy_cb fn)\n {\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+\n \tif (fn == NULL)\n \t\treturn -EINVAL;\n \tif (num_legacy_callbacks >= (int) RTE_DIM(callbacks))\n@@ -71,8 +84,19 @@ rte_telemetry_legacy_register(const char *cmd,\n \trte_spinlock_unlock(&callback_sl);\n \n \treturn 0;\n+\n+#else /* RTE_EXEC_ENV_WINDOWS */\n+\n+\tRTE_SET_USED(cmd);\n+\tRTE_SET_USED(data_req);\n+\tRTE_SET_USED(fn);\n+\n+\treturn 0;\n+\n+#endif\n }\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n static int\n register_client(const char *cmd __rte_unused, const char *params,\n \t\tchar *buffer __rte_unused, int buf_len __rte_unused)\n@@ -239,3 +263,4 @@ legacy_client_handler(void *sock_id)\n \tclose(s);\n \treturn NULL;\n }\n+#endif\n",
    "prefixes": [
        "v5",
        "4/5"
    ]
}